Support and resistance zones with variables arrays

• 04/08/2020 at 4:54 PM #125286
  stefou102

  Hello,

  I copied the code posted by Nicolas in his arrays post and tried to improve  it. Unfortunately I couldn’t;)

  In detail, I modified 3 points:

  • the fractal to find the top and bottoms, but it’s a detail
  • I’m mixing bottoms and tops to find overlap, instead of classic support and resistance
  • to avoid having multiple zone mixing each other around the same price, I tried to add a third array, in order to store the levels found, and then displayed only those which have enough space space between them. However, this is the part bugging…

  Does someone knows how to fix the third point? I think the error is around the part:

  for x=0 to lastset($overlap) do

  if abs(($BOTy[y]+$TOPy[i])/2 – $overlap[x])>percent*2 then

  count=count+1

  endif

  if count=lastset($overlap) then

  ….

  defparam calculateonlastbars=200 barlimit = 200 percent=0.1 //the fractal code to find top/bottoms if low[1]>low[4] and low[2]>low[4] and low[3]>low[4] and low[4]<low[5] and low[4]<low[6] and low[4]<low[7] then $BOTy[lastset($BOTy)+1] = close[4] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[4] //stire fractal barindex endif if high[1]<high[4] and high[2]<high[4] and high[3]<high[4] and high[4]>high[5] and high[4]>high[6] and high[4]>high[7] then $TOPy[lastset($TOPy)+1] = close[4] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[4] //store fractal barindex endif if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do //check each bottom change=abs(($BOTy[y]-$topy[i])/$topy[i]) //percent range between a top and a bottom if change<=percent/100 and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then if isset($overlap[0]) then //if the array is not empty count=0 for x=0 to lastset($overlap) do // loop through the array of level if abs(($BOTy[y]+$TOPy[i])/2 - $overlap[x])>percent*2 then // if the new level has enough space with those existing, I increment count=count+1 endif if count=lastset($overlap) then $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 if close>min($BOTy[y],$topy[i]) then //define the color r=0 g=255 else r=255 g=0 endif //plot points at each tops DRAWPOINT($topx[i],$topy[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($BOTx[y],$BOTy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0) //plot the zone drawrectangle(min($BOTx[y],$topx[i]),$BOTy[y],barindex,$topy[i]) coloured(r,g,50,50) bordercolor(r,g,0) endif next else $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 if close>min($BOTy[y],$topy[i]) then //define the color r=0 g=255 else r=255 g=0 endif //plot points at each tops DRAWPOINT($topx[i],$topy[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($BOTx[y],$BOTy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0) //plot the zone drawrectangle(min($BOTx[y],$topx[i]),$BOTy[y],barindex,$topy[i]) coloured(r,g,50,50) bordercolor(r,g,0) endif endif next next for i = 0 to lastset($BOTy) do //loop through the bottoms for y = 0 to lastset($TOPy) do //check first bottom with other bottoms change=abs(($TOPy[y]-$boty[i])/$boty[i]) //percent range between the 2 bottoms if change<=percent/100 and barindex-$TOPx[y]<barlimit and $BOTx[i]<>$TOPx[y] then if isset($overlap[0]) then count=0 for x=0 to lastset($overlap) do if abs(($BOTy[i]+$TOPy[y])/2 - $overlap[x])>percent*2 then count=count+1 endif next if count=lastset($overlap) then $overlap[lastset($overlap)+1]=($BOTy[i]+$TOPy[y])/2 if close<max($TOPy[y],$boty[i]) then //define the color r=255 g=0 else r=0 g=255 endif DRAWPOINT($botx[i],$boty[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($TOPx[y],$TOPy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0) drawrectangle(min($TOPx[y],$botx[i]),$TOPy[y],barindex,$boty[i]) coloured(r,g,50,50) bordercolor(r,g,0) endif else $overlap[lastset($overlap)+1]=($BOTy[i]+$TOPy[y])/2 if close<max($TOPy[y],$boty[i]) then //define the color r=255 g=0 else r=0 g=255 endif DRAWPOINT($botx[i],$boty[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($TOPx[y],$TOPy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0) drawrectangle(min($TOPx[y],$botx[i]),$TOPy[y],barindex,$boty[i]) coloured(r,g,50,50) bordercolor(r,g,0) endif endif next next endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120

  defparam calculateonlastbars=200 barlimit = 200 percent=0.1   //the fractal code to find top/bottoms if low[1]>low[4] and low[2]>low[4] and low[3]>low[4] and low[4]<low[5] and low[4]<low[6] and low[4]<low[7] then $BOTy[lastset($BOTy)+1] = close[4] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[4] //stire fractal barindex endif     if high[1]<high[4] and high[2]<high[4] and high[3]<high[4] and high[4]>high[5] and high[4]>high[6] and high[4]>high[7] then $TOPy[lastset($TOPy)+1] = close[4] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[4] //store fractal barindex endif   if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then   for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do //check each bottom change=abs(($BOTy[y]-$topy[i])/$topy[i]) //percent range between a top and a bottom if change<=percent/100 and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then if isset($overlap[0]) then //if the array is not empty count=0 for x=0 to lastset($overlap) do // loop through the array of level if abs(($BOTy[y]+$TOPy[i])/2 - $overlap[x])>percent*2 then // if the new level has enough space with those existing, I increment count=count+1 endif   if count=lastset($overlap) then $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 if close>min($BOTy[y],$topy[i]) then //define the color r=0 g=255 else r=255 g=0 endif //plot points at each tops DRAWPOINT($topx[i],$topy[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($BOTx[y],$BOTy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0)   //plot the zone drawrectangle(min($BOTx[y],$topx[i]),$BOTy[y],barindex,$topy[i]) coloured(r,g,50,50) bordercolor(r,g,0) endif next else $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 if close>min($BOTy[y],$topy[i]) then //define the color r=0 g=255 else r=255 g=0 endif //plot points at each tops DRAWPOINT($topx[i],$topy[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($BOTx[y],$BOTy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0)   //plot the zone drawrectangle(min($BOTx[y],$topx[i]),$BOTy[y],barindex,$topy[i]) coloured(r,g,50,50) bordercolor(r,g,0)   endif endif next next for i = 0 to lastset($BOTy) do //loop through the bottoms for y = 0 to lastset($TOPy) do //check first bottom with other bottoms change=abs(($TOPy[y]-$boty[i])/$boty[i]) //percent range between the 2 bottoms if change<=percent/100 and barindex-$TOPx[y]<barlimit and $BOTx[i]<>$TOPx[y] then if isset($overlap[0]) then count=0 for x=0 to lastset($overlap) do if abs(($BOTy[i]+$TOPy[y])/2 - $overlap[x])>percent*2 then count=count+1 endif next   if count=lastset($overlap) then $overlap[lastset($overlap)+1]=($BOTy[i]+$TOPy[y])/2 if close<max($TOPy[y],$boty[i]) then //define the color r=255 g=0 else r=0 g=255 endif DRAWPOINT($botx[i],$boty[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($TOPx[y],$TOPy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0)   drawrectangle(min($TOPx[y],$botx[i]),$TOPy[y],barindex,$boty[i]) coloured(r,g,50,50) bordercolor(r,g,0) endif   else $overlap[lastset($overlap)+1]=($BOTy[i]+$TOPy[y])/2 if close<max($TOPy[y],$boty[i]) then //define the color r=255 g=0 else r=0 g=255 endif DRAWPOINT($botx[i],$boty[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($TOPx[y],$TOPy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0)   drawrectangle(min($TOPx[y],$botx[i]),$TOPy[y],barindex,$boty[i]) coloured(r,g,50,50) bordercolor(r,g,0)   endif endif next next     endif       return

   

   

  1 user thanked author for this post.

  Guibourse

  

  stefou102

  Participant

  Topics: 22

  Replies: 171

  Been thanked: 71 times
  04/08/2020 at 5:07 PM #125295
  Nicolas

  Your overlapping filter is a good idea! Did you try to just take a small part of the code and debug it? For instance, build a code with only support zones and check your overlap function. I know how hard it is, the first time to build PRT codes with arrays! 😉

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4741 times
  04/08/2020 at 5:45 PM #125300
  stefou102

  I thought the error was around the count, so I inverted a bit the code as below.  The problem is that I get an error of the type “infinite loop or too much iteration”

   

  for x=0 to lastset($overlap) do // loop through the array of level if abs(($BOTy[y]+$TOPy[i])/2 - $overlap[x])<percent*2 then // if the new level has enough space with those existing, I increment count=count+1 endif if count=0 then

  1 2 3 4 5 6

  for x=0 to lastset($overlap) do // loop through the array of level if abs(($BOTy[y]+$TOPy[i])/2 - $overlap[x])<percent*2 then // if the new level has enough space with those existing, I increment count=count+1 endif if count=0 then

   

  

  stefou102

  Participant

  Topics: 22

  Replies: 171

  Been thanked: 71 times
  04/08/2020 at 6:06 PM #125305
  stefou102

  what is weird is that if I cut my code by two, first I see the rectangles displayed on the chart during a few second, then the error message appears and the rectangle disappears with it…Maybe a bug remaining with this new array feature?

  defparam calculateonlastbars=200 barlimit = 200 percent=0.15 if low[1]>low[4] and low[2]>low[4] and low[3]>low[4] and low[4]<low[5] and low[4]<low[6] and low[4]<low[7] then $BOTy[lastset($BOTy)+1] = close[4] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[4] //stire fractal barindex endif if high[1]<high[4] and high[2]<high[4] and high[3]<high[4] and high[4]>high[5] and high[4]>high[6] and high[4]>high[7] then $TOPy[lastset($TOPy)+1] = close[4] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[4] //store fractal barindex endif if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then //check points in a range of X percent for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do change=abs(($BOTy[y]-$topy[i])/$topy[i]) / if change<=percent/100 and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then if isset($overlap[0]) then count=0 for x=0 to lastset($overlap) do if abs(($BOTy[y]+$TOPy[i])/2 - $overlap[x])<percent*2 then count=count+1 endif if count=0 then $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 if close>min($BOTy[y],$topy[i]) then //define the color r=0 g=255 else r=255 g=0 endif //plot points at each tops DRAWPOINT($topx[i],$topy[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($BOTx[y],$BOTy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0) //plot the zone drawrectangle(min($BOTx[y],$topx[i]),$BOTy[y],barindex,$topy[i]) coloured(r,g,50,50) bordercolor(r,g,0) endif next else $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 if close>min($BOTy[y],$topy[i]) then //define the color r=0 g=255 else r=255 g=0 endif //plot points at each tops DRAWPOINT($topx[i],$topy[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($BOTx[y],$BOTy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0) //plot the zone drawrectangle(min($BOTx[y],$topx[i]),$BOTy[y],barindex,$topy[i]) coloured(r,g,50,50) bordercolor(r,g,0) endif endif next next endif test=lastset($overlap) space=30 drawtext(" #test#",barindex,high+space,SansSerif,standard,10) //test=count //space=10 //drawtext(" #test#",barindex,high+space,SansSerif,standard,10) //if isset($overlap[0]) then // //for x=0 to lastset($overlap) do //test=round($overlap[x]) //space=x*10 //drawtext(" #test#",barindex,high+space,SansSerif,standard,10) //next //endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88

  defparam calculateonlastbars=200 barlimit = 200 percent=0.15 if low[1]>low[4] and low[2]>low[4] and low[3]>low[4] and low[4]<low[5] and low[4]<low[6] and low[4]<low[7] then $BOTy[lastset($BOTy)+1] = close[4] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[4] //stire fractal barindex endif     if high[1]<high[4] and high[2]<high[4] and high[3]<high[4] and high[4]>high[5] and high[4]>high[6] and high[4]>high[7] then $TOPy[lastset($TOPy)+1] = close[4] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[4] //store fractal barindex endif   if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then //check points in a range of X percent for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do change=abs(($BOTy[y]-$topy[i])/$topy[i]) / if change<=percent/100 and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then if isset($overlap[0]) then count=0 for x=0 to lastset($overlap) do if abs(($BOTy[y]+$TOPy[i])/2 - $overlap[x])<percent*2 then count=count+1 endif   if count=0 then $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 if close>min($BOTy[y],$topy[i]) then //define the color r=0 g=255 else r=255 g=0 endif //plot points at each tops DRAWPOINT($topx[i],$topy[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($BOTx[y],$BOTy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0)   //plot the zone drawrectangle(min($BOTx[y],$topx[i]),$BOTy[y],barindex,$topy[i]) coloured(r,g,50,50) bordercolor(r,g,0) endif next else $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 if close>min($BOTy[y],$topy[i]) then //define the color r=0 g=255 else r=255 g=0 endif //plot points at each tops DRAWPOINT($topx[i],$topy[i],2) COLOURED (r,g,0) BORDERCOLOR (r,g,0) DRAWPOINT($BOTx[y],$BOTy[y],2) COLOURED (g,r,0) BORDERCOLOR (g,r,0)   //plot the zone drawrectangle(min($BOTx[y],$topx[i]),$BOTy[y],barindex,$topy[i]) coloured(r,g,50,50) bordercolor(r,g,0)   endif endif next next       endif   test=lastset($overlap) space=30 drawtext(" #test#",barindex,high+space,SansSerif,standard,10)     //test=count //space=10 //drawtext(" #test#",barindex,high+space,SansSerif,standard,10)   //if isset($overlap[0]) then // //for x=0 to lastset($overlap) do //test=round($overlap[x]) //space=x*10 //drawtext(" #test#",barindex,high+space,SansSerif,standard,10) //next //endif   return

   

   

  

  stefou102

  Participant

  Topics: 22

  Replies: 171

  Been thanked: 71 times
  04/09/2020 at 10:28 AM #125389
  Nicolas

  The problem is that you continuously increase the index of the $overlap array in the for x/next loop, while this loop is based on the quantity of index of this specific array, so it results as an infinite loop.

  You should build an array of possible support resistance zones in the first place. Then create a specific loop through this price zones array and exclude the overlapping ones in order to plot them.

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4741 times
  04/10/2020 at 11:46 AM #125562
  stefou102

  Ok thx very much for your feedback. Actually, I had your solution in mind as backup but the downside is/was that you are losing some info in the process, as I’m storing only the midpoint levels.

  Anyway please find here under a first draft of indicator drawing automatically what I call overlap levels (so levels that have been both support and resistance)…

   

  DEFPARAM DRAWONLASTBARONLY =TRUE defparam calculateonlastbars=200 barlimit = 200 //percent=0.1 if low[1]>low[4] and low[2]>low[4] and low[3]>low[4] and low[4]<low[5] and low[4]<low[6] and low[4]<low[7] then $BOTy[lastset($BOTy)+1] = low[4] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[4] //stire fractal barindex endif if high[1]<high[4] and high[2]<high[4] and high[3]<high[4] and high[4]>high[5] and high[4]>high[6] and high[4]>high[7] then $TOPy[lastset($TOPy)+1] = high[4] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[4] //store fractal barindex endif if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then //check points in a range of X percent for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do //check first top with other tops change=abs(($BOTy[y]-$topy[i])/$topy[i]) //percent range between the 2 tops if change<=percent/100 and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 endif next next endif if islastbarupdate and isset($overlap[0]) then for x=0 to lastset($overlap) do for z = 0 to lastset($overlap) do if z=0 then count=0 endif if x<>z then if abs($overlap[x]-$overlap[z])/$overlap[z]<percent/100*2 then count=count+1 endif endif next if count=0 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] else for z = 0 to lastset($overlap) do if abs($overlap[x]-$overlapfinal[z])/$overlapfinal[z]>percent/100*2 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] endif next endif next endif if islastbarupdate and isset($overlapfinal[0]) then for x=0 to lastset($overlapfinal) do drawline(barindex-100,$overlapfinal[x],barindex,$overlapfinal[x]) coloured(100,100,50) next endif //plot the zone //test=lastset($overlap) //test=$overlapfinal[4] //drawtext(" #test#",barindex,high+20,SansSerif,standard,10) return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77

  DEFPARAM DRAWONLASTBARONLY =TRUE defparam calculateonlastbars=200 barlimit = 200 //percent=0.1 if low[1]>low[4] and low[2]>low[4] and low[3]>low[4] and low[4]<low[5] and low[4]<low[6] and low[4]<low[7] then $BOTy[lastset($BOTy)+1] = low[4] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[4] //stire fractal barindex endif     if high[1]<high[4] and high[2]<high[4] and high[3]<high[4] and high[4]>high[5] and high[4]>high[6] and high[4]>high[7] then $TOPy[lastset($TOPy)+1] = high[4] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[4] //store fractal barindex endif   if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then //check points in a range of X percent for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do //check first top with other tops change=abs(($BOTy[y]-$topy[i])/$topy[i]) //percent range between the 2 tops if change<=percent/100 and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then   $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 endif next   next     endif     if islastbarupdate and isset($overlap[0]) then   for x=0 to lastset($overlap) do for z = 0 to lastset($overlap) do if z=0 then count=0 endif if x<>z then if abs($overlap[x]-$overlap[z])/$overlap[z]<percent/100*2 then count=count+1 endif endif next if count=0 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] else for z = 0 to lastset($overlap) do if abs($overlap[x]-$overlapfinal[z])/$overlapfinal[z]>percent/100*2 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] endif next   endif next   endif   if islastbarupdate and isset($overlapfinal[0]) then for x=0 to lastset($overlapfinal) do drawline(barindex-100,$overlapfinal[x],barindex,$overlapfinal[x]) coloured(100,100,50) next endif     //plot the zone     //test=lastset($overlap) //test=$overlapfinal[4] //drawtext(" #test#",barindex,high+20,SansSerif,standard,10)         return

   

  

  stefou102

  Participant

  Topics: 22

  Replies: 171

  Been thanked: 71 times
  04/10/2020 at 11:55 AM #125564
  stefou102

  being able to create such indicator is a huge step forward for PRT! if other participants can take this base to a higher level, this could be a cornerstone to create a profitable robot

  1 user thanked author for this post.

  Oliviertrader2020

  

  stefou102

  Participant

  Topics: 22

  Replies: 171

  Been thanked: 71 times
  04/10/2020 at 12:05 PM #125566
  stefou102

  Small improvement, drawing segment instead of line

  DEFPARAM DRAWONLASTBARONLY =TRUE defparam calculateonlastbars=200 barlimit = 200 //percent=0.1 if low[1]>=low[4] and low[2]>=low[4] and low[3]>=low[4] and low[4]<=low[5] and low[4]<=low[6] and low[4]<=low[7] then $BOTy[lastset($BOTy)+1] = low[4] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[4] //stire fractal barindex endif if high[1]<=high[4] and high[2]<=high[4] and high[3]<=high[4] and high[4]>=high[5] and high[4]>=high[6] and high[4]>=high[7] then $TOPy[lastset($TOPy)+1] = high[4] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[4] //store fractal barindex endif if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then //check points in a range of X percent for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do //check first top with other tops change=abs(($BOTy[y]-$topy[i])/$topy[i]) //percent range between the 2 tops if change<=percent/100 and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 $overlapx[lastset($overlapx)+1]=min($BOTx[y],$TOPx[i]) endif next next endif if islastbarupdate and isset($overlap[0]) then for x=0 to lastset($overlap) do for z = 0 to lastset($overlap) do if z=0 then count=0 endif if x<>z then if abs($overlap[x]-$overlap[z])/$overlap[z]<percent/100*2 then count=count+1 endif endif next if count=0 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx[lastset($overlapfinalx)+1]=$overlapx[x] else for z = 0 to lastset($overlap) do if abs($overlap[x]-$overlapfinal[z])/$overlapfinal[z]>percent/100*2 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx[lastset($overlapfinalx)+1]=$overlapx[x] endif next endif next endif if islastbarupdate and isset($overlapfinal[0]) then for x=0 to lastset($overlapfinal) do drawsegment($overlapfinalx[x],$overlapfinal[x],barindex,$overlapfinal[x]) coloured(100,100,0) next endif //plot the zone //test=lastset($overlap) //test=$overlapfinal[4] //drawtext(" #test#",barindex,high+20,SansSerif,standard,10) return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80

  DEFPARAM DRAWONLASTBARONLY =TRUE defparam calculateonlastbars=200 barlimit = 200 //percent=0.1 if low[1]>=low[4] and low[2]>=low[4] and low[3]>=low[4] and low[4]<=low[5] and low[4]<=low[6] and low[4]<=low[7] then $BOTy[lastset($BOTy)+1] = low[4] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[4] //stire fractal barindex endif     if high[1]<=high[4] and high[2]<=high[4] and high[3]<=high[4] and high[4]>=high[5] and high[4]>=high[6] and high[4]>=high[7] then $TOPy[lastset($TOPy)+1] = high[4] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[4] //store fractal barindex endif   if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then //check points in a range of X percent for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do //check first top with other tops change=abs(($BOTy[y]-$topy[i])/$topy[i]) //percent range between the 2 tops if change<=percent/100 and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then   $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 $overlapx[lastset($overlapx)+1]=min($BOTx[y],$TOPx[i]) endif next   next     endif     if islastbarupdate and isset($overlap[0]) then   for x=0 to lastset($overlap) do for z = 0 to lastset($overlap) do if z=0 then count=0 endif if x<>z then if abs($overlap[x]-$overlap[z])/$overlap[z]<percent/100*2 then count=count+1 endif endif next if count=0 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx[lastset($overlapfinalx)+1]=$overlapx[x] else for z = 0 to lastset($overlap) do if abs($overlap[x]-$overlapfinal[z])/$overlapfinal[z]>percent/100*2 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx[lastset($overlapfinalx)+1]=$overlapx[x] endif next   endif next   endif   if islastbarupdate and isset($overlapfinal[0]) then for x=0 to lastset($overlapfinal) do drawsegment($overlapfinalx[x],$overlapfinal[x],barindex,$overlapfinal[x]) coloured(100,100,0) next endif     //plot the zone     //test=lastset($overlap) //test=$overlapfinal[4] //drawtext(" #test#",barindex,high+20,SansSerif,standard,10)         return

   

   

   

  

  stefou102

  Participant

  Topics: 22

  Replies: 171

  Been thanked: 71 times
  04/10/2020 at 12:11 PM #125568
  Nicolas

  Thank you for this very nice fork of the original indicator. A great addition would be to start plotting the lines (as segments) from the bar when the level is found for the first time, sounds tricky but possible.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4741 times
  04/10/2020 at 12:38 PM #125572
  stefou102

  this is what the second version I posted is doing, nope?

  

  stefou102

  Participant

  Topics: 22

  Replies: 171

  Been thanked: 71 times
  04/10/2020 at 1:08 PM #125576
  Nicolas

  Yes! You replied before me, thanks 🙂

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4741 times
  04/11/2020 at 4:33 PM #125711
  stefou102

  I  still found and resolved major bugs in my code, but unless there are other participants willing to build on this, don’t see the point to continue this thread

  1 user thanked author for this post.

  alessiopippo

  

  stefou102

  Participant

  Topics: 22

  Replies: 171

  Been thanked: 71 times
  04/12/2020 at 7:10 PM #125822
  Nicolas

  I strongly encourage to continue posting your valuable input.  Once a while someone will pop into the discussion.  It usually happens like this in the forums. Sadly, I can’t get involved into each interesting topic created by members,  due to lack of time,  going from problem to another.. anyway, I’m subscribing to the thread! thanks again for giving back to the community! 🙂

  1 user thanked author for this post.

  alessiopippo

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4741 times
  04/13/2020 at 11:42 AM #125901
  stefou102

  Yep you right but always difficult when you have the impression that’s more a one way virtual relationship…

  So anyway, I’m posting the last version I have, which worked great yesterday on the WE static data, but now that prices move again, I get the famous error message “infinite loop or too much iteration”

  the error is here when I use two loops to compare one value of an array with all other values of the same array, but I can not see why I would have an infinite loop…

   

  for x=lastset($overlap) downto 1 do for z=lastset($overlap) downto 1 do if x=lastset($overlap) then count=0 endif if x<>z then if abs($overlap[x]-$overlap[z])<ATR then count=count+1 endif endif next ...... next

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

  for x=lastset($overlap) downto 1  do for z=lastset($overlap) downto 1 do if x=lastset($overlap) then count=0 endif if x<>z then if abs($overlap[x]-$overlap[z])<ATR then count=count+1 endif endif next   ......   next

   

   

   

  DEFPARAM DRAWONLASTBARONLY =TRUE defparam calculateonlastbars=500 barlimit = 500 ATR=averagetruerange[20](close) //percent=0.1 cp=2 ATRfactor=2 if high[cp] >= highest[(cp)*2+1](high) and barindex-$TOPx2[max(0,lastset($TOPx2))]>1 then //new fractal high found $TOPy[lastset($TOPy)+1] = high[cp] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[cp] //store fractal barindex //drawpoint(barindex[cp],high[cp],1) coloured(100,75,150) bordercolor (100,75,150) $TOPx2[lastset($TOPx2)+1] = barindex endif if low[cp] <= lowest[(cp)*2+1](low) and barindex-$BOTx2[max(0,lastset($BOTx2))]>1 then //new fractal low found $BOTy[lastset($BOTy)+1] = low[cp] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[cp] //stire fractal barindex //drawpoint(barindex[cp],low[cp],1) coloured(100,75,150) bordercolor (100,75,150) $BOTx2[lastset($BOTx2)+1] = barindex endif if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then //check points in a range of X percent for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do //check first top with other tops if y<>i then change=abs($BOTy[y]-$topy[i])//percent range between the 2 tops if change<=ATR/ATRfactor and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 $overlapx1[lastset($overlapx1)+1]=min($BOTx[y],$TOPx[i]) $overlapx2[lastset($overlapx2)+1]=max($BOTx[y],$TOPx[i]) endif endif next next endif if islastbarupdate and isset($overlap[0]) then for x=lastset($overlap) downto 1 do for z=lastset($overlap) downto 1 do if x=lastset($overlap) then count=0 endif if x<>z then if abs($overlap[x]-$overlap[z])<ATR then count=count+1 endif endif next //test=count //drawtext(" #test#",barindex,high+10*count,SansSerif,standard,10) if count=0 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx1[lastset($overlapfinalx1)+1]=$overlapx1[x] $overlapfinalx2[lastset($overlapfinalx2)+1]=$overlapx2[x] else if lastset($overlapfinal)=-1 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx1[lastset($overlapfinalx1)+1]=$overlapx1[x] $overlapfinalx2[lastset($overlapfinalx2)+1]=$overlapx2[x] endif for zz = 0 to lastset($overlapfinal) do if zz=0 then count=0 endif if x<>zz then if abs($overlap[x]-$overlapfinal[zz])<ATR then count=count+1 endif endif next if count=0 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx1[lastset($overlapfinalx1)+1]=$overlapx1[x] $overlapfinalx2[lastset($overlapfinalx2)+1]=$overlapx2[x] endif endif next endif if islastbarupdate and isset($overlapfinal[0]) then for x=0 to lastset($overlapfinal) do if $overlapfinal[x] > close then if highest[barindex-$overlapfinalx2[x]-1](high)<$overlapfinal[x]+ATR/ATRfactor then drawsegment($overlapfinalx1[x],$overlapfinal[x],barindex,$overlapfinal[x]) coloured(0,75,150) STYLE (dottedline,3) drawpoint($overlapfinalx2[x],$overlapfinal[x],2) coloured(0,75,150) bordercolor (0,75,150) endif else if lowest[barindex-$overlapfinalx2[x]-1](low)>$overlapfinal[x]-ATR/ATRfactor then drawsegment($overlapfinalx1[x],$overlapfinal[x],barindex,$overlapfinal[x]) coloured(0,75,150) STYLE (dottedline,3) drawpoint($overlapfinalx2[x],$overlapfinal[x],2) coloured(0,75,150) bordercolor (0,75,150) endif endif //drawsegment($overlapfinalx1[x],$overlapfinal[x],barindex,$overlapfinal[x]) coloured(0,75,150) STYLE (dottedline,3) //drawpoint($overlapfinalx2[x],$overlapfinal[x],2) coloured(0,75,150) bordercolor (0,75,150) next endif //plot the zone return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121

  DEFPARAM DRAWONLASTBARONLY =TRUE defparam calculateonlastbars=500 barlimit = 500 ATR=averagetruerange[20](close) //percent=0.1     cp=2 ATRfactor=2 if high[cp] >= highest[(cp)*2+1](high) and barindex-$TOPx2[max(0,lastset($TOPx2))]>1 then //new fractal high found $TOPy[lastset($TOPy)+1] = high[cp] //store fractal value $TOPx[lastset($TOPx)+1] = barindex[cp] //store fractal barindex //drawpoint(barindex[cp],high[cp],1) coloured(100,75,150) bordercolor (100,75,150) $TOPx2[lastset($TOPx2)+1] = barindex endif if low[cp] <= lowest[(cp)*2+1](low) and barindex-$BOTx2[max(0,lastset($BOTx2))]>1 then //new fractal low found $BOTy[lastset($BOTy)+1] = low[cp] //store fractal value $BOTx[lastset($BOTx)+1] = barindex[cp] //stire fractal barindex //drawpoint(barindex[cp],low[cp],1) coloured(100,75,150) bordercolor (100,75,150) $BOTx2[lastset($BOTx2)+1] = barindex endif   if(islastbarupdate and isset($topy[0]) and isset($boty[0])) then //check points in a range of X percent for i = 0 to lastset($TOPy) do //loop through the tops for y = 0 to lastset($BOTy) do //check first top with other tops if y<>i then change=abs($BOTy[y]-$topy[i])//percent range between the 2 tops if change<=ATR/ATRfactor and barindex-$BOTx[y]<barlimit and $topx[i]<>$BOTx[y] then   $overlap[lastset($overlap)+1]=($BOTy[y]+$TOPy[i])/2 $overlapx1[lastset($overlapx1)+1]=min($BOTx[y],$TOPx[i]) $overlapx2[lastset($overlapx2)+1]=max($BOTx[y],$TOPx[i]) endif endif next   next     endif     if islastbarupdate and isset($overlap[0]) then   for x=lastset($overlap) downto 1  do for z=lastset($overlap) downto 1 do if x=lastset($overlap) then count=0 endif if x<>z then if abs($overlap[x]-$overlap[z])<ATR then count=count+1 endif endif next //test=count   //drawtext(" #test#",barindex,high+10*count,SansSerif,standard,10) if count=0 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx1[lastset($overlapfinalx1)+1]=$overlapx1[x] $overlapfinalx2[lastset($overlapfinalx2)+1]=$overlapx2[x] else if lastset($overlapfinal)=-1 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx1[lastset($overlapfinalx1)+1]=$overlapx1[x] $overlapfinalx2[lastset($overlapfinalx2)+1]=$overlapx2[x] endif for zz = 0 to lastset($overlapfinal) do if zz=0 then count=0 endif if x<>zz then if abs($overlap[x]-$overlapfinal[zz])<ATR then count=count+1 endif endif next if count=0 then $overlapfinal[lastset($overlapfinal)+1]=$overlap[x] $overlapfinalx1[lastset($overlapfinalx1)+1]=$overlapx1[x] $overlapfinalx2[lastset($overlapfinalx2)+1]=$overlapx2[x] endif     endif next   endif     if islastbarupdate and isset($overlapfinal[0]) then for x=0 to lastset($overlapfinal) do if $overlapfinal[x] > close then if highest[barindex-$overlapfinalx2[x]-1](high)<$overlapfinal[x]+ATR/ATRfactor then drawsegment($overlapfinalx1[x],$overlapfinal[x],barindex,$overlapfinal[x]) coloured(0,75,150) STYLE (dottedline,3) drawpoint($overlapfinalx2[x],$overlapfinal[x],2) coloured(0,75,150) bordercolor (0,75,150) endif else if lowest[barindex-$overlapfinalx2[x]-1](low)>$overlapfinal[x]-ATR/ATRfactor then drawsegment($overlapfinalx1[x],$overlapfinal[x],barindex,$overlapfinal[x]) coloured(0,75,150) STYLE (dottedline,3) drawpoint($overlapfinalx2[x],$overlapfinal[x],2) coloured(0,75,150) bordercolor (0,75,150) endif endif //drawsegment($overlapfinalx1[x],$overlapfinal[x],barindex,$overlapfinal[x]) coloured(0,75,150) STYLE (dottedline,3) //drawpoint($overlapfinalx2[x],$overlapfinal[x],2) coloured(0,75,150) bordercolor (0,75,150) next endif     //plot the zone               return

   

  

  stefou102

  Participant

  Topics: 22

  Replies: 171

  Been thanked: 71 times
  04/13/2020 at 12:18 PM #125913
  Nicolas

  I have not tested yet, but 2 ways to improve the loop:

  1/ is it needed to start the nested loop at the beginning of the array?

  for x=lastset($overlap) downto 1 do for z=x downto 1 do

  1 2	for x=lastset($overlap) downto 1  do for z=x downto 1 do

  2/ while increasing the index with lastset($overlapfinal)+1, is a good idea, it sometimes overload the array without reason. 

  try instead to create a variable that store the index number and re-use it at each run of the code:

  at start of the code and before creating the array:

  myindex = 0

  1	myindex = 0

  then, while populating the array:

  myindex = myindex+1 //increase the array size $overlap[myindex] //use the index to store value

  1 2 3

  myindex = myindex+1 //increase the array size   $overlap[myindex] //use the index to store value

  by doing this, it will considerably reduce the array size and therefore limiting the infinite loop issue!

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4741 times
• Author
  Posts