Adjustment in code because combined stops can not be used with pro order

• 09/11/2019 at 8:00 AM #107151
  robertogozzi

  Move line 39 to line 32.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16480

  Been thanked: 3645 times
  09/13/2019 at 8:11 AM #107408
  Lombard974

  Hi

  I want to know if it is possible to keep orders open until one is filled then after candle close it must close other pending order. Reason why i ask is. the system now places 2 pending orders. But if they are not triggered in the first 5 min the system closes both of them.  And like today it took more then 5 minutes for price to pass the point where pending order was.  I hope its clear. Just keep orders open until 1 is filled and then close other order.

   

  Thank you for all your help

  

  Lombard974

  Participant

  Topics: 5

  Replies: 25

  Been thanked: 0 times
  09/13/2019 at 8:55 AM #107416
  robertogozzi

  Pending orders only last one bar and need to be placed again and again, if needed.

  As you have written your conditions at present the two orders will be placed continuously if not OnMarket since STARTTIME is always true, being 090000.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16480

  Been thanked: 3645 times
  09/13/2019 at 10:45 AM #107426
  Vonasi

  This version allows 1 trade per day and keeps the orders on the market until one (or both) are filled.

  I added a variable v as I couldn’t find any 20 pip breakouts on the Russell 2000 index.

  DEFPARAM CumulateOrders = false DEFPARAM FLATBefore = 084500 DEFPARAM FLATAfter = 210000 DEFPARAM PreLoadBars = 2000 v = 20 nLots = 5 ONCE MaxPrice = 999999 ONCE MinPrice = 0 starttime = 090000 IF time = starttime THEN MaxPrice = highest[6](high) MinPrice = lowest[6](low) flag = 0 ENDIF if onmarket then flag = 1 endif if not onmarket and time >= starttime and flag = 0 then buy Nlots contract at MaxPrice + v * pointsize STOP set stop loss close- Minprice + v * pointsize endif if not onmarket and time >= starttime and flag = 0 then sellshort Nlots contract at MinPrice - v * pointsize STOP set stop loss MaxPrice - close - v * pointsize endif SET TARGET PROFIT 120

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32

  DEFPARAM CumulateOrders = false DEFPARAM FLATBefore     = 084500 DEFPARAM FLATAfter      = 210000 DEFPARAM PreLoadBars    = 2000 v = 20 nLots = 5 ONCE MaxPrice = 999999 ONCE MinPrice = 0 starttime = 090000 IF time = starttime THEN MaxPrice = highest[6](high) MinPrice = lowest[6](low) flag = 0 ENDIF if onmarket then flag = 1 endif   if not onmarket and time >= starttime and flag = 0 then buy Nlots contract at MaxPrice + v * pointsize STOP set stop loss close- Minprice + v * pointsize endif   if not onmarket and time >= starttime and flag = 0 then sellshort Nlots contract at MinPrice - v * pointsize STOP set stop loss MaxPrice - close - v * pointsize endif   SET TARGET PROFIT 120

  Moderators Note: Code edited to remove incorrect lines 30 and 31.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  09/13/2019 at 10:48 AM #107427
  Lombard974

  Thank you

  The thing is after 5 min both sell and buy orders were gone. today at 9:05 pending order were deleted. I dont know why an how to change the code so it places trades until one is triggered.

   

  

  Lombard974

  Participant

  Topics: 5

  Replies: 25

  Been thanked: 0 times
  09/13/2019 at 12:07 PM #107441
  Vonasi

  Delete lines 30 and 31 in my last code as they accidentally got left in from your incorrect code that you posted before. They will stop the orders from being placed again.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  09/13/2019 at 12:10 PM #107442
  Vonasi

  Here is an MTF version that can be used on the 1 second time frame to ensure that orders in the opposite direction are cancelled a soon as an order is filled.

  DEFPARAM CumulateOrders = false DEFPARAM FLATBefore = 084500 DEFPARAM FLATAfter = 210000 DEFPARAM PreLoadBars = 2000 v = 20 nLots = 5 starttime = 090000 timeframe(15 minutes, updateonclose) ONCE MaxPrice = 999999 ONCE MinPrice = 0 IF time = starttime THEN MaxPrice = highest[6](high) MinPrice = lowest[6](low) ENDIF timeframe(1 second) IF time = starttime THEN flag = 0 ENDIF if onmarket then flag = 1 endif if not onmarket and time >= starttime and flag = 0 then buy Nlots contract at MaxPrice + v * pointsize STOP set stop loss close- Minprice + v * pointsize endif if not onmarket and time >= starttime and flag = 0 then sellshort Nlots contract at MinPrice - v * pointsize STOP set stop loss MaxPrice - close - v * pointsize endif SET TARGET PROFIT 120

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38

  DEFPARAM CumulateOrders = false DEFPARAM FLATBefore     = 084500 DEFPARAM FLATAfter      = 210000 DEFPARAM PreLoadBars    = 2000 v = 20 nLots = 5 starttime = 090000   timeframe(15 minutes, updateonclose) ONCE MaxPrice = 999999 ONCE MinPrice = 0   IF time = starttime THEN MaxPrice = highest[6](high) MinPrice = lowest[6](low) ENDIF timeframe(1 second) IF time = starttime THEN flag = 0 ENDIF   if onmarket then flag = 1 endif   if not onmarket and time >= starttime and flag = 0 then buy Nlots contract at MaxPrice + v * pointsize STOP set stop loss close- Minprice + v * pointsize endif   if not onmarket and time >= starttime and flag = 0 then sellshort Nlots contract at MinPrice - v * pointsize STOP set stop loss MaxPrice - close - v * pointsize endif   SET TARGET PROFIT 120

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  09/13/2019 at 1:48 PM #107457
  Lombard974

  Hi

  Thank you again for the help.. I have tried you new code from the post this morning..  It works great but if i remove line 30-31 it just keeps on placing orders during the day. What I want is for the system just to place pending orders until 1 is filled and when bar close it closes other pending order.

  So it must only do the 1 trade per day but must keep orders at that level until it is activated. If for some reason both is activated one will close and we go in the other direction so that is ok. I just need it to keep order open until its triggered. But for example if buy trade is activated on the close of the bar where it is activated it must close the sell pending order.  So keep orders open until 1 is activated. Thats it.

  Thanks again

  

  Lombard974

  Participant

  Topics: 5

  Replies: 25

  Been thanked: 0 times
  09/13/2019 at 2:49 PM #107477
  Vonasi

  You must be doing something wrong then because it works just fine when I test it. In the image which is on the 1 minute chart the flag switch is graphed and when it is 1 it is impossible for another trade to be opened. It works exactly as it should.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  09/13/2019 at 3:56 PM #107489
  Lombard974

  No not the MTF code

  this code

  DEFPARAM CumulateOrders = false DEFPARAM FLATBefore = 084500 DEFPARAM FLATAfter = 210000 DEFPARAM PreLoadBars = 2000 v = 20 nLots = 5 ONCE MaxPrice = 999999 ONCE MinPrice = 0 starttime = 090000 IF time = starttime THEN MaxPrice = highest[6](high) MinPrice = lowest[6](low) flag = 0 ENDIF if onmarket then flag = 1 endif if not onmarket and time >= starttime and flag = 0 then buy Nlots contract at MaxPrice + v * pointsize STOP set stop loss close- Minprice + v * pointsize endif if not onmarket and time >= starttime and flag = 0 then sellshort Nlots contract at MinPrice - v * pointsize STOP set stop loss MaxPrice - close - v * pointsize endif SET TARGET PROFIT 120

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32

  DEFPARAM CumulateOrders = false DEFPARAM FLATBefore     = 084500 DEFPARAM FLATAfter      = 210000 DEFPARAM PreLoadBars    = 2000 v = 20 nLots = 5 ONCE MaxPrice = 999999 ONCE MinPrice = 0 starttime = 090000 IF time = starttime THEN MaxPrice = highest[6](high) MinPrice = lowest[6](low) flag = 0 ENDIF if onmarket then flag = 1 endif if not onmarket and time >= starttime and flag = 0 then buy Nlots contract at MaxPrice + v * pointsize STOP set stop loss close- Minprice + v * pointsize endif if not onmarket and time >= starttime and flag = 0 then sellshort Nlots contract at MinPrice - v * pointsize STOP set stop loss MaxPrice - close - v * pointsize endif SET TARGET PROFIT 120

   

  

  Lombard974

  Participant

  Topics: 5

  Replies: 25

  Been thanked: 0 times
  09/13/2019 at 4:21 PM #107493
  Vonasi

  Yes that code is the one and it works just fine for me.

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  09/13/2019 at 6:40 PM #107501
  GraHal

  Lombard974 wrote:

  but if i remove line 30-31 it just keeps on placing orders during the day.

  Did you see the note from Vonasi below as maybe you have removed Line 30-31 when Vonasi had already removed Line 30-31.

  Just a thought / trying to help … don’t shoot the messenger! 🙂

   

  Vonasi wrote:

  Moderators Note: Code edited to remove incorrect lines 30 and 31.

   

  

  GraHal

  Participant

  Topics: 204

  Replies: 8429

  Been thanked: 2047 times
  09/13/2019 at 8:12 PM #107507
  Vonasi

  GraHal wrote:

  Just a thought / trying to help … don’t shoot the messenger!

  I edited it after my last post – I did worry that it might lead to confusion – hence the moderators note!

  Why don’t you also test the code GraHal then if it works OK for you too then we know that it is definitely something Lombard974 is doing wrong?

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  09/17/2019 at 6:59 AM #107802
  Lombard974

  Hello Guys

  Yes  i understand what you means and i saw the note.. If i removed the lines it just kept on placing trades during the day. I dont know how to limit it to just 1 trade. But keep orders open until 1 is filled.

  This code below works great on testing with tick by tick and spread. But still orders are canceled after close of first 5 min candle and maybe trade comes a little later. So i want to keep orders open until 1 is filled. The biggest problem with this code is some days it doesnt trade at all? I dont know why? But what I think is system can place trades because its too close to price.. How can this be adjusted to place trade at the nearest available price?

  Thanks

  //------------------------------------------------------------------------- // Main code : UltimateSAF //------------------------------------------------------------------------- //------------------------------------------------------------------------- // Main code : MySystem(8) //------------------------------------------------------------------------- DEFPARAM CumulateOrders = false DEFPARAM FLATBefore = 084500 //09:00 DEFPARAM FLATAfter = 210000 //21:00 DEFPARAM PreLoadBars = 2000 ONCE nLots = 5 ONCE MaxPrice = 999999 ONCE MinPrice = 0 starttime = 090000 SET TARGET PROFIT 120 IF time = starttime THEN MaxPrice = highest[6](high) //Il massimo/minimo delle ultime 12 barre MinPrice = lowest[6](low) // (ogni ora = 12 barre da 5 minuti) flag=0 ENDIF if onmarket then flag = 1 endif //************************************************************************ // LONG if not onmarket and time >= starttime and flag = 0 then buy Nlots contract at MaxPrice STOP set stop loss close- Minprice - 60 * pointsize if not onmarket and time >= starttime and flag = 0 then sellshort Nlots contract at MinPrice STOP set stop loss MaxPrice - close + 60 * pointsize MaxPrice = 999999 MinPrice = 0 endif endif

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44

  //------------------------------------------------------------------------- // Main code : UltimateSAF //------------------------------------------------------------------------- //------------------------------------------------------------------------- // Main code : MySystem(8) //------------------------------------------------------------------------- DEFPARAM CumulateOrders = false DEFPARAM FLATBefore     = 084500                         //09:00 DEFPARAM FLATAfter      = 210000                         //21:00 DEFPARAM PreLoadBars    = 2000 ONCE nLots              = 5 ONCE MaxPrice           = 999999 ONCE MinPrice           = 0 starttime = 090000     SET TARGET PROFIT 120     IF time = starttime THEN MaxPrice = highest[6](high)                          //Il massimo/minimo delle ultime 12 barre MinPrice = lowest[6](low)                            //   (ogni ora = 12 barre da 5 minuti) flag=0 ENDIF if onmarket then flag = 1 endif //************************************************************************ //                           LONG   if not onmarket and time >= starttime and flag = 0 then buy Nlots contract at MaxPrice  STOP set stop loss close- Minprice - 60 * pointsize   if not onmarket and time >= starttime and flag = 0 then sellshort Nlots contract at MinPrice  STOP set stop loss MaxPrice - close + 60 * pointsize MaxPrice = 999999 MinPrice = 0 endif endif

   

  

  Lombard974

  Participant

  Topics: 5

  Replies: 25

  Been thanked: 0 times
  09/17/2019 at 9:02 AM #107819
  Vonasi

  So now we can see the problem. You have modified the code and you are not testing exactly the same code that I am!!!

  You have changed your pending order levels and yes if they are calculated too close to price then the orders will be rejected. The only way to overcome this is to never send orders too close to price!

  You can set a minimum distance using a MAX and a MIN in the order price calculation.

  Obviously you are no longer buying at your desired 6 candle highest high and lowest low prices though.

  MaxPrice = max(close + 60, highest[6](high)) MinPrice = min(close - 60, lowest[6](low))

  1 2	MaxPrice = max(close + 60, highest[6](high))                       MinPrice = min(close - 60, lowest[6](low))

   

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
• Author
  Posts