number of bars passed since last zigzag

• 02/05/2024 at 9:09 PM #227445
  Swisspatrick

  hi! using the standard built-in zigzag function, how can I find out:

  1. the number of bars that have passed since the last zigzag (peak or bottom) occurred and now?
  2. the closing price of that last zigzag (peak or bottom)?

  

  Swisspatrick

  Participant

  Topics: 5

  Replies: 3

  Been thanked: 0 times
  02/06/2024 at 11:38 AM #227459
  Nicolas

  Hi there 😊!

  To retrieve information using the built-in ZigZag function in ProRealTime for:

  1. The number of bars that have passed since the last ZigZag (peak) occurred
  2. The closing price of that last ZigZag (peak): Once you find the bar where the ZigZag indicator shows a peak, you can record the closing price of that bar.

  Here’s a simplified example of how you might write this in ProRealTime’s coding language:

  // ZigZag parameter setup ZigZagDepth = 5 // This sets the depth parameter for the ZigZag indicator. The depth affects sensitivity. // Applying the ZigZag function zz = ZigZag[ZigZagDepth](close) // This line calculates the ZigZag indicator values based on the close prices of bars. // Find Peak peak = zz<zz[1] and zz[1]>zz[2] // A peak is identified when the current ZigZag value is less than the previous one, and the previous value is greater than the one before it. This indicates a high point in the ZigZag line. // Store values when found if peak then PeakBar = barindex // If a peak is found, store the current bar index as the PeakBar. LastZigZagClosePrice = close // Also, store the close price of the current bar as the last ZigZag peak's close price. endif BarsSinceLastZigZag = barindex - PeakBar // Calculate the number of bars since the last ZigZag peak by subtracting the PeakBar index from the current bar index. // Output RETURN BarsSinceLastZigZag AS "Bars Since Last ZigZag", LastZigZagClosePrice AS "Last ZigZag Close Price"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

  // ZigZag parameter setup ZigZagDepth = 5 // This sets the depth parameter for the ZigZag indicator. The depth affects sensitivity.   // Applying the ZigZag function zz = ZigZag[ZigZagDepth](close) // This line calculates the ZigZag indicator values based on the close prices of bars.   // Find Peak peak = zz<zz[1] and zz[1]>zz[2] // A peak is identified when the current ZigZag value is less than the previous one, and the previous value is greater than the one before it. This indicates a high point in the ZigZag line.   // Store values when found if peak then     PeakBar = barindex // If a peak is found, store the current bar index as the PeakBar.     LastZigZagClosePrice = close // Also, store the close price of the current bar as the last ZigZag peak's close price. endif   BarsSinceLastZigZag = barindex - PeakBar // Calculate the number of bars since the last ZigZag peak by subtracting the PeakBar index from the current bar index.   // Output RETURN BarsSinceLastZigZag AS "Bars Since Last ZigZag", LastZigZagClosePrice AS "Last ZigZag Close Price"

   

   

  2 users thanked author for this post.

  Carburo, Swisspatrick

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4742 times
  02/06/2024 at 7:03 PM #227485
  Swisspatrick

  thank you Nicolas, that worked 🙂

  

  Swisspatrick

  Participant

  Topics: 5

  Replies: 3

  Been thanked: 0 times
  02/06/2024 at 8:53 PM #227491
  Swisspatrick

  I enhanced the code for both peaks and bottoms which works fine (medium pane)

  zigzagbars

  ZigZagDepth = 0.08 zz = ZigZag[ZigZagDepth](close) peak = zz<zz[1] and zz[1]>zz[2] zbottom = zz > zz[1] and zz[1]<zz[2] if peak then PeakBar = barindex LastZigZagClosePrice = close endif if zbottom then BottomBar = barindex LastZigZagClosePrice = close endif BarsSinceLastZigZagPeak = barindex - PeakBar BarsSinceLastZigZagBottom = barindex - BottomBar BSZZ = min(BarsSinceLastZigZagPeak, BarsSinceLastZigZagBottom) return BSZZ coloured(0,0,255) style(line,1) as "bars since ZigZag"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20

  ZigZagDepth = 0.08 zz = ZigZag[ZigZagDepth](close) peak = zz<zz[1] and zz[1]>zz[2] zbottom = zz > zz[1] and zz[1]<zz[2]   if peak then PeakBar = barindex LastZigZagClosePrice = close endif   if zbottom then BottomBar = barindex LastZigZagClosePrice = close endif   BarsSinceLastZigZagPeak = barindex - PeakBar BarsSinceLastZigZagBottom = barindex - BottomBar BSZZ = min(BarsSinceLastZigZagPeak, BarsSinceLastZigZagBottom)   return BSZZ coloured(0,0,255) style(line,1) as "bars since ZigZag"

  Then I wanted to write a trading system and stumbled accross an error “your trading system uses obsolete instructions which are not supported by the backtesting engine (ZigZag)”

  Sadly read that zigzag is not supported for trading systems 🙁 So manually coded it which works fine too:

  manual zigzag

  // manual calculation for the zigzag indicator DEFPARAM DRAWONLASTBARONLY=TRUE //Variables: Points=20 //Pips Perc=0.08 //% Type=1 //0=pips; 1=perc VarY=CustomClose //close,typicalprice, etc //initilaize first point as a "TOP" once LastPoint = 1 once TX0 = barindex once TY0 = VarY //Type ZZ in Points o Perc If Type=0 then //ZZ in pips DeltaY=Points*pipsize elsif Type=1 then //ZZ in % DeltaY=Perc/100*Dclose(1)////Dclose used as ref. endif //ZZ in fase 1 if LastPoint=1 then //lastpoint was a top if VarY>=TY0 then //update last top and stay in LastPoint=1 TY0=VarY TX0=barindex endif if VarY<=TY0-DeltaY then //first point in low LY0=VarY LX0=barindex LastPoint=-1 endif endif //ZZ in fase -1 if LastPoint=-1 then //lastpoint was a low if VarY<=LY0 then //update last low and stay in LastPoint=-1 LY0=VarY LX0=barindex endif if VarY>=LY0+DeltaY then //first point in top TY0=VarY TX0=barindex LastPoint=1 endif endif BarsSinceLastZigZagPeak = barindex - TX0 BarsSinceLastZigZagBottom = barindex - LX0 BSZZ = min(BarsSinceLastZigZagPeak, BarsSinceLastZigZagBottom) //---GRAPH--- If lastpoint=1 then drawsegment (barindex,close,TX0,TY0) style (dottedline,2) COLOURED (0,0,200) //segment in progress drawsegment (TX0,TY0,LX0,LY0) style (line,2) COLOURED (0,0,200) //segments definitive endif If lastpoint=-1 then drawsegment (barindex,close,LX0,LY0) style (dottedline,2) COLOURED (0,200,0) //segment in progress drawsegment (LX0,LY0,TX0,TY0) style (line,2) COLOURED (0,0,200) //segments definitive endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63

  // manual calculation for the zigzag indicator DEFPARAM DRAWONLASTBARONLY=TRUE //Variables: Points=20  //Pips Perc=0.08  //% Type=1     //0=pips; 1=perc VarY=CustomClose //close,typicalprice, etc //initilaize first point as a "TOP" once LastPoint = 1 once TX0    = barindex once TY0    = VarY //Type ZZ in Points o Perc If Type=0 then //ZZ in pips DeltaY=Points*pipsize elsif Type=1 then //ZZ in % DeltaY=Perc/100*Dclose(1)////Dclose used as ref. endif //ZZ in fase 1 if LastPoint=1 then //lastpoint was a top if VarY>=TY0 then //update last top and stay in LastPoint=1 TY0=VarY TX0=barindex endif if VarY<=TY0-DeltaY then //first point in low LY0=VarY LX0=barindex LastPoint=-1 endif endif //ZZ in fase -1 if LastPoint=-1 then //lastpoint was a low if VarY<=LY0 then //update last low and stay in LastPoint=-1 LY0=VarY LX0=barindex endif if VarY>=LY0+DeltaY then //first point in top TY0=VarY TX0=barindex LastPoint=1 endif endif   BarsSinceLastZigZagPeak = barindex - TX0 BarsSinceLastZigZagBottom = barindex - LX0 BSZZ = min(BarsSinceLastZigZagPeak, BarsSinceLastZigZagBottom) //---GRAPH--- If lastpoint=1 then drawsegment (barindex,close,TX0,TY0) style (dottedline,2) COLOURED (0,0,200) //segment in progress drawsegment (TX0,TY0,LX0,LY0) style (line,2) COLOURED (0,0,200) //segments definitive endif If lastpoint=-1 then drawsegment (barindex,close,LX0,LY0) style (dottedline,2) COLOURED (0,200,0) //segment in progress drawsegment (LX0,LY0,TX0,TY0) style (line,2) COLOURED (0,0,200) //segments definitive endif return

  But upon trying to calculate the bars that have passed since last (either peak or bottom), my code messed up (lower pane):

  erroneous code

  // manual calculation for the zigzag indicator DEFPARAM DRAWONLASTBARONLY=TRUE //Variables: Points=20 //Pips Perc=0.08 //% Type=1 //0=pips; 1=perc VarY=CustomClose //close,tpicalprice, etc //initialize first point as a "TOP" once LastPoint = 1 once TX0 = barindex once TY0 = VarY //Type ZZ in Points o Perc If Type=0 then //ZZ in pips DeltaY=Points*pipsize elsif Type=1 then //ZZ in % DeltaY=Perc/100*Dclose(1)////Dclose used as ref. endif //ZZ in fase 1 if LastPoint=1 then //lastpoint was a top if VarY>=TY0 then //update last top and stay in LastPoint=1 TY0=VarY TX0=barindex endif if VarY<=TY0-DeltaY then //first point in low LY0=VarY LX0=barindex LastPoint=-1 endif endif //ZZ in fase -1 if LastPoint=-1 then //lastpoint was a low if VarY<=LY0 then //update last low and stay in LastPoint=-1 LY0=VarY LX0=barindex endif if VarY>=LY0+DeltaY then //first point in top TY0=VarY TX0=barindex LastPoint=1 endif endif // BarsSinceLastZigZagPeak = barindex - TX0 // BarsSinceLastZigZagBottom = barindex - LX0 BarsSinceLastZigZagPeak = barindex - TX0 BarsSinceLastZigZagBottom = barindex - LX0 BSZZ = min(BarsSinceLastZigZagPeak, BarsSinceLastZigZagBottom) // return BarsSinceLastZigZagPeak coloured (255,0,0) style (line) as "peak", BarsSinceLastZigZagBottom coloured (0,0,255) style (line) as "bottom" return BSZZ coloured (255,0,0) style (line) as "peak"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59

  // manual calculation for the zigzag indicator DEFPARAM DRAWONLASTBARONLY=TRUE //Variables: Points=20  //Pips Perc=0.08  //% Type=1     //0=pips; 1=perc VarY=CustomClose //close,tpicalprice, etc //initialize first point as a "TOP" once LastPoint = 1 once TX0    = barindex once TY0    = VarY //Type ZZ in Points o Perc If Type=0 then //ZZ in pips DeltaY=Points*pipsize elsif Type=1 then //ZZ in % DeltaY=Perc/100*Dclose(1)////Dclose used as ref. endif //ZZ in fase 1 if LastPoint=1 then //lastpoint was a top if VarY>=TY0 then //update last top and stay in LastPoint=1 TY0=VarY TX0=barindex endif if VarY<=TY0-DeltaY then //first point in low LY0=VarY LX0=barindex LastPoint=-1 endif endif //ZZ in fase -1 if LastPoint=-1 then //lastpoint was a low if VarY<=LY0 then //update last low and stay in LastPoint=-1 LY0=VarY LX0=barindex endif if VarY>=LY0+DeltaY then //first point in top TY0=VarY TX0=barindex LastPoint=1 endif endif   // BarsSinceLastZigZagPeak = barindex - TX0 // BarsSinceLastZigZagBottom = barindex - LX0   BarsSinceLastZigZagPeak = barindex - TX0 BarsSinceLastZigZagBottom = barindex - LX0   BSZZ = min(BarsSinceLastZigZagPeak, BarsSinceLastZigZagBottom) // return BarsSinceLastZigZagPeak coloured (255,0,0) style (line) as "peak", BarsSinceLastZigZagBottom coloured (0,0,255) style (line) as "bottom"   return BSZZ coloured (255,0,0) style (line) as "peak"

  any idea where the calculation should be corrected?

  

  Swisspatrick

  Participant

  Topics: 5

  Replies: 3

  Been thanked: 0 times
• Author
  Posts