Every Fractal indicator minor bug fix

• 03/31/2020 at 7:43 PM #124162
  Vonasi

  I have a minor bug fix for the indicator that can be found in the library here:

  https://www.prorealcode.com/prorealtime-indicators/every-fractal-trend-lines/

  The ITF file attached here corrects an issue whereby the indicator crashes if you enter a value for ‘Qty’ that is greater than the number of fractals detected.

  Here is the updated code:

  //Every Fractal //PRT v11 //By Vonasi //Date: 20200331 //Qty = 1 //StartBack = 0 //Past = 1 //Future = 1 //Points = 1 //Fade = 0 //BarsBefore = 1 //BarsAfter = 1 BarsBefore = max(BarsBefore,1) BarsAfter = max(BarsAfter,1) StartBack = max(0,startback) BarLookBack = BarsAfter + 1 if low[BarsAfter] < lowest[BarsBefore](low)[BarLookBack] THEN if low[BarsAfter] = lowest[BarLookBack](low) THEN a = a + 1 $supportbar[a] = barindex[barsafter] $supportvalue[a] = low[barsafter] endif endif if high[BarsAfter] > highest[BarsBefore](high)[BarLookBack] THEN if high[BarsAfter] = highest[BarLookBack](high) THEN b = b + 1 $resistancebar[b] = barindex[barsafter] $resistancevalue[b] = high[barsafter] endif endif if islastbarupdate then myqty = min(min(b,a),qty) for z = 0 to myqty-1 e = (myqty)-z if fade then c = (255/myqty)*e else c = 255 endif if support then if a >= 2 then if future then drawray($supportbar[a-z-1-startback],$supportvalue[a-z-1-startback],$supportbar[a-z-startback],$supportvalue[a-z-startback])coloured(128,0,0,c) endif if past then drawray($supportbar[a-z-startback],$supportvalue[a-z-startback],$supportbar[a-z-1-startback],$supportvalue[a-z-1-startback])coloured(128,0,0,c) endif if points then drawpoint($supportbar[a-z-1-startback],$supportvalue[a-z-1-startback],2)coloured(128,0,0,c) drawpoint($supportbar[a-z-startback],$supportvalue[a-z-startback],2)coloured(128,0,0,c) endif endif endif if resistance then if b >= 2 then if future then drawray($resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback],$resistancebar[b-z-startback],$resistancevalue[b-z-startback])coloured(0,128,0,c) endif if past then drawray($resistancebar[b-z-startback],$resistancevalue[b-z-startback],$resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback])coloured(0,128,0,c) endif if points then drawpoint($resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback],2)coloured(0,128,0,c) drawpoint($resistancebar[b-z-startback],$resistancevalue[b-z-startback],2)coloured(0,128,0,c) endif endif endif next endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76

  //Every Fractal //PRT v11 //By Vonasi //Date: 20200331   //Qty = 1 //StartBack = 0 //Past = 1 //Future = 1 //Points = 1 //Fade = 0 //BarsBefore = 1 //BarsAfter = 1   BarsBefore = max(BarsBefore,1) BarsAfter = max(BarsAfter,1) StartBack = max(0,startback)            BarLookBack  = BarsAfter + 1 if low[BarsAfter] < lowest[BarsBefore](low)[BarLookBack] THEN if low[BarsAfter] = lowest[BarLookBack](low) THEN a = a + 1 $supportbar[a] = barindex[barsafter] $supportvalue[a] = low[barsafter] endif endif if high[BarsAfter] > highest[BarsBefore](high)[BarLookBack] THEN if high[BarsAfter] = highest[BarLookBack](high) THEN b = b + 1 $resistancebar[b] = barindex[barsafter] $resistancevalue[b] = high[barsafter] endif endif   if islastbarupdate then myqty = min(min(b,a),qty) for z = 0 to myqty-1 e = (myqty)-z if fade then c = (255/myqty)*e else c = 255 endif if support then if a >= 2 then if future then drawray($supportbar[a-z-1-startback],$supportvalue[a-z-1-startback],$supportbar[a-z-startback],$supportvalue[a-z-startback])coloured(128,0,0,c) endif if past then drawray($supportbar[a-z-startback],$supportvalue[a-z-startback],$supportbar[a-z-1-startback],$supportvalue[a-z-1-startback])coloured(128,0,0,c) endif if points then drawpoint($supportbar[a-z-1-startback],$supportvalue[a-z-1-startback],2)coloured(128,0,0,c) drawpoint($supportbar[a-z-startback],$supportvalue[a-z-startback],2)coloured(128,0,0,c) endif endif endif   if resistance then if b >= 2 then if future then drawray($resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback],$resistancebar[b-z-startback],$resistancevalue[b-z-startback])coloured(0,128,0,c) endif if past then drawray($resistancebar[b-z-startback],$resistancevalue[b-z-startback],$resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback])coloured(0,128,0,c) endif if points then drawpoint($resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback],2)coloured(0,128,0,c) drawpoint($resistancebar[b-z-startback],$resistancevalue[b-z-startback],2)coloured(0,128,0,c) endif endif endif next endif   return

   

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  03/31/2020 at 9:28 PM #124171
  Vinks_o_7

  Thanks for your feedback.
  Still have an error (see enclosed capture) and yes I downloaded the file(s).

  

  Vinks_o_7

  Participant

  Topics: 9

  Replies: 24

  Been thanked: 0 times
  03/31/2020 at 11:42 PM #124188
  Vonasi

  What is your exact version number? Mine is version 11.1 1.8_0.202. If we are on the same then we can eliminate that as a reason.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  04/01/2020 at 8:10 AM #124197
  Vinks_o_7

  H

  If I click on the About item in PRT: V11.1 – 1.8.0_45 12 March 2020

  

  Vinks_o_7

  Participant

  Topics: 9

  Replies: 24

  Been thanked: 0 times
  04/01/2020 at 9:21 AM #124206
  Nicolas

  You should not have this error.. Do you get it on every instrument and timeframe please?

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4741 times
  04/01/2020 at 10:45 AM #124222
  Vinks_o_7

  Hi Nicolas
  Nope only on indicators I downloaded recently from PRCode on a daily timeframe.
  Here’s the code that does not work (line 23): $supportbar[a] = barindex[barsafter] which is why I thought it’s an array issue.
  All other indicators’re working fine (I run them under Windows BTW).
  Thanks

  

  Vinks_o_7

  Participant

  Topics: 9

  Replies: 24

  Been thanked: 0 times
  04/01/2020 at 10:57 AM #124226
  Vonasi

  At that point in the code even on the first run through a = 1 and barsafter can never be less than 1 so their should never be any error.

  It is quite difficult to bug fix this when I cannot reproduce the error.

  I’ll add something to the code so that it does not start looking for fractals until there are definitely enough bars to have one and post the code here for you to try.

  I know it sounds stupid but have you tried TIOATIBOA. (Turning it off and turning it back on a gain!) I have found that sometimes in the past shutting down the platform and reopening it and some odd errors suddenly disappear.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  04/01/2020 at 11:43 AM #124230
  Vonasi

  Here is the modified code whereby it only looks for fractals if there are enough bars on the chart to have one. I don’t think it will fix your issue though. Let us know.

  //Every Fractal v1.4 //PRT v11 //By Vonasi //Date: 20200331 //Qty = 1 //StartBack = 0 //Past = 1 //Future = 1 //Points = 1 //Fade = 0 //BarsBefore = 1 //BarsAfter = 1 BarsBefore = max(BarsBefore,1) BarsAfter = max(BarsAfter,1) StartBack = max(0,startback) if barindex >= barsbefore + barsafter then BarLookBack = BarsAfter + 1 if low[BarsAfter] < lowest[BarsBefore](low)[BarLookBack] THEN if low[BarsAfter] = lowest[BarLookBack](low) THEN a = a + 1 $supportbar[a] = barindex[barsafter] $supportvalue[a] = low[barsafter] endif endif if high[BarsAfter] > highest[BarsBefore](high)[BarLookBack] THEN if high[BarsAfter] = highest[BarLookBack](high) THEN b = b + 1 $resistancebar[b] = barindex[barsafter] $resistancevalue[b] = high[barsafter] endif endif if islastbarupdate then myqty = min(min(b,a),qty) for z = 0 to myqty-1 e = (myqty)-z if fade then c = (255/myqty)*e else c = 255 endif if support then if a >= 2 then if future then drawray($supportbar[a-z-1-startback],$supportvalue[a-z-1-startback],$supportbar[a-z-startback],$supportvalue[a-z-startback])coloured(128,0,0,c) endif if past then drawray($supportbar[a-z-startback],$supportvalue[a-z-startback],$supportbar[a-z-1-startback],$supportvalue[a-z-1-startback])coloured(128,0,0,c) endif if points then drawpoint($supportbar[a-z-1-startback],$supportvalue[a-z-1-startback],2)coloured(128,0,0,c) drawpoint($supportbar[a-z-startback],$supportvalue[a-z-startback],2)coloured(128,0,0,c) endif endif endif if resistance then if b >= 2 then if future then drawray($resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback],$resistancebar[b-z-startback],$resistancevalue[b-z-startback])coloured(0,128,0,c) endif if past then drawray($resistancebar[b-z-startback],$resistancevalue[b-z-startback],$resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback])coloured(0,128,0,c) endif if points then drawpoint($resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback],2)coloured(0,128,0,c) drawpoint($resistancebar[b-z-startback],$resistancevalue[b-z-startback],2)coloured(0,128,0,c) endif endif endif next endif endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78

  //Every Fractal v1.4 //PRT v11 //By Vonasi //Date: 20200331   //Qty = 1 //StartBack = 0 //Past = 1 //Future = 1 //Points = 1 //Fade = 0 //BarsBefore = 1 //BarsAfter = 1   BarsBefore = max(BarsBefore,1) BarsAfter = max(BarsAfter,1) StartBack = max(0,startback)   if barindex >= barsbefore + barsafter then BarLookBack  = BarsAfter + 1 if low[BarsAfter] < lowest[BarsBefore](low)[BarLookBack] THEN if low[BarsAfter] = lowest[BarLookBack](low) THEN a = a + 1 $supportbar[a] = barindex[barsafter] $supportvalue[a] = low[barsafter] endif endif if high[BarsAfter] > highest[BarsBefore](high)[BarLookBack] THEN if high[BarsAfter] = highest[BarLookBack](high) THEN b = b + 1 $resistancebar[b] = barindex[barsafter] $resistancevalue[b] = high[barsafter] endif endif   if islastbarupdate then myqty = min(min(b,a),qty) for z = 0 to myqty-1 e = (myqty)-z if fade then c = (255/myqty)*e else c = 255 endif if support then if a >= 2 then if future then drawray($supportbar[a-z-1-startback],$supportvalue[a-z-1-startback],$supportbar[a-z-startback],$supportvalue[a-z-startback])coloured(128,0,0,c) endif if past then drawray($supportbar[a-z-startback],$supportvalue[a-z-startback],$supportbar[a-z-1-startback],$supportvalue[a-z-1-startback])coloured(128,0,0,c) endif if points then drawpoint($supportbar[a-z-1-startback],$supportvalue[a-z-1-startback],2)coloured(128,0,0,c) drawpoint($supportbar[a-z-startback],$supportvalue[a-z-startback],2)coloured(128,0,0,c) endif endif endif   if resistance then if b >= 2 then if future then drawray($resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback],$resistancebar[b-z-startback],$resistancevalue[b-z-startback])coloured(0,128,0,c) endif if past then drawray($resistancebar[b-z-startback],$resistancevalue[b-z-startback],$resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback])coloured(0,128,0,c) endif if points then drawpoint($resistancebar[b-z-1-startback],$resistancevalue[b-z-1-startback],2)coloured(0,128,0,c) drawpoint($resistancebar[b-z-startback],$resistancevalue[b-z-startback],2)coloured(0,128,0,c) endif endif endif next endif endif   return

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  04/01/2020 at 2:01 PM #124242
  Vinks_o_7

  Hi Vonassi
  I relaunched the platform, deleted the old version and imported your new file but I have a similar error (see enclosed screen capture who asked me to edit the code).
  Anyway, thanks for your help.

  

  Vinks_o_7

  Participant

  Topics: 9

  Replies: 24

  Been thanked: 0 times
  04/02/2020 at 2:02 PM #124362
  Vonasi

  Are you with IB? If so there has been an update today for their version of PRTv11 so this might fix your issue.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  04/04/2020 at 7:26 AM #124574
  Vinks_o_7

  Hi Vonassi
  Yes I’m with Interactive Broker, will give it a try today 😉

  

  Vinks_o_7

  Participant

  Topics: 9

  Replies: 24

  Been thanked: 0 times
  04/04/2020 at 8:08 AM #124575
  Vinks_o_7

  no more error: it works…ευχαριστώ

  

  Vinks_o_7

  Participant

  Topics: 9

  Replies: 24

  Been thanked: 0 times
  04/04/2020 at 9:59 AM #124591
  Vonasi

  I’m glad to hear that it was a platform version issue and not an issue with my code. It’s so much easier when someone else fixes the problem 🙂

  I’m actually from the UK by the way but my location is Greece.My Greek is just about up to understanding ‘ευχαριστώ’ so I won’t tell you off for posting in the wrong language!

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  04/04/2020 at 11:28 AM #124598
  Vinks_o_7

  Anyway, thanks for your hard work and help !

  

  Vinks_o_7

  Participant

  Topics: 9

  Replies: 24

  Been thanked: 0 times
  04/04/2020 at 12:43 PM #124605
  GraHal

  Vonasi wrote:

  I’m actually from the UK

  Until you explained (a while back) where Vonasi comes from, I had thought you must be of German origin! 🙂

  But having thought above, I couldn’t understand how you had a UK sense of humour and had even watched ‘Minder’ ! 🙂

  

  GraHal

  Participant

  Topics: 204

  Replies: 8399

  Been thanked: 2041 times
• Author
  Posts