highest high in a specific time range and timeframe

• 01/07/2021 at 9:31 PM #156809
  joepetting

  hi to all,

  i am new here and start to learn programming to make my own indicators.

  I hope someone can help me with my actual problem.

  • i search the highest high and the lowest low on the 15 minutes chart between 8 and 9 o’clock
  • the problem is that i get all the highs and lows from every candle in this timerange

  thanks for the help in advance

  kind regards

  highest high between 8 and 9 o'clock

  defparam calculateonlastbars = 100 if time > 080000 and time < 090000 then HighestH = high //max(high,high) LowestL = low //min(low,low) //UpperRange = HighestH < HighestH[1] and HighestH > HighestH[2] //BottomRange = LowestL > LowestL[1] and LowestL < LowestL[2] endif //if currentdayofweek = 1 or 2 or 3 or 4 or 5 then drawray(barindex-1,HighestH,HighestH,HighestH) coloured(0,200,0) STYLE(line,2) drawray(barindex-1,LowestL,LowestL,LowestL) coloured(200,0,0) STYLE(line,2) //endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

  defparam calculateonlastbars = 100   if time > 080000 and time < 090000 then HighestH = high //max(high,high) LowestL = low //min(low,low)   //UpperRange = HighestH < HighestH[1] and HighestH > HighestH[2] //BottomRange = LowestL > LowestL[1] and LowestL < LowestL[2] endif   //if currentdayofweek = 1 or 2 or 3 or 4 or 5 then   drawray(barindex-1,HighestH,HighestH,HighestH) coloured(0,200,0) STYLE(line,2)   drawray(barindex-1,LowestL,LowestL,LowestL) coloured(200,0,0) STYLE(line,2)   //endif   return

   

  

  joepetting

  Participant

  Topics: 1

  Replies: 2

  Been thanked: 0 times
  01/07/2021 at 10:33 PM #156819
  robertogozzi

  At line 3 you should use >= and <=.

  Lines 4-5 must be replaced by:

  HighestH = max(high,HighestH) LowestL = min(low,LowestL)

  1 2	HighestH = max(high,HighestH) LowestL  = min(low,LowestL)

  but you also need to reset them each day, at the beginning of the code, at line 2:

  If IntraDayBarIndex = 0 then HighestH = 0 LowestL = 999999 endif

  1 2 3 4

  If IntraDayBarIndex = 0 then    HighestH = 0    LowestL  = 999999 endif

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16502

  Been thanked: 3657 times
  01/08/2021 at 1:55 PM #156907
  joepetting

  defparam calculateonlastbars = 100 If IntraDayBarIndex = 0 then HighestH = 0 LowestL = 99999 endif if time >= 080000 and time <= 090000 then HighestH = max(high,HighestH) LowestL = min(low,LowestL) endif drawray(barindex-1,HighestH,HighestH,HighestH) coloured(0,200,0) STYLE(line,2) drawray(barindex-1,LowestL,LowestL,LowestL) coloured(200,0,0) STYLE(line,2) return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17

  defparam calculateonlastbars = 100   If IntraDayBarIndex = 0 then HighestH = 0 LowestL  = 99999 endif   if time >= 080000 and time <= 090000 then HighestH = max(high,HighestH) LowestL = min(low,LowestL) endif   drawray(barindex-1,HighestH,HighestH,HighestH) coloured(0,200,0) STYLE(line,2)   drawray(barindex-1,LowestL,LowestL,LowestL) coloured(200,0,0) STYLE(line,2)   return

  hi thanks for your help, i changed the code but its not working. attached is pictures of the result (chart) there should be only to lines

  one upper and one bottom line.   kind regards

  

  joepetting

  Participant

  Topics: 1

  Replies: 2

  Been thanked: 0 times
  01/08/2021 at 2:39 PM #156915
  robertogozzi

  You need to use as first or second line:

  Defparam DrawOnLastBarOnly = true

  1	Defparam DrawOnLastBarOnly = true

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16502

  Been thanked: 3657 times
  01/08/2021 at 3:06 PM #156921
  Nobody

  try replacing max with highest and min with lowest and see how it goes

  

  Nobody

  Participant

  Topics: 9

  Replies: 190

  Been thanked: 59 times
  01/08/2021 at 3:15 PM #156922
  joepetting

  thanks it works, now i can go on with it

  

  joepetting

  Participant

  Topics: 1

  Replies: 2

  Been thanked: 0 times
• Author
  Posts