Help with Higher Lows Price sync with Higher Low MACD when candle crosses MA

Malend · Fri, 06 Sep 2019 13:12:40 +0000

Hello all, What I want to see is this: A Cycle Low is the period when the MACD < Signal line. It starts when the MACD crosses under the Signal line and ends when the MACD crosses over the Signal line. The MACD Cycle Lowest is the Lowest MACD during that Cycle Low, measured after the Cycle has finished, I want a Signal when: – a bullish candle crosses over the bullish SMA50at the close of the candle and – the MACD at that > previous MACD Cycle Lowest and – the MACD at that moment =< Signal line and – the price low at that moment > price low at the previous MACD Cycle Lowest. Where I fail is how to describe the period of the cycle low from the MACD, the start and the end and how to define the lowest MACD and the the lowes price in that MACD-period. I only have the long version here to keep it readable. When it works I will complete it with the short version included. Thanks a lot, Marc // Higher Lows Price in sync with Higher Low MACD //indicators SMA50 and MACD MA = Average[50] LM = MACDline[12,26,9] //CCL = CONDITIONS CANDLES IN RELATION TO AVERAGE FOR LONG POSITION //bullish candle crosses over bullish Average. C1 = ma[1] =< ma and open < m50 and close > m50 // The body of the previous candle needs to be below the Average C2 = open[1] < m50 and close[1] < m50 CCL = c1 and c2 // CYCLE LOW MACD (MCL), the lowest MACD in the period when MACD < Signalline // Comparing MACD in a next running CYCLE LOW at a close of a bar with the previous CYCLE LOW. // START MCL MD1 = LM(close) =< Signalline and LM[1] > LM(close) If MD1 then MCL = 1 //END OF CYCLE LOW MACD MD2 = LM(close) => Signalline and LM[1] < LM(close) If MD2 then MCL = 0 //DEFINING MACD CYLCE LOWEST, MDLST MCLST = MCL [lowest] //MACD higher low MHL = [MCLST][1] < MCL //PRICE, PHL is PRICE LOW > PRICE LOW AT THE PREVIOUS, PHL = low > low [MCLST] // SIGNAL LONG If CCA and MHL and PHL then DRAWSEGMENT (barindex, close+1.7, barindex, close+2.2)COLOURED(0,250,0) DRAWSEGMENT (barindex, close+1.7, barindex+1, close+1.7)COLOURED(0,250,0) DRAWTEXT("1.7", barindex-1, close+1.7, Dialog, Standard, 10) COLOURED(0,0,0) DRAWSEGMENT (barindex, close+2.2, barindex+1, close+2.2)COLOURED(0,250,0) DRAWTEXT("2.2", barindex-1, close+2.2, Dialog, Standard, 10) COLOURED(0,0,0) DRAWSEGMENT (barindex, close+1, barindex+1, close+1)COLOURED(100,100,100) DRAWSEGMENT (barindex, close+1.7, barindex, close+1)COLOURED(100,100,100) DRAWTEXT("1.0", barindex-1, close+1, Dialog, Standard, 10) COLOURED(100,100,100) DRAWTEXT("F1", barindex, close+2.8, Dialog, Standard, 14) COLOURED(0,250,0) DRAWSEGMENT (barindex, close-sl, barindex+1, close-sl)COLOURED(250,0,100) DRAWSEGMENT (barindex, close-(sl-0.25), barindex, close-sl)COLOURED(250,0,100) endif endif endif return

This topic has 72 replies, 3 voices, and was last updated 4 years ago by GraHal.

Viewing 15 posts - 31 through 45 (of 73 total)

← 1 2 3 4 5 →

09/09/2019 at 3:24 PM #106980

Malend

FANTASTIC, Vonasi,
Haha…..yes everything is easy ;-), when you know how to do it.
But yes, this is what I was looking for. We have a break through.

And the next step is to switch between Cycle Lows and Cycle Highs 🙂

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/09/2019 at 3:59 PM #106981

Vonasi

I could write the code in about two minutes but I’m guessing that you’d prefer to have a go yourself first as otherwise it would be like getting the teacher to do your homework!

Vonasi

Moderator

Topics: 192

Replies: 5088

Been thanked: 1810 times

09/09/2019 at 4:08 PM #106982

Malend

Please let me do it myself. I will keep you informed.

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/09/2019 at 5:08 PM #106984

Malend

I have loaded the indicator in the chart for the lowest Price and in the MACD for the lowest MACD.

I still see some hesitations. See my attachment.
.
Below the MACD you see the histogram of the candles/period of the cycle low..
I see there is a moment where there are 2 cycle lows next to each othere, but in both it doesn’t take the lowest Price..
In the MACD below the chart, I made the lowest MACD in cycle light blue dashed. That doesn’t fit with the real lowest MACD in cycle.
.
Do I overlook something?

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/09/2019 at 5:11 PM #106985

Malend

Sorry, here the attachment.

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/09/2019 at 5:56 PM #106987

Malend

Ah,,, I see what happens, it takes the low at the bar of the lowest MACD, instead of the lowest price within the cycle low. That might be on the bar of the lowest MACD, but doesn’t need to be like that.

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/09/2019 at 6:58 PM #106995

Vonasi

Yes – I thought that was what you said you wanted – but I did wonder. So you really want the lowest price during the cycle – not the lowest price at the lowest MACD in the cycle? That’s easily fixed.

macdl = macdline[12,26,9]
macds = exponentialaverage[9](macdl)
 
//start of cycle
If macdl < macds and macdl[1] > macds[1] then
macdlowest2 = macdlowest
lowestprice2 = lowestprice
incycle = 1
macdlowest = macdl
LowestPrice = low
endif
 
//Eend of cycle
If macdl > macds and macdl[1] < macds[1] then
incycle = 0
endif
 
//lowest macd and price in cycle
if incycle then
macdlowest = min(macdlowest, macdl)
lowestPrice = min(lowestprice, low)
endif

return macdlowest as "lowest macd in cycle", lowestprice as "lowest price in cycle", macdlowest2 as "previous lowest macd in cycle", lowestprice2 as "previous lowest price in cycle"

macdl = macdline[12,26,9]

macds = exponentialaverage[9](macdl)

//start of cycle

If macdl < macds and macdl[1] > macds[1] then

macdlowest2 = macdlowest

lowestprice2 = lowestprice

incycle = 1

macdlowest = macdl

LowestPrice = low

endif

//Eend of cycle

If macdl > macds and macdl[1] < macds[1] then

incycle = 0

endif

//lowest macd and price in cycle

if incycle then

macdlowest = min(macdlowest, macdl)

lowestPrice = min(lowestprice, low)

endif

return macdlowest as "lowest macd in cycle", lowestprice as "lowest price in cycle", macdlowest2 as "previous lowest macd in cycle", lowestprice2 as "previous lowest price in cycle"

Vonasi

Moderator

Topics: 192

Replies: 5088

Been thanked: 1810 times

09/09/2019 at 7:55 PM #107004

Malend

Yes, with an extra endif after line 22 that works perfectly for the lowest price. But for the lowest of the MACD I still have some problems.
See thee attachement. The lowest prices are perfect, but the MACD is still not right, see the ellipses in the image. The light blue dashed line in the MACD is the lowest MACD of the indicator.

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/09/2019 at 8:14 PM #107010

Malend

The line of the lowest price in cycle works perfect.
The line of the previous loweste price doesn’t make any sense to me. 🙂

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/09/2019 at 8:17 PM #107011

Malend

Add the indicator directly into your chart and make the lowest MACD end the previous lowest MACD invisible.
And Add the indicator directly into you MACD and make the lowest price and the previous lowest price invisble.
Then the indicator is the best visible to test it.

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/09/2019 at 8:37 PM #107012

Malend

Sorry for the many posts.
It works with the MACD lowest when I add it as a seperate indicator. The I see the lowest macd in cycle is the lowest macd from the last finished cycle low. When I add the indicator into the MACD itself, then it makes something totally different out of it.
The previous lowest in the MACD, I don’t understand what comes out of that. But that doesn’t matter to me, because what I need to see is shown in the lowest MACD. So I switch that to invisible.

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/09/2019 at 9:08 PM #107015

Vonasi

I was just about to post to say that I found exactly the same problem. Plotting on the MACD indicator does not seem to work correctly.

It is best to draw your own MACD so I adapted the code this to prove that the positions were all correctly identified:

macdl = macdline[12,26,9]
macds = exponentialaverage[9](macdl)
 
//start of cycle
If macdl < macds and macdl[1] > macds[1] then
macdindex2 = macdindex
lowindex2 = lowindex
//macdlowest2 = macdlowest
//lowestprice2 = lowestprice
drawvline(macdindex) coloured(0,0,255)
drawvline(macdindex2) coloured(0,0,0)
drawvline(lowindex) coloured(255,0,0)
drawvline(lowindex2) coloured(0,255,0)
incycle = 1
macdlowest = macdl
LowestPrice = low
endif
 
//Eend of cycle
If macdl > macds and macdl[1] < macds[1] then
incycle = 0
endif
 
//lowest macd and price in cycle
if incycle then
macdlowest = min(macdlowest, macdl)
lowestPrice = min(lowestprice, low)
if macdlowest = macdl then
macdindex = barindex
endif
if lowestprice = low then
lowindex = barindex
endif
endif

return macdl, macds//macdlowest as "lowest macd in cycle", macdlowest2 as "previous lowest macd in cycle", lowestprice as "lowest price in cycle", macdlowest2 as "previous lowest macd in cycle", lowestprice2 as "previous lowest price in cycle"

macdl = macdline[12,26,9]

macds = exponentialaverage[9](macdl)

//start of cycle

If macdl < macds and macdl[1] > macds[1] then

macdindex2 = macdindex

lowindex2 = lowindex

//macdlowest2 = macdlowest

//lowestprice2 = lowestprice

drawvline(macdindex) coloured(0,0,255)

drawvline(macdindex2) coloured(0,0,0)

drawvline(lowindex) coloured(255,0,0)

drawvline(lowindex2) coloured(0,255,0)

incycle = 1

macdlowest = macdl

LowestPrice = low

endif

//Eend of cycle

If macdl > macds and macdl[1] < macds[1] then

incycle = 0

endif

//lowest macd and price in cycle

if incycle then

macdlowest = min(macdlowest, macdl)

lowestPrice = min(lowestprice, low)

if macdlowest = macdl then

macdindex = barindex

endif

if lowestprice = low then

lowindex = barindex

endif

return macdl, macds//macdlowest as "lowest macd in cycle", macdlowest2 as "previous lowest macd in cycle", lowestprice as "lowest price in cycle", macdlowest2 as "previous lowest macd in cycle", lowestprice2 as "previous lowest price in cycle"

Vonasi

Moderator

Topics: 192

Replies: 5088

Been thanked: 1810 times

09/09/2019 at 10:58 PM #107022

Malend

I saw that the values are correct in the indicator when I inserted it as an individual indicator, not when I inserted it into the MACD-indicator.
I have also made the cycle high version :-). It works.
I am now gonna work on how to make the indicator better readable.
I keep you posted.
Thanks a lot Vonasi for your patience and your passion,
Marc

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/10/2019 at 8:10 AM #107028

Malend

Good morning,
I have a few questions….still.
-Which vlines are the the ones inline 13 and line 15? They mark the bar with the lowest Macd before the next bar with the lowest MACD in the cycle, right? Are these interesting?Is there a reason you gave them a vline?

And….
Is there a way to name the lowestprice of the last cycle low and the lowest price of the cycle low befor the last cycle low.
.
So I can drawtext when…………… the lowest price of the cycle low [1] < the lowestprice of the cycle low
The same with the macdl.…………. the lowest macdl of the cycle low [1] < the lowest macdl of the cycle low
.

Actually don’t want to see all the movements from from the lowest prices and macdl’s. It makes the chart so noisy. I am only interested actual bars.

I tell you the end result I am working on.
if open < sma50 and close > sma50 and macdl > macdlowest from the last cycle low and low > lowest of the last previous cycle low then
DRAWTEXT…….
This is the only place where I want something to see in my chart.
I included this allready some post befor, but here again in the image.

Malend

Participant

Topics: 14

Replies: 100

Been thanked: 4 times

09/10/2019 at 8:49 AM #107032

Vonasi

I chose vertical lines because… well because I just did! No real reason.

You can draw arrows or write text wherever you like on a chart. See DRAWTEXT and DRAWARROWUP, DRAWARROWDOWN etc in the documentation.

Here is the cycle low code with arrows added when the conditions you describe are met.

Apply it directly to the price chart using the wrench/spanner in the corner

macdl = macdline[12,26,9]
macds = exponentialaverage[9](macdl)
 
//start of cycle
If macdl < macds and macdl[1] > macds[1] then
macdlowest2 = macdlowest
lowestprice2 = lowestprice
incycle = 1
macdlowest = macdl
LowestPrice = low
endif
 
//end of cycle
If macdl > macds and macdl[1] < macds[1] then
incycle = 0
endif
 
//lowest macd and price in cycle
if incycle then
macdlowest = min(macdlowest, macdl)
lowestPrice = min(lowestprice, low)

c1 = open < average[50](close)
c2 = close > average[50](close)
c3 = macdlowest > macdlowest2
c4 = lowestprice > lowestprice2

if c1 and c2 and c3 and c4 then
drawarrowup(barindex,low)coloured(0,128,0)
endif
endif

return

macdl = macdline[12,26,9]

macds = exponentialaverage[9](macdl)

//start of cycle

If macdl < macds and macdl[1] > macds[1] then

macdlowest2 = macdlowest

lowestprice2 = lowestprice

incycle = 1

macdlowest = macdl

LowestPrice = low

endif

//end of cycle

If macdl > macds and macdl[1] < macds[1] then

incycle = 0

endif

//lowest macd and price in cycle

if incycle then

macdlowest = min(macdlowest, macdl)

lowestPrice = min(lowestprice, low)

c1 = open < average[50](close)

c2 = close > average[50](close)

c3 = macdlowest > macdlowest2

c4 = lowestprice > lowestprice2

if c1 and c2 and c3 and c4 then

drawarrowup(barindex,low)coloured(0,128,0)

endif

return

Note: code edited at 1102 to correct averages.

Vonasi

Moderator

Topics: 192

Replies: 5088

Been thanked: 1810 times

Author

Posts

Viewing 15 posts - 31 through 45 (of 73 total)

← 1 2 3 4 5 →

Find exclusive trading pro-tools on