Capture yesterday high low

• 04/28/2019 at 9:11 AM #97279
  BC

  I want to capture yesterday (9:15 – 16:30) high low and show on today chart, but my code didn’t show correctly, what I did wrong?

   

  Once StartTime = 91500 Once EndTime = 163000 If Time >= StartTime and Time <= EndTime then If Time = StartTime then DailyHigh = High DailyLow = Low Endif If High > DailyHigh then DailyHigh = High Endif If Low < DailyLow then DailyLow = Low Endif Endif return DailyHigh[1], DailyLow[1]

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23

  Once StartTime = 91500 Once EndTime = 163000     If Time >= StartTime and Time <= EndTime then   If Time = StartTime then DailyHigh = High DailyLow = Low Endif   If High > DailyHigh then DailyHigh = High Endif   If Low < DailyLow then DailyLow = Low Endif   Endif     return DailyHigh[1], DailyLow[1]

   

   

  

  BC

  Participant

  Topics: 24

  Replies: 170

  Been thanked: 34 times
  04/28/2019 at 9:52 AM #97283
  Vonasi

  You need to store yesterdays value before resetting and looking for todays value.

  Once StartTime = 91500 Once EndTime = 163000 If Time >= StartTime and Time <= EndTime then If Time = StartTime then YesterdaysHigh = DailyHigh YesterdaysLow = DailyLow DailyHigh = High DailyLow = Low Endif If High > DailyHigh then DailyHigh = High Endif If Low < DailyLow then DailyLow = Low Endif Endif return YesterdaysHigh, YesterdaysLow

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24

  Once StartTime = 91500 Once EndTime = 163000 If Time >= StartTime and Time <= EndTime then If Time = StartTime then YesterdaysHigh = DailyHigh YesterdaysLow = DailyLow DailyHigh = High DailyLow = Low Endif If High > DailyHigh then DailyHigh = High Endif If Low < DailyLow then DailyLow = Low Endif Endif return YesterdaysHigh, YesterdaysLow

  You could also use MAX and MIN instead of all the IF  and THEN’s.

  Once StartTime = 91500 Once EndTime = 163000 If Time >= StartTime and Time <= EndTime then If Time = StartTime then YesterdaysHigh = DailyHigh YesterdaysLow = DailyLow DailyHigh = High DailyLow = Low Endif DailyHigh = max(high,DailyHigh) DailyLow = min(low,Dailylow) Endif return YesterdaysHigh, YesterdaysLow

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

  Once StartTime = 91500 Once EndTime = 163000 If Time >= StartTime and Time <= EndTime then If Time = StartTime then YesterdaysHigh = DailyHigh YesterdaysLow = DailyLow DailyHigh = High DailyLow = Low Endif DailyHigh = max(high,DailyHigh) DailyLow = min(low,Dailylow) Endif return YesterdaysHigh, YesterdaysLow

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  04/28/2019 at 11:11 AM #97286
  BC

  Vonasi

  It works! Thanks a lot.

  

  BC

  Participant

  Topics: 24

  Replies: 170

  Been thanked: 34 times
  10/20/2019 at 9:35 AM #110619
  BC

  Hi PRT Master

   

  I stuck again on how to capture last week (9:15 – 16:30) high low, anyone can help?

   

  Thanks

   

  

  BC

  Participant

  Topics: 24

  Replies: 170

  Been thanked: 34 times
  10/20/2019 at 10:55 AM #110623
  Vonasi

  Try this:

  StartTime = 091500 EndTime = 163000 once LastWeeksHigh = undefined once LastWeeksLow = undefined if opendayofweek < opendayofweek[1] then LastWeeksHigh = DailyHigh LastWeeksLow = DailyLow firsttime = 0 endif If not firsttime and Time = StartTime then DailyHigh = High DailyLow = Low firsttime = 1 endif if firsttime and Time >= StartTime and Time <= EndTime then DailyHigh = max(high,DailyHigh) DailyLow = min(low,Dailylow) Endif return LastWeeksHigh, LastWeeksLow

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24

  StartTime = 091500 EndTime = 163000   once LastWeeksHigh = undefined once LastWeeksLow = undefined if opendayofweek < opendayofweek[1] then LastWeeksHigh = DailyHigh LastWeeksLow = DailyLow firsttime = 0 endif   If not firsttime and Time = StartTime then DailyHigh = High DailyLow = Low firsttime = 1 endif   if firsttime and Time >= StartTime and Time <= EndTime then DailyHigh = max(high,DailyHigh) DailyLow = min(low,Dailylow) Endif return LastWeeksHigh, LastWeeksLow

  EDIT : Code corrected 20191021

  1 user thanked author for this post.

  BC

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  10/20/2019 at 12:51 PM #110635
  BC

  Million Thanks, Vonasi.

  

  BC

  Participant

  Topics: 24

  Replies: 170

  Been thanked: 34 times
  10/21/2019 at 2:32 PM #110719
  BC

  Hi Vonasi

   

  I just test the code, but the output not same as your screen cap.

   

  BC

  

  BC

  Participant

  Topics: 24

  Replies: 170

  Been thanked: 34 times
  10/21/2019 at 2:36 PM #110721
  BC

  Hi Vonasi

   

  I found where is the problem, should use OpenDayOfWeek command instead of OpenDay.

   

  Thanks

  

  BC

  Participant

  Topics: 24

  Replies: 170

  Been thanked: 34 times
  10/21/2019 at 3:42 PM #110731
  Vonasi

  Sorry about that – not sure how that typo got in there! I’ll edit the code in my post to correct it.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  10/26/2019 at 4:11 AM #111245
  BC

  Hi Vonasi

   

  I stuck again on capture last X week high low within 9:15-16:00, can you help?

   

  Thanks

  

  BC

  Participant

  Topics: 24

  Replies: 170

  Been thanked: 34 times
  10/26/2019 at 9:43 AM #111256
  Vonasi

  By X do you mean you want the high and low between 0915 and 1600 for the week X weeks ago or do you mean you want them for the last X weeks all included?

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  10/26/2019 at 9:46 AM #111257
  BC

  High and low between 0915 and 1600 for the week X weeks ago, eg: 10 weeks ago.

   

  Thanks

  

  BC

  Participant

  Topics: 24

  Replies: 170

  Been thanked: 34 times
  10/26/2019 at 10:09 AM #111261
  Vonasi

  This code will do that – but be warned it is very slow to draw due to the loop.

  StartTime = 091500 EndTime = 160000 once myWeeksHigh = undefined once myWeeksLow = undefined if opendayofweek < opendayofweek[1] then firsttime = 0 endif If not firsttime and Time = StartTime then myWeeksHigh = DailyHigh myWeeksLow = DailyLow weekindex = weekindex + 1 DailyHigh = High DailyLow = Low firsttime = 1 endif if firsttime and openTime >= StartTime and opentime < EndTime then DailyHigh = max(high,DailyHigh) DailyLow = min(low,Dailylow) endif if weekindex > lookback then for j = 1 to barindex if WeekIndex[j] = WeekIndex - lookback then myweekshigh = Dailyhigh[j] myweekslow = Dailylow[j] break endif next endif return myWeeksHigh, MyWeeksLow

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35

  StartTime = 091500 EndTime = 160000   once myWeeksHigh = undefined once myWeeksLow = undefined if opendayofweek < opendayofweek[1] then firsttime = 0 endif   If not firsttime and Time = StartTime then myWeeksHigh = DailyHigh myWeeksLow = DailyLow weekindex = weekindex + 1 DailyHigh = High DailyLow = Low firsttime = 1 endif   if firsttime and openTime >= StartTime and opentime < EndTime then DailyHigh = max(high,DailyHigh) DailyLow = min(low,Dailylow) endif   if weekindex > lookback then for j = 1 to barindex if WeekIndex[j] = WeekIndex - lookback then myweekshigh = Dailyhigh[j] myweekslow = Dailylow[j] break endif next endif return myWeeksHigh, MyWeeksLow

   

  1 user thanked author for this post.

  robertogozzi

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  10/27/2019 at 4:04 AM #111305
  BC

  Thanks Vonasi.

  

  BC

  Participant

  Topics: 24

  Replies: 170

  Been thanked: 34 times
• Author
  Posts