John Carter coloured momentum candles

• 02/15/2023 at 9:17 AM #209701
  Alfy

  Good morning guys, I’m trying to colour the candlesticks in my charts using a momentum indicator and although it is working

  John Carter Momentum candles

  DonchianMidline = (Highest[20](high)+Lowest[20](low)+Average[20](close) )/3 sma=close-(DonchianMidline) Delta = linearregression[20](sma) if delta>0 and delta>delta[1] Then DRAWCANDLE(open, high, low, close)COLOURED(0,245,255) colour=1 endif if delta>0 and delta<delta[1] then DRAWCANDLE(open, high, low, close)COLOURED(0,0,255) colour=2 endif if delta<0 and delta<delta[1] then DRAWCANDLE(open, high, low, close)coloured(255,0,0) colour=3 endif if delta<0 and delta>delta[1] then DRAWCANDLE(open, high, low, close)coloured(255,255,0) colour=4 endif RETURN colour

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24

  DonchianMidline = (Highest[20](high)+Lowest[20](low)+Average[20](close) )/3 sma=close-(DonchianMidline) Delta = linearregression[20](sma) if delta>0 and delta>delta[1] Then DRAWCANDLE(open, high, low, close)COLOURED(0,245,255) colour=1 endif if delta>0 and delta<delta[1]  then DRAWCANDLE(open, high, low, close)COLOURED(0,0,255) colour=2 endif if delta<0 and delta<delta[1]  then DRAWCANDLE(open, high, low, close)coloured(255,0,0) colour=3 endif if delta<0 and delta>delta[1] then DRAWCANDLE(open, high, low, close)coloured(255,255,0) colour=4 endif RETURN colour

   

  on the monthly and weekly charts, on the daily charts its doing something strange with all the prices squashed. Can someone take a look at my code and let me know what I’m doing wrong please?

  Best regards and thank you

   

  

  Alfy

  Participant

  Topics: 34

  Replies: 53

  Been thanked: 5 times
  02/15/2023 at 9:47 AM #209707
  GraHal

  Appears to works fine on mine?

  See attached on Monthly Chart

  

  GraHal

  Participant

  Topics: 204

  Replies: 8401

  Been thanked: 2042 times
  02/15/2023 at 9:48 AM #209709
  Alfy

  yep, works on weekly too but not on daily chart

  

  Alfy

  Participant

  Topics: 34

  Replies: 53

  Been thanked: 5 times
  02/15/2023 at 9:53 AM #209710
  GraHal

  Works fine on Daily Chart on mine, I checked up to 100K bars … very colourful! 🙂

  1 user thanked author for this post.

  Alfy

  

  GraHal

  Participant

  Topics: 204

  Replies: 8401

  Been thanked: 2042 times
  02/15/2023 at 9:55 AM #209711
  Alfy

  Strange, ok, thanks for the feedback

  

  Alfy

  Participant

  Topics: 34

  Replies: 53

  Been thanked: 5 times
  02/15/2023 at 10:25 AM #209717
  JC_Bywan

  Maybe your scale on your daily chart isn’t set up the same way as in the other charts, you can check with right click on price scale on right margin, then in the menu pick the one at the end about “configuration of the zone” (not sure the exact english name of it), then as in attached image you are in “scale” menu (left side) and on the right side of the panel check the box about using price only is checked, it will avoid making visible the values 1 to 4 of the returned “colour” variable of your indicator added to price, assuming it was that kind of squashing.

  Maybe it wasn’t the problem at all, but the absence of screen capture also means absence of clues for those willing to help, we have to make hypothesis of what “squashed” means in the first place before wondering what might have done this. So maybe I got the wrong “squash”, and the wrong solution…

  1 user thanked author for this post.

  Alfy

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2549

  Been thanked: 839 times
  02/15/2023 at 10:36 AM #209721
  Alfy

  All fixed. If interested please see attached fixed code.

  John Carter Momentum candles

  DonchianMidline = (Highest[20](high)+Lowest[20](low)+Average[20](close) )/3 sma=close-(DonchianMidline) Delta = linearregression[20](sma) if delta>0 and delta>delta[1] Then DRAWCANDLE(open, high, low, close)COLOURED(0,245,255) endif if delta>0 and delta<delta[1] then DRAWCANDLE(open, high, low, close)COLOURED(0,0,255) endif if delta<0 and delta<delta[1] then DRAWCANDLE(open, high, low, close)coloured(255,0,0) endif if delta<0 and delta>delta[1] then DRAWCANDLE(open, high, low, close)coloured(255,255,0) endif RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24

  DonchianMidline = (Highest[20](high)+Lowest[20](low)+Average[20](close) )/3 sma=close-(DonchianMidline) Delta = linearregression[20](sma)     if delta>0 and delta>delta[1] Then DRAWCANDLE(open, high, low, close)COLOURED(0,245,255) endif if delta>0 and delta<delta[1]  then DRAWCANDLE(open, high, low, close)COLOURED(0,0,255) endif if delta<0 and delta<delta[1]  then DRAWCANDLE(open, high, low, close)coloured(255,0,0) endif if delta<0 and delta>delta[1] then DRAWCANDLE(open, high, low, close)coloured(255,255,0) endif RETURN

   

   

  

  Alfy

  Participant

  Topics: 34

  Replies: 53

  Been thanked: 5 times
  02/15/2023 at 11:28 AM #209732
  GraHal

  JC_Bywan wrote:

  values 1 to 4 of the returned “colour” variable of your indicator

  To close the loop and so we all know for future on similar ‘squashings’ 🙂 … the amended code has removed the refs to colour 1 to 4.

   

  1 user thanked author for this post.

  Alfy

  

  GraHal

  Participant

  Topics: 204

  Replies: 8401

  Been thanked: 2042 times
  02/15/2023 at 11:34 AM #209734
  Alfy

  thanks so much for all your help!

  

  Alfy

  Participant

  Topics: 34

  Replies: 53

  Been thanked: 5 times
• Author
  Posts