Help porting Donchian Trend Ribbon

• 05/12/2023 at 11:10 AM #214596
  Lavallette

  Hello All,

  I’m interested in Donchian Trend Ribbon available in TradingView https://www.tradingview.com/script/PxLqmP8o-Donchian-Trend-Ribbon/ .

  I started porting it to ProRealTime but I’m struggling. This is my code so far. It could be improved with loops etc. but I wanted to keep it simple until I have something working.

  PRT Donchian Channel

  Len = 30 hh = Highest[Len] ll = Lowest[Len] maintrend = 0 IF close > hh[1] THEN maintrend = 1 ELSIF close < ll[1] THEN maintrend = -1 ENDIF trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a=0 IF maintrend = 1 THEN IF trend = 1 THEN a = 1 ELSE a = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a = -1 ELSE a = -1 endif endif //////////////////// hh = Highest[Len-1] ll = Lowest[Len-1] trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a1=0 IF maintrend = 1 THEN IF trend = 1 THEN a1 = 1 ELSE a1 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a1 = -1 ELSE a1 = -1 endif endif //////////////////// hh = Highest[Len-2] ll = Lowest[Len-2] trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a2=0 IF maintrend = 1 THEN IF trend = 1 THEN a2 = 1 ELSE a2 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a2 = -1 ELSE a2 = -1 endif endif //////////////////// hh = Highest[Len-3] ll = Lowest[Len-3] trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a3=0 IF maintrend = 1 THEN IF trend = 1 THEN a3 = 1 ELSE a3 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a3 = -1 ELSE a3 = -1 endif endif //////////////////// hh = Highest[Len-4] ll = Lowest[Len-4] trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a4=0 IF maintrend = 1 THEN IF trend = 1 THEN a4 = 1 ELSE a4 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a4 = -1 ELSE a4 = -1 endif endif //////////////////// hh = Highest[Len-5] ll = Lowest[Len-5] trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a5=0 IF maintrend = 1 THEN IF trend = 1 THEN a5 = 1 ELSE a5 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a5 = -1 ELSE a5 = -1 endif endif //////////////////// hh = Highest[Len-6] ll = Lowest[Len-6] trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a6=0 IF maintrend = 1 THEN IF trend = 1 THEN a6 = 1 ELSE a6 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a6 = -1 ELSE a6 = -1 endif endif //////////////////// hh = Highest[Len-7] ll = Lowest[Len-7] trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a7=0 IF maintrend = 1 THEN IF trend = 1 THEN a7 = 1 ELSE a7 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a7 = -1 ELSE a7 = -1 endif endif //////////////////// hh = Highest[Len-8] ll = Lowest[Len-8] //trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a8=0 IF maintrend = 1 THEN IF trend = 1 THEN a8 = 1 ELSE a8 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a8 = -1 ELSE a8 = -1 endif endif //////////////////// hh = Highest[Len-9] ll = Lowest[Len-9] //trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF //a9=0 IF maintrend = 1 THEN IF trend = 1 THEN a9 = 1 ELSE a9 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a9 = -1 ELSE a9 = -1 endif endif return a + a1 + a2 + a3 + a4 + a5 + a6 + a7 + a8 + a9

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269

  Len = 30   hh = Highest[Len] ll = Lowest[Len]   maintrend = 0 IF close > hh[1] THEN maintrend = 1 ELSIF close < ll[1] THEN maintrend = -1 ENDIF   trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a=0 IF maintrend = 1 THEN IF trend = 1 THEN a = 1 ELSE a = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a = -1 ELSE a = -1 endif endif //////////////////// hh = Highest[Len-1] ll = Lowest[Len-1] trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a1=0 IF maintrend = 1 THEN IF trend = 1 THEN a1 = 1 ELSE a1 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a1 = -1 ELSE a1 = -1 endif endif //////////////////// hh = Highest[Len-2] ll = Lowest[Len-2]   trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a2=0 IF maintrend = 1 THEN IF trend = 1 THEN a2 = 1 ELSE a2 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a2 = -1 ELSE a2 = -1 endif endif //////////////////// hh = Highest[Len-3] ll = Lowest[Len-3]   trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a3=0 IF maintrend = 1 THEN IF trend = 1 THEN a3 = 1 ELSE a3 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a3 = -1 ELSE a3 = -1 endif endif //////////////////// hh = Highest[Len-4] ll = Lowest[Len-4]   trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a4=0 IF maintrend = 1 THEN IF trend = 1 THEN a4 = 1 ELSE a4 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a4 = -1 ELSE a4 = -1 endif endif //////////////////// hh = Highest[Len-5] ll = Lowest[Len-5]   trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a5=0 IF maintrend = 1 THEN IF trend = 1 THEN a5 = 1 ELSE a5 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a5 = -1 ELSE a5 = -1 endif endif //////////////////// hh = Highest[Len-6] ll = Lowest[Len-6]   trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a6=0 IF maintrend = 1 THEN IF trend = 1 THEN a6 = 1 ELSE a6 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a6 = -1 ELSE a6 = -1 endif endif //////////////////// hh = Highest[Len-7] ll = Lowest[Len-7]   trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a7=0 IF maintrend = 1 THEN IF trend = 1 THEN a7 = 1 ELSE a7 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a7 = -1 ELSE a7 = -1 endif endif //////////////////// hh = Highest[Len-8] ll = Lowest[Len-8]   //trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a8=0 IF maintrend = 1 THEN IF trend = 1 THEN a8 = 1 ELSE a8 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a8 = -1 ELSE a8 = -1 endif endif //////////////////// hh = Highest[Len-9] ll = Lowest[Len-9]   //trend = 0 IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 ENDIF   //a9=0 IF maintrend = 1 THEN IF trend = 1 THEN a9 = 1 ELSE a9 = 1 endif endif IF maintrend = -1 THEN IF trend = -1 THEN a9 = -1 ELSE a9 = -1 endif endif   return a + a1 + a2 + a3 + a4 + a5 + a6 + a7 + a8 + a9

  As I’m not sure it is possible to achieve the same kind in graphical display (with all the plots) I wanted to replace it with a value, i.e. summing the different results.

  Any advice/help would be more than welcomed.
  Thanks.

  This is the TradinvView code

  PRT code to Translate

  // This source code is subject to the terms of the Mozilla Public License 2.0 at https://mozilla.org/MPL/2.0/ // © LonesomeTheBlue //@version=4 study("Donchian Trend Ribbon", precision = 0) dlen = input(defval = 20, title = "Donchian Channel Period", minval = 10) dchannel(len)=> float hh = highest(len) float ll = lowest(len) int trend = 0 trend := close > hh[1] ? 1 : close < ll[1] ? -1 : nz(trend[1]) dchannelalt(len, maintrend)=> float hh = highest(len) float ll = lowest(len) int trend = 0 trend := close > hh[1] ? 1 : close < ll[1] ? -1 : nz(trend[1]) maintrend == 1 ? trend == 1 ? #00FF00ff : #00FF009f : maintrend == -1 ? trend == -1 ? #FF0000ff : #FF00009f : na maintrend = dchannel(dlen) plot( 5, color = dchannelalt(dlen - 0, maintrend), style = plot.style_columns, histbase= 0) plot(10, color = dchannelalt(dlen - 1, maintrend), style = plot.style_columns, histbase= 5) plot(15, color = dchannelalt(dlen - 2, maintrend), style = plot.style_columns, histbase=10) plot(20, color = dchannelalt(dlen - 3, maintrend), style = plot.style_columns, histbase=15) plot(25, color = dchannelalt(dlen - 4, maintrend), style = plot.style_columns, histbase=20) plot(30, color = dchannelalt(dlen - 5, maintrend), style = plot.style_columns, histbase=25) plot(35, color = dchannelalt(dlen - 6, maintrend), style = plot.style_columns, histbase=30) plot(40, color = dchannelalt(dlen - 7, maintrend), style = plot.style_columns, histbase=35) plot(45, color = dchannelalt(dlen - 8, maintrend), style = plot.style_columns, histbase=40) plot(50, color = dchannelalt(dlen - 9, maintrend), style = plot.style_columns, histbase=45)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36

  // This source code is subject to the terms of the Mozilla Public License 2.0 at https://mozilla.org/MPL/2.0/ // © LonesomeTheBlue   //@version=4 study("Donchian Trend Ribbon", precision = 0) dlen = input(defval = 20, title = "Donchian Channel Period", minval = 10)   dchannel(len)=>     float hh = highest(len)     float ll = lowest(len)          int trend = 0     trend := close > hh[1] ? 1 : close < ll[1] ? -1 : nz(trend[1])      dchannelalt(len, maintrend)=>     float hh = highest(len)     float ll = lowest(len)          int trend = 0     trend := close > hh[1] ? 1 : close < ll[1] ? -1 : nz(trend[1])     maintrend == 1  ? trend == 1  ? #00FF00ff :  #00FF009f :      maintrend == -1 ? trend == -1 ? #FF0000ff :  #FF00009f :      na   maintrend = dchannel(dlen)   plot( 5, color = dchannelalt(dlen - 0, maintrend), style = plot.style_columns, histbase= 0) plot(10, color = dchannelalt(dlen - 1, maintrend), style = plot.style_columns, histbase= 5) plot(15, color = dchannelalt(dlen - 2, maintrend), style = plot.style_columns, histbase=10) plot(20, color = dchannelalt(dlen - 3, maintrend), style = plot.style_columns, histbase=15) plot(25, color = dchannelalt(dlen - 4, maintrend), style = plot.style_columns, histbase=20) plot(30, color = dchannelalt(dlen - 5, maintrend), style = plot.style_columns, histbase=25) plot(35, color = dchannelalt(dlen - 6, maintrend), style = plot.style_columns, histbase=30) plot(40, color = dchannelalt(dlen - 7, maintrend), style = plot.style_columns, histbase=35) plot(45, color = dchannelalt(dlen - 8, maintrend), style = plot.style_columns, histbase=40) plot(50, color = dchannelalt(dlen - 9, maintrend), style = plot.style_columns, histbase=45)

  

  Lavallette

  Participant

  Topics: 8

  Replies: 23

  Been thanked: 3 times
  05/13/2023 at 7:32 PM #214652
  JS

  Hi,

  Perhaps for inspiration…

  Donchian Trend Ribbon

  Once Len = 20 hh = Highest[Len](High) ll = Lowest[Len](Low) For i=0 to 9 IF close > hh[Len-i] THEN DrawRectangle(BarIndex,i,BarIndex+1,i+1)Coloured(0,255,0) //BorderColor(0,255,0) ElsIf close < ll[Len-i] then DrawRectangle(BarIndex,i,BarIndex+1,i+1)Coloured(255,0,0) //BorderColor(255,0,0) EndIf Next a=0 b=10 Return a Coloured(0,0,0), b Coloured(0,0,0)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

  Once Len = 20   hh = Highest[Len](High) ll = Lowest[Len](Low)   For i=0 to 9 IF close > hh[Len-i] THEN DrawRectangle(BarIndex,i,BarIndex+1,i+1)Coloured(0,255,0) //BorderColor(0,255,0) ElsIf close < ll[Len-i] then DrawRectangle(BarIndex,i,BarIndex+1,i+1)Coloured(255,0,0) //BorderColor(255,0,0) EndIf Next a=0 b=10 Return a Coloured(0,0,0), b Coloured(0,0,0)

  1 user thanked author for this post.

  Lavallette

  

  JS

  Participant

  Topics: 22

  Replies: 1423

  Been thanked: 557 times
  05/17/2023 at 7:53 PM #214861
  Lavallette

  JS,

  Thanks a lot for your inspiration which helped a lot.

  I came up with the below code which is almost correct I believe.

  Donchian Trend Ribbon

  Len = 20 hh = Highest[Len](High) ll = Lowest[Len](Low) IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 else trend = trend[1] ENDIF maintrend = trend For i = 0 to 9 hh = Highest[Len-i](High) ll = Lowest[Len-i](Low) IF close > hh[Len-i] THEN trend = 1 ElsIf close < ll[Len-i] then trend = -1 else trend = trend[1] EndIf if maintrend = 1 then if trend = 1 then DrawRectangle(BarIndex,i,BarIndex+1,i+1) Coloured("GREEN") BorderColor("GREEN") else DrawRectangle(BarIndex,i,BarIndex+1,i+1) Coloured("DARKGREEN") BorderColor("DARKGREEN") endif endif if maintrend = -1 then if trend = -1 then DrawRectangle(BarIndex,i,BarIndex+1,i+1) Coloured("RED") BorderColor("RED") else DrawRectangle(BarIndex,i,BarIndex+1,i+1) Coloured("DARKRED") BorderColor("DARKRED") endif endif Next Return 0 Coloured(0,0,0,0), 10 Coloured(0,0,0,0)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45

  Len = 20   hh = Highest[Len](High) ll = Lowest[Len](Low)   IF close > hh[1] THEN trend = 1 ELSIF close < ll[1] THEN trend = -1 else trend = trend[1] ENDIF   maintrend = trend     For i = 0 to 9 hh = Highest[Len-i](High) ll = Lowest[Len-i](Low)   IF close > hh[Len-i] THEN trend = 1   ElsIf close < ll[Len-i] then trend = -1   else trend = trend[1] EndIf   if maintrend = 1 then if trend = 1 then DrawRectangle(BarIndex,i,BarIndex+1,i+1) Coloured("GREEN") BorderColor("GREEN") else DrawRectangle(BarIndex,i,BarIndex+1,i+1) Coloured("DARKGREEN") BorderColor("DARKGREEN") endif endif if maintrend = -1 then if trend = -1 then DrawRectangle(BarIndex,i,BarIndex+1,i+1) Coloured("RED") BorderColor("RED") else DrawRectangle(BarIndex,i,BarIndex+1,i+1) Coloured("DARKRED") BorderColor("DARKRED") endif endif Next   Return 0 Coloured(0,0,0,0), 10 Coloured(0,0,0,0)

  I’m however still very surprised with the differences between PRT and TV.
  See screen capture as an example but I get more or less the same kind of discrepancies with all the instruments.

  Does anybody have an idea what could be the reason?

  Thanks.

  PS: If somebody confirm the code is 100% correct I could publish it to the Library but I don’t want to do it if it contains errors.

  

  Lavallette

  Participant

  Topics: 8

  Replies: 23

  Been thanked: 3 times
  05/20/2023 at 2:34 PM #214935
  Lavallette

  I believe I’m almost there with the latest version below but there is still a problem as for the same bar index the colors never change!!!

  Could anybody spot where the problem is? See image for a comparaison between the below code and TV.

  Thanks

  Latest version

  Len = 20 if barindex > Len then hh = HIGHEST[Len](HIGH) ll = LOWEST[Len] (LOW) maintrend = 0 if close > hh[1] then maintrend = 1 elsif close < ll[1] then maintrend = -1 else maintrend = maintrend[1] endif yaxis = 0 for i = 20 downto 11 do hhh = HIGHEST[i](HIGH) lll = LOWEST[i] (LOW) trend = 0 if close > hhh[1] then trend = 1 elsif close < lll[1] then trend = -1 else trend = trend[1] endIf if maintrend = 1 then if trend = 1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("GREEN") BorderColor("GREEN") elsif trend = -1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("DARKGREEN") BorderColor("DARKGREEN") endif elsif maintrend = -1 then if trend = -1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("RED") BorderColor("RED") elsif trend = 1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("DARKRED") BorderColor("DARKRED") endif endif yaxis = yaxis + 1 next endif Return 0 Coloured(0,0,0,0), 10 Coloured(0,0,0,0)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47

  Len = 20   if barindex > Len then hh = HIGHEST[Len](HIGH) ll = LOWEST[Len] (LOW)   maintrend = 0 if close > hh[1] then maintrend = 1 elsif close < ll[1] then maintrend = -1 else maintrend = maintrend[1] endif   yaxis = 0 for i = 20 downto 11 do hhh = HIGHEST[i](HIGH) lll = LOWEST[i] (LOW)   trend = 0 if close > hhh[1] then trend = 1 elsif close < lll[1] then trend = -1 else trend = trend[1] endIf   if maintrend = 1 then if trend = 1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("GREEN") BorderColor("GREEN") elsif trend = -1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("DARKGREEN") BorderColor("DARKGREEN") endif elsif maintrend = -1 then if trend = -1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("RED") BorderColor("RED") elsif trend = 1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("DARKRED") BorderColor("DARKRED") endif endif yaxis = yaxis + 1 next endif   Return 0 Coloured(0,0,0,0), 10 Coloured(0,0,0,0)

  

  Lavallette

  Participant

  Topics: 8

  Replies: 23

  Been thanked: 3 times
  05/20/2023 at 3:59 PM #214941
  JS

  Hi @Lavallette

  In the TV code, each bar is divided into 10 pieces:

  plot( 5, color = dchannelalt(dlen – 0, maintrend), style = plot.style_columns, histbase= 0)

  plot(10, color = dchannelalt(dlen – 1, maintrend), style = plot.style_columns, histbase= 5)

  plot(15, color = dchannelalt(dlen – 2, maintrend), style = plot.style_columns, histbase=10)

  plot(20, color = dchannelalt(dlen – 3, maintrend), style = plot.style_columns, histbase=15)

  plot(25, color = dchannelalt(dlen – 4, maintrend), style = plot.style_columns, histbase=20)

  plot(30, color = dchannelalt(dlen – 5, maintrend), style = plot.style_columns, histbase=25)

  plot(35, color = dchannelalt(dlen – 6, maintrend), style = plot.style_columns, histbase=30)

  plot(40, color = dchannelalt(dlen – 7, maintrend), style = plot.style_columns, histbase=35)

  plot(45, color = dchannelalt(dlen – 8, maintrend), style = plot.style_columns, histbase=40)

  plot(50, color = dchannelalt(dlen – 9, maintrend), style = plot.style_columns, histbase=45)

  Thus, each column (Bar) in the indicator consists of 10 pieces of 5 high (total 50 high). These pieces also have a different color so that you can see a difference per column (Bar)…

  In the PRT code, 1 rectangle is drawn per bar with 1 color and therefore you see no difference in color in the same bar index…

  What you can do is also make a subdivision (10 pieces) and draw a rectangle with a certain color ten times per bar…

  (Total height column is 50 divided into 10 pieces of 5)

  1 user thanked author for this post.

  Lavallette

  

  JS

  Participant

  Topics: 22

  Replies: 1423

  Been thanked: 557 times
  05/20/2023 at 5:20 PM #214947
  Lavallette

  Thanks.

  Is this not what my code does?

  10 rectangles are drawn per bar of size 1 by 1. Vertical y-axis goes from 0 to 10.
  4 Colors are possible, Green , DarkGreen, Red or DarkRed.

  This is visible on the capture below.

  But why are some rectangles on the same x-axis not of 2 different colours?!?!

  Something is obviously wrong but I cannot find what!

  Still scratching my head.

  

  Lavallette

  Participant

  Topics: 8

  Replies: 23

  Been thanked: 3 times
  05/20/2023 at 8:14 PM #214950
  JS

  Hi @Lavallette

  It’s starting to look more and more like it… 😉

  Donchian Trend Ribbon

  Len = 20 if barindex > Len then hh = (HIGHEST[Len](HIGH))[1] ll = (LOWEST[Len] (LOW))[1] maintrend = 0 if close > hh then maintrend = 1 elsif close < ll then maintrend = -1 else maintrend = maintrend[1] endif yaxis = 0 for i = 20 downto 11 do hhh = (HIGHEST[i](HIGH))[1] lll = (LOWEST[i] (LOW))[1] trend = 0 if close > hhh then trend = 1 elsif close < lll then trend = -1 else trend = trend[1] endIf if maintrend = 1 then if trend = 1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("GREEN") BorderColor("GREEN") elsif trend = -1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("DARKGREEN") BorderColor("DARKGREEN") endif elsif maintrend = -1 then if trend = -1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("RED") BorderColor("RED") elsif trend = 1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("DARKRED") BorderColor("DARKRED") endif endif yaxis = yaxis + 1 next endif Return 0 Coloured(0,0,0,0), 10 Coloured(0,0,0,0)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47

  Len = 20   if barindex > Len then hh = (HIGHEST[Len](HIGH))[1] ll = (LOWEST[Len] (LOW))[1]   maintrend = 0 if close > hh then maintrend = 1 elsif close < ll then maintrend = -1 else maintrend = maintrend[1] endif   yaxis = 0 for i = 20 downto 11 do hhh = (HIGHEST[i](HIGH))[1] lll = (LOWEST[i] (LOW))[1]   trend = 0 if close > hhh then trend = 1 elsif close < lll then trend = -1 else trend = trend[1] endIf   if maintrend = 1 then if trend = 1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("GREEN") BorderColor("GREEN") elsif trend = -1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("DARKGREEN") BorderColor("DARKGREEN") endif elsif maintrend = -1 then if trend = -1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("RED") BorderColor("RED") elsif trend = 1 then DrawRectangle(BarIndex,yaxis,BarIndex+1,yaxis+1) Coloured("DARKRED") BorderColor("DARKRED") endif endif yaxis = yaxis + 1 next endif   Return 0 Coloured(0,0,0,0), 10 Coloured(0,0,0,0)

  

  JS

  Participant

  Topics: 22

  Replies: 1423

  Been thanked: 557 times
  05/21/2023 at 10:22 AM #214972
  Lavallette

  @SJ Thanks again for your time.

  I don’t understand why

  hhh = (HIGHEST[i](HIGH))[1]

  1	hhh = (HIGHEST[i](HIGH))[1]

  is different from

  hhh = HIGHEST[i](HIGH)

  1	hhh = HIGHEST[i](HIGH)

  and then referencing it with

  hhh[1]

  1

  hhh[1]

  I would have thought it would be the same. Could this be a bug?

  Your latest version gives better result but still as you can see not completely correct.https://www.tradingview.com/script/PxLqmP8o-Donchian-Trend-Ribbon/

  Could it be that way the “for loop” manages the hhh and lll series?

  In case you still want to spend some time on this thread you can test it as well from https://www.tradingview.com/script/PxLqmP8o-Donchian-Trend-Ribbon/ .

   

  Anyway thanks a lot.

  

  Lavallette

  Participant

  Topics: 8

  Replies: 23

  Been thanked: 3 times
• Author
  Posts