Error codeing MACD crossover happens with 26 & 52 period EMA

• 07/27/2020 at 4:24 AM #140161
  Rajesh Deshpande

  Hi ,

  I am new to PRorealtime. Thank you GURU’s for reading the topic.

  I am trying to build a code where in when MACD crossover happens with 26 & 52 period EMA.

  // Conditions to enter long positions defparam CUMULATEORDERS = false //macdline c2 = MACDline[ 26 , 52, 12 ](close) //signalline c3 = ExponentialAverage[12](c2) //histogram heigt histbar = c2 – c3 c5 = histbar crosses over 0 c6 = histbar crosses under 0 IF NOT LongOnMarket AND c5 THEN BUY 1 CONTRACTS AT MARKET sl = lowest[3](low) set stop loss sl tgt = ( POSITIONPRICE – SL ) * 1.5 set target $profit tgt ENDIF // Conditions to exit long positions // Conditions to enter short positions IF NOT ShortOnMarket AND c6 THEN SELLSHORT 1 CONTRACTS AT MARKET sl = highest[3](high) set stop loss sl tgt = ( sl – POSITIONPRICE ) * 1.5 set target $profit tgt ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31

  // Conditions to enter long positions defparam CUMULATEORDERS = false   //macdline c2 = MACDline[ 26 , 52, 12 ](close) //signalline c3 = ExponentialAverage[12](c2)   //histogram heigt histbar = c2 – c3 c5 = histbar crosses over 0 c6 = histbar crosses under 0   IF NOT LongOnMarket AND c5 THEN BUY 1 CONTRACTS AT MARKET sl = lowest[3](low) set stop loss sl tgt = ( POSITIONPRICE – SL ) * 1.5 set target $profit tgt ENDIF   // Conditions to exit long positions   // Conditions to enter short positions IF NOT ShortOnMarket AND c6 THEN SELLSHORT 1 CONTRACTS AT MARKET sl = highest[3](high) set stop loss sl tgt = ( sl – POSITIONPRICE ) * 1.5 set target $profit tgt ENDIF

  The above code is not setting up the Stop loss & targets. The stop loss should be lowest of last three candles when going long & highest when shorting.

  Also i notice that order is place after 2 candles are formed delaying the entry of the order.

  Can anyone help what is wrong in the code.

   

  

  Rajesh Deshpande

  Participant

  Topics: 1

  Replies: 0

  Been thanked: 0 times
  07/27/2020 at 8:38 AM #140164
  robertogozzi

  • Give your topic a meaningful title.Describe your question or your subject in your title. Do not use meaningless titles such as ‘Coding Help Needed’.
  • Always use the ‘Insert PRT Code’ button when putting code in your posts to make it easier for others to read.

  Thank you 🙂

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16483

  Been thanked: 3648 times
  07/27/2020 at 8:48 AM #140168
  robertogozzi

  SET STOP LOSS and SET TARGET PROFIT require a difference between prices (Close – Low), not a price (Low).

  Replace lines 16-19  as follows:

  sl = abs(close-lowest[3](low)) set stop loss sl tgt = SL * 1.5 set target profit tgt

  1 2 3 4

  sl = abs(close-lowest[3](low)) set stop loss sl tgt = SL * 1.5 set target profit tgt

  do the same for the Short side using HIGHEST.

  Do not use $ for PROFIT, it’s intended for currency values, such as 400 etc…

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16483

  Been thanked: 3648 times
• Author
  Posts