Draw a rectangle each day between 00:00 and 07:00

• 01/23/2017 at 9:32 PM #22207
  H_Miller

  Good evening,

  I am new to ProRealCode and would like to understand where I am wrong.

  I need to draw a rectangle each day from 00:00 to 07:00  where Y1/Y2 are low/high for the same time frame.

  If I uncomment line 1 (defparam drawonlastbaronly=true) it works fine on last day.

  Uncommenting this line causes the rectangle to be drawn for all periods and I don’t realise why.

  Any help is really appreciated.

  Thanks

  Giovanni

  PS I attach screenshot of the actual wrong visualisation.

   

   

  //defparam drawonlastbaronly = true if intradaybarindex=0 then maxvalue=0 minvalue=close*5 x1=0 x2=0 endif timerange = time>=000000 and time<=070000 if timerange then maxvalue = max(maxvalue , high) minvalue = min(minvalue , low) if time=010000 then x1=barindex endif if time=070000 then x2=barindex endif endif DRAWRECTANGLE(x1,maxvalue,x2,minvalue) RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20

  //defparam drawonlastbaronly = true if intradaybarindex=0 then maxvalue=0 minvalue=close*5 x1=0 x2=0 endif timerange = time>=000000 and time<=070000 if timerange  then maxvalue = max(maxvalue , high) minvalue = min(minvalue , low) if time=010000 then x1=barindex endif if time=070000 then x2=barindex endif endif DRAWRECTANGLE(x1,maxvalue,x2,minvalue) RETURN

   

   

   

  

  H_Miller

  Participant

  Topics: 3

  Replies: 4

  Been thanked: 0 times
  01/24/2017 at 11:11 AM #22234
  Nicolas

  In fact this is not a problem, because your result give you exactly what you have coded.

  If you don’t use the ‘drawonlastbaronly’ function, the code is read and executed while the history is read at the first time. As you may already know, prorealtime only read once the history and drawn things on chart can’t be erased.

  So, in order to draw correctly the rectangles in your chart history, you’ll need to begin and end drawing them, once the last schedule (X coordinates = barindex) has already passed.

  Another possibility could be to use the ‘drawonlastbaronly’ and make loop through the past data, but it would be memory consuming for the platform.

  But if I understand correctly what you want to achieve here, is to draw the current rectangle (the one for the current day) and the ones from previous day also?

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4738 times
  01/25/2017 at 1:39 PM #22423
  H_Miller

  Thank you Nicolas,

  I amended  the code as you explained  and now it’s working fine .

  The only issue is that it worked after restarting my PC, without changing any line of code at all.

  I then tried to add a background to the rectangle but there is no way to do it, as far as I know.

  Thank you Nicolas!

   

   

  //defparam drawonlastbaronly = true if intradaybarindex=0 then maxvalue=0 minvalue=Dclose(0)*5 endif timerange = time>000000 and time<=070000 if timerange then maxvalue = max(maxvalue , high) minvalue = min(minvalue , low) if intradaybarindex=0 then x1=barindex endif if time=070000 then x2=barindex DRAWRECTANGLE(x1,maxvalue,x2,minvalue) coloured(10,255,10,255) endif endif RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

  //defparam drawonlastbaronly = true if intradaybarindex=0 then maxvalue=0 minvalue=Dclose(0)*5 endif timerange = time>000000 and time<=070000 if timerange  then maxvalue = max(maxvalue , high) minvalue = min(minvalue , low) if intradaybarindex=0 then x1=barindex endif if time=070000 then x2=barindex DRAWRECTANGLE(x1,maxvalue,x2,minvalue) coloured(10,255,10,255) endif endif   RETURN

   

  

  H_Miller

  Participant

  Topics: 3

  Replies: 4

  Been thanked: 0 times
  03/30/2018 at 12:11 AM #66741
  crolakstrading

  i wanted to change this box to 4am to 7am i tried below,

  if intradaybarindex=0 then maxvalue=0 minvalue=Dclose(0)*5 endif timerange = time>=040000 and time<=080000 if timerange then maxvalue = max(maxvalue , high) minvalue = min(minvalue , low) if intradaybarindex=0 then x1=barindex endif if time=080000 then x2=barindex DRAWRECTANGLE(x1,maxvalue,x2,minvalue) coloured(70,130,190) endif endif RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18

  if intradaybarindex=0 then maxvalue=0 minvalue=Dclose(0)*5 endif timerange = time>=040000 and time<=080000 if timerange  then maxvalue = max(maxvalue , high) minvalue = min(minvalue , low) if intradaybarindex=0 then x1=barindex endif if time=080000 then x2=barindex DRAWRECTANGLE(x1,maxvalue,x2,minvalue) coloured(70,130,190) endif endif   RETURN

  but it didnt do anything any reason why???

  

  crolakstrading

  Participant

  Topics: 10

  Replies: 97

  Been thanked: 2 times
  03/30/2018 at 8:00 AM #66753
  robertogozzi

  It’s because line 9 will never be true after 000000.

  Insert a new line between 3 and 4 which reads

  MyBar=0

  1

  MyBar=0

  then at line 9 (now line 10) replace intradaybarindex with MyBar

  if MyBar=0 then

  1	if MyBar=0 then

  and, finally, insert a line before or after line 10 (now line 11)

  MyBar=1

  1

  MyBar=1

   

   

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16455

  Been thanked: 3636 times
  03/30/2018 at 8:03 AM #66754
  Nicolas

  @crolakstrading

  There was an ENDIF wrongly placed in the code. The X1 coordinate was not correctly found, here is the code fixed:

  if intradaybarindex=0 then maxvalue=0 minvalue=Dclose(0)*5 endif timerange = time>=040000 and time<=080000 if timerange then maxvalue = max(maxvalue , high) minvalue = min(minvalue , low) endif if intradaybarindex=0 then x1=barindex endif if time=080000 then x2=barindex DRAWRECTANGLE(x1,maxvalue,x2,minvalue) coloured(70,130,190) endif RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

  if intradaybarindex=0 then maxvalue=0 minvalue=Dclose(0)*5 endif timerange = time>=040000 and time<=080000 if timerange  then maxvalue = max(maxvalue , high) minvalue = min(minvalue , low) endif if intradaybarindex=0 then x1=barindex endif if time=080000 then x2=barindex DRAWRECTANGLE(x1,maxvalue,x2,minvalue) coloured(70,130,190) endif     RETURN

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4738 times
  03/30/2018 at 8:07 AM #66756
  robertogozzi

  Well Nicolas, that would partially do, you’ll have a rectangle displayed also for hours BEFORE 040000.

  I think the problem was the one I posted about.

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16455

  Been thanked: 3636 times
  03/30/2018 at 8:10 AM #66757
  robertogozzi

  To recap :

  if intradaybarindex=0 then maxvalue=0 minvalue=Dclose(0)*5 MyBar=0 endif timerange = time>=040000 and time<=080000 if timerange then maxvalue = max(maxvalue , high) minvalue = min(minvalue , low) if MyBar=0 then x1=barindex MyBar=1 endif if time=080000 then x2=barindex DRAWRECTANGLE(x1,maxvalue,x2,minvalue) coloured(70,130,190) endif endif RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

  if intradaybarindex=0 then    maxvalue=0    minvalue=Dclose(0)*5    MyBar=0 endif timerange = time>=040000 and time<=080000 if timerange  then    maxvalue = max(maxvalue , high)    minvalue = min(minvalue , low)    if MyBar=0 then       x1=barindex       MyBar=1    endif    if time=080000 then       x2=barindex       DRAWRECTANGLE(x1,maxvalue,x2,minvalue) coloured(70,130,190)    endif endif RETURN

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16455

  Been thanked: 3636 times
  04/03/2018 at 3:15 PM #67036
  crolakstrading

  Thank you both! @robertogozzi & @Nicolas

  

  crolakstrading

  Participant

  Topics: 10

  Replies: 97

  Been thanked: 2 times
• Author
  Posts