Code of series of periods

• 07/06/2018 at 1:04 PM #75475
  maximus78

  Good morning,

  is there anybody who knows if there’s an easier way to write this code, in which the actual close is > or < of a series of previous close like this?

  close>close[1] and close>close[2] and close>close[3] and close>close[4] and close>close[5]....

  1	close>close[1] and close>close[2] and close>close[3] and close>close[4] and close>close[5]....

  I need to put in a backtest with a variable X,  that is the last of the series,

  if X is 5 then .....close>close[1] and close>close[2]....till close>close[5]

  1	if X is 5 then .....close>close[1] and close>close[2]....till close>close[5]

  Thanks so much

  Maxx

  

  maximus78

  Participant

  Topics: 30

  Replies: 165

  Been thanked: 33 times
  07/06/2018 at 1:36 PM #75477
  Vonasi

  x = 5 count = 0 for i = 1 to x if close > close[i] then count = count + 1 endif next if count = x then

  1 2 3 4 5 6 7 8 9 10

  x = 5   count = 0 for i = 1 to x if close > close[i] then count = count + 1 endif next   if count = x then

  EDIT: Code is now corrected as discussed further down in this thread.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  07/06/2018 at 1:56 PM #75480
  robertogozzi

  What about

  IF close > highest[5](close[1]) THEN...

  1	IF close > highest[5](close[1]) THEN...

  ?

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16465

  Been thanked: 3641 times
  07/06/2018 at 2:39 PM #75482
  Vonasi

  As usual I make the job harder than it needs to be! 🙂

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  07/06/2018 at 2:42 PM #75484
  Nicolas

  As for the Vonasi’s code, ‘count’ variable should be reset to 0 before the FOR/NEXT loop, otherwise it will endlessly increase.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4739 times
  07/06/2018 at 5:46 PM #75491
  Vonasi

  Nicolas wrote:

  As for the Vonasi’s code, ‘count’ variable should be reset to 0 before the FOR/NEXT loop, otherwise it will endlessly increase.

  So not only harder but it doesn’t work! Why do in one line what you can do in 8. I blame it on the heat…..

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  07/06/2018 at 6:52 PM #75498
  GraHal

  But don’t both code options fail to give the OP what he wants?

  OP wanted close of bar 1 > close of bar 2 and close of bar 2 > Close of bar 3 etc … put another way 5 bars with a increasing value of Close?

  

  GraHal

  Participant

  Topics: 204

  Replies: 8399

  Been thanked: 2041 times
  07/06/2018 at 7:02 PM #75500
  Vonasi

  GraHal wrote:

  OP wanted close of bar 1 > close of bar 2 and close of bar 2 > Close of bar 3 etc … put another way 5 bars with a increasing value of Close?

  That is not what he wrote – he wrote this:

  close>close[1] and close>close[2] and close>close[3] and close>close[4] and close>close[5]....

  1	close>close[1] and close>close[2] and close>close[3] and close>close[4] and close>close[5]....

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  07/06/2018 at 7:03 PM #75501
  robertogozzi

  He always compared CLOSE, not CLOSE[previous bar].

  Anyway, that would be

  IF summation[5](close > close[1]) = 5 THEN....

  1	IF summation[5](close > close[1]) = 5 THEN....

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16465

  Been thanked: 3641 times
  07/06/2018 at 7:11 PM #75502
  GraHal

  Vonasi wrote:

  That is not what he wrote – he wrote this:

  Hahaha the heat is getting to all of us, I got it locked in my mind from initial reading  (I should have reread) that he wanted an increasing value of close.

  Cheers

  

  GraHal

  Participant

  Topics: 204

  Replies: 8399

  Been thanked: 2041 times
  07/06/2018 at 7:13 PM #75503
  Vonasi

  …. and I first wrote that summation code that Robert just posted but then deleted my post when I realised my mistake and then went on to post a very complicated method that didn’t work! It is definitely the heat.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  07/06/2018 at 8:56 PM #75507
  maximus78

  Thanks guys for the replies,  yes Roberto’s code is correct, I have verified.

  My mind was blocked too….actually it was so simple!

  Maxx

  

  maximus78

  Participant

  Topics: 30

  Replies: 165

  Been thanked: 33 times
  07/07/2018 at 7:34 AM #75516
  GraHal

  robertogozzi wrote:

  CLOSE[previous bar]. Anyway, that would be

  Code added to Snippet Link Library

  

  GraHal

  Participant

  Topics: 204

  Replies: 8399

  Been thanked: 2041 times
  08/04/2019 at 1:52 PM #104152
  robertogozzi

  Sorry for reviving this old topic, but after thinking it over and with a whole additional year experience… VONASI was right (apart from resetting count to 0 at line 2 as suggested by Nicolas).

  My code always compares the current candle to the previous one, which is not exactly what maximus78 wanted. Indeed I believed using CLOSE without brackets would do, but summation reads it as being CLOSE[0], then it shifts both every iteration, so that the next one would be CLOSE[1] compared to CLOSE[2] and so on. CLOSE does NOT remain CLOSE[0] thus making a loop necessary.

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16465

  Been thanked: 3641 times
  08/04/2019 at 2:29 PM #104154
  Vonasi

  robertogozzi wrote:

  VONASI was right

  Finally almost thirteen months later I get the recognition that I deserve. I’ve had trouble sleeping at night ever since I posted something that was thought to be wrong. Thank goodness that nightmare is now over. 🙂

  Strangely maximus78 was happy with your code Roberto so perhaps what he wanted and what he described were actually different things? It wouldn’t be the first time someone did that on the forums!

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
• Author
  Posts