code inside bar-trade

• 12/03/2023 at 9:15 PM #224779
  kimmen

  Hello.

  I am trying to code a trading system based on inside bar. I have created an own indicator that gives 1 when an inside bar appears within my margins. With this code it is only taking trades for the upside. If the inside-bar indicator gives 1 i want to set an stop order att the high of the mother-bar and a stoploss at the low of the mother-bar.

  Question 1

  When i probacktest, it is not taking a trade every time, only sometimes. And i dont understand why?

  Question 2

  If i want it to make pending-orders both at the uppside and downside until one will be activated, can i do it with two tradingsystems? I guess i just can put one order at once in one trading-system.

  

  kimmen

  Participant

  Topics: 1

  Replies: 5

  Been thanked: 0 times
  12/03/2023 at 9:21 PM #224781
  kimmen

  //status of the indicator indicatoractive = CALL "kims inside bar"[80, 11, 4] //Pending-order, pendingorder=1 make the order active more than 1 bar, until it become zero If indicatoractive=1 and pendingorder=0 and not ONMARKET then pendingorder=1 pipsloose=(high[1]-low[1])*10000 entry=high[1] pipsgain=(high[1]-low[1])*10000 elsif pendingorder=1 and not onmarket then buy 16 contracts at entry stop SET STOP pLOSS pipsloose SET TARGET pPROFIT pipsgain loose=low[1] elsif pendingorder=1 and high[0]>=entry or pendingorder=1 and low[0] <=loose or onmarket then pendingorder=0 endif

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24

  //status of the indicator indicatoractive = CALL "kims inside bar"[80, 11, 4]     //Pending-order, pendingorder=1 make the order active more than 1 bar, until it become zero   If indicatoractive=1 and pendingorder=0 and not ONMARKET  then pendingorder=1   pipsloose=(high[1]-low[1])*10000 entry=high[1] pipsgain=(high[1]-low[1])*10000 elsif pendingorder=1 and not onmarket then buy 16 contracts at entry stop SET STOP pLOSS pipsloose SET TARGET pPROFIT pipsgain   loose=low[1]     elsif pendingorder=1 and high[0]>=entry or pendingorder=1 and low[0] <=loose or onmarket then pendingorder=0 endif

   

  

  kimmen

  Participant

  Topics: 1

  Replies: 5

  Been thanked: 0 times
  12/04/2023 at 10:20 AM #224795
  robertogozzi

  You should port the indicator as well, to be able to test the code.

  In line 15, you are using a STOP order which means that the current price is LOWER than the entry price, is that always the case?

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16469

  Been thanked: 3643 times
  12/05/2023 at 9:22 PM #224906
  kimmen

  as it is an inside bar trade, the daughter bar must be lower than the mother bar that sets the stop order level and then the price is always below my stop order. But you are right, a gap can appear between bars. I could enter that stop order is placed for example 1 pips above the mother bar high to cover this. Do you have any better suggestions?

  

  kimmen

  Participant

  Topics: 1

  Replies: 5

  Been thanked: 0 times
  12/05/2023 at 9:27 PM #224907
  kimmen

  here comes the indicator for the trade

  //Definition of motherbar and doughterbar as high and low Motherbarhigh = high [1] Motherbarlow = low [1] Doughterbarhigh = high Doughterbarlow = low //Difinition of the motherbar opening and closing Motherbaropen = open [1] Motherbarclose = close [1] //sizemotherbody is a limit on how big the body in the bar should be set in percentage units. sizemotherbody=80 //max limit on how big the motherbar can be and should be set in pips maxmotherbar=11 //min-limit is set on how small the motherbar can be and should be set in pips minmotherbar=4 //motherbody up and down are the bodies percent of the bar in decimal form. motherbodyup = (motherbarclose - motherbaropen)/(motherbarhigh-motherbarlow) motherbodydown = (motherbaropen - motherbarclose)/ (motherbarhigh-motherbarlow) //if statement where validity if the body of the motherbar is large enough is determined if motherbodyup>sizemotherbody/100 or motherbodydown>sizemotherbody/100 then bodyvaild=1 else bodyvaild=0 endif //if statement where a max limit is set on how big the motherbar can be. if motherbarhigh-motherbarlow<maxmotherbar/10000 then maxbarvaild = 1 else maxbarvaild=0 endif //if statement where min-limit is set on how small the motherbar can be. if motherbarhigh-motherbarlow>minmotherbar/10000 then minbarvaild = 1 else minbarvaild=0 endif //if the motherbar is greater than the doughterbar and the body in the motherbar is greater than the limit value bodyvaild and the bar is not greater than the limit value maxbarvaild and the bar is not less than the limit value minbarvaild, becomes results=1 If Motherbarhigh > Doughterbarhigh and Motherbarlow < Doughterbarlow and bodyvaild=1 and maxbarvaild=1 and minbarvaild=1 Then results = 1 else results=0 Endif //sending the results to the indicator return results

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57

  //Definition of motherbar and doughterbar as high and low Motherbarhigh = high [1] Motherbarlow = low [1]   Doughterbarhigh = high Doughterbarlow = low   //Difinition of the motherbar opening and closing Motherbaropen = open [1] Motherbarclose = close [1]   //sizemotherbody is a limit on how big the body in the bar should be set in percentage units. sizemotherbody=80   //max limit on how big the motherbar can be and should be set in pips maxmotherbar=11   //min-limit is set on how small the motherbar can be and should be set in pips minmotherbar=4   //motherbody up and down are the bodies percent of the bar in decimal form. motherbodyup = (motherbarclose - motherbaropen)/(motherbarhigh-motherbarlow) motherbodydown = (motherbaropen - motherbarclose)/ (motherbarhigh-motherbarlow)     //if statement where validity if the body of the motherbar is large enough is determined if motherbodyup>sizemotherbody/100 or motherbodydown>sizemotherbody/100 then bodyvaild=1 else bodyvaild=0 endif   //if statement where a max limit is set on how big the motherbar can be. if motherbarhigh-motherbarlow<maxmotherbar/10000 then maxbarvaild = 1 else maxbarvaild=0 endif   //if statement where min-limit is set on how small the motherbar can be. if motherbarhigh-motherbarlow>minmotherbar/10000 then minbarvaild = 1 else minbarvaild=0 endif   //if the motherbar is greater than the doughterbar and the body in the motherbar is greater than the limit value bodyvaild and the bar is not greater than the limit value maxbarvaild and the bar is not less than the limit value minbarvaild, becomes results=1     If Motherbarhigh > Doughterbarhigh and Motherbarlow < Doughterbarlow and bodyvaild=1 and maxbarvaild=1 and minbarvaild=1 Then results = 1 else results=0 Endif   //sending the results to the indicator return results

   

  

  kimmen

  Participant

  Topics: 1

  Replies: 5

  Been thanked: 0 times
  12/05/2023 at 9:31 PM #224908
  kimmen

  i forgot to say i am trying to get it working on EUR/USD 5 min chart

  

  kimmen

  Participant

  Topics: 1

  Replies: 5

  Been thanked: 0 times
  12/06/2023 at 12:44 AM #224910
  JS

  Hi @kimmen

  Try this one:

   

  Kims Inside Bar System

  //status of the indicator IndicatorActive = CALL "kims inside bar"[80,11,4] //Pending-order, pendingorder=1 make the order active more than 1 bar, until it become zero If IndicatorActive=1 and not ONMARKET then PendingOrder=1 pipsLoose=(high[1]-low[1])*10000 Entry=high[1] Loose=low[1] pipsGain=(high[1]-low[1])*10000 EndIf If PendingOrder=1 and not onmarket then buy 16 contracts at entry stop SET STOP pLOSS pipsLoose SET TARGET pPROFIT pipsGain EndIf If PendingOrder=1 and High[0]>=Entry or PendingOrder=1 and Low[0]<=Loose or OnMarket then PendingOrder=0 EndIf

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22

  //status of the indicator IndicatorActive = CALL "kims inside bar"[80,11,4] //Pending-order, pendingorder=1 make the order active more than 1 bar, until it become zero If IndicatorActive=1 and not ONMARKET  then PendingOrder=1   pipsLoose=(high[1]-low[1])*10000 Entry=high[1] Loose=low[1] pipsGain=(high[1]-low[1])*10000 EndIf   If PendingOrder=1 and not onmarket then buy 16 contracts at entry stop SET STOP pLOSS pipsLoose SET TARGET pPROFIT pipsGain EndIf   If PendingOrder=1 and High[0]>=Entry or PendingOrder=1 and Low[0]<=Loose or OnMarket then PendingOrder=0 EndIf

  2 users thanked author for this post.

  kimmen, robertogozzi

  

  JS

  Participant

  Topics: 22

  Replies: 1423

  Been thanked: 557 times
  12/07/2023 at 12:37 PM #224989
  kimmen

  Thanks for the help. Now it works much better. However, I don’t understand why it sometimes skips trades. For example as in the picture I am attaching, EUR/USD 5 min chart, 2023-12-07 at 09:30 and 10:25. The indicator shows 1 but it only trades on the first opportunity and skips the second.

  The changes you made that I can see is that you removed pendingorder=0 in my first if statement where I wrote: If indicatoractive=1 and pendingorder=0 and not ONMARKET then pending order=1.  Now it works better, but this probably means that pipsLoose,Entry,Loose,pipsGain changes every bar when the indicator is active until the price passes the stop order and a deal is made. Or is  “onmarket” counted already when the stop order is placed on the market? The indicator can show 1 for several bars but I want the pipsLoose,Entry,Loose,pipsGain levels to be set only after the first time. How can i fix this issue?

  thanks again for the help

  

  kimmen

  Participant

  Topics: 1

  Replies: 5

  Been thanked: 0 times
• Author
  Posts