Bizarre looping problem

• 08/21/2019 at 11:31 AM #105184
  Grantx

  This is bizarre. I basically want to get the average of the last x amount of bars.

  Even when I set the loop to 1 it doesnt calculate properly.

  Pseudo code should be something like this:

  1. Go back 10 bars and add up all the bar ranges
  2. Divide the total amount by the lookbackperiod when the loop has completed

   

  The calculations are completely incorrect. Im stuck as I cant see anything wrong with the code. Line 15 seems to be the problem but why?

  Note: I am running this on the m6e futures which is why I multiply by 10000

  Looping bar range

  //Grantx defparam drawonlastbaronly=true //--- settings Loockbackperiod = 10 //--- end of settings RngeSum = 0 largestBar = 0 FOR i = 0 TO Loockbackperiod DO if (Range[i]>largestBar) THEN largestBar = Range[i] ENDIF RngeSum = RngeSum + Range[i] NEXT //RngeSum = Round((RngeSum / Loockbackperiod)*10000) RngeSum = Round(RngeSum*10000) largestBar = largestBar*10000 drawtext(" ABR(#Loockbackperiod#) = #RngeSum# ¬ LB = #largestBar#",barindex,High,Dialog,Standard,10) coloured(0,0,255) RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23

  //Grantx   defparam drawonlastbaronly=true   //--- settings Loockbackperiod = 10 //--- end of settings   RngeSum = 0 largestBar = 0 FOR i = 0 TO Loockbackperiod DO if (Range[i]>largestBar) THEN largestBar = Range[i] ENDIF RngeSum = RngeSum + Range[i] NEXT //RngeSum = Round((RngeSum / Loockbackperiod)*10000) RngeSum = Round(RngeSum*10000) largestBar = largestBar*10000   drawtext("                                                                                            ABR(#Loockbackperiod#) = #RngeSum# ¬ LB = #largestBar#",barindex,High,Dialog,Standard,10) coloured(0,0,255)   RETURN

   

  

  Grantx

  Participant

  Topics: 23

  Replies: 23

  Been thanked: 3 times
  08/21/2019 at 11:41 AM #105185
  GraHal

  Does below (for Lines 9 and 10) make any difference?

  ONCE RngeSum = 0 ONCE largestBar = 0

  1 2	ONCE RngeSum = 0 ONCE largestBar = 0

   

  1 user thanked author for this post.

  Grantx

  

  GraHal

  Participant

  Topics: 203

  Replies: 8374

  Been thanked: 2024 times
  08/21/2019 at 11:58 AM #105186
  robertogozzi

  You are summing up 11 bars (0 – 10), not 10.

  will

  LookBackPeriod = 10 AverageRange = summation[LookBackPeriod](range) / LookBackPeriod

  1 2	LookBackPeriod = 10 AverageRange   = summation[LookBackPeriod](range) / LookBackPeriod

  do?

  1 user thanked author for this post.

  Grantx

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16450

  Been thanked: 3634 times
  08/21/2019 at 12:29 PM #105188
  Grantx

  Yep. This works. Thank you!

  Also, thanks @GraHal for replying.

  Much appreciated.

  

  Grantx

  Participant

  Topics: 23

  Replies: 23

  Been thanked: 3 times
• Author
  Posts