: Forum PRC williams' high and low indicator

05/22/2018 at 8:34 AM #71069

robertogozzi

Sorry Nicolas, but it doesn’t work either.

This is the original code I modified to display ONLY arrows that are circled. I only moved the DRAWARROWUP/DRAWARROWDOWN lines to the line following DRAWELLIPSE (and commented out this one), I also commented out the DRAWCANDLE line at the bottom, plus I had to comment out some variables used to drawellipses. This code is working as you can see from indicator box 3, since it displays ONLY those arrows that are circled on the price chart.

But, if instead of drawing an arrov a simply set x=1 when it’s an upward arrow and x=-1 when it’s the other way round, it does not work! With initial x=0 the result is box 1, without x=0 (or setting just ONCE x=0) the result is the histogram in box 2. In either cases it’s wrong.

I am wondering why replacing a DRAWARROWUP with x=1 produces odd results.

I also tried to set DEFPARAM CalculateOnLastBars = 1000 (from 300), but that’s not the problem I guess, since the original version on the price chart still has 300 as a bar limit.

DEFPARAM CalculateOnLastBars = 1000
//computation of the radius to draw ellipses
//radius=average[200](range)/4
//if golong=1 then
//golong=0
//endif
//formula to compute short term swing points
if (high>alto[1]) and not (high<high[1] and low>low[1]) then
alto=high
basso=low
markup=barindex
markhigh=high
endif
if (low<basso[1]) and not (high<high[1] and low>low[1]) then
alto=high
basso=low
markdown=barindex
marklow=low
endif
 
if alto<alto[1] and trend=1 then
trend=0
//drawarrowdown(markup,markhigh)
mediummarkup=shortmarkup
shortmarkup=markup
longmarkhigh=mediummarkhigh
mediummarkhigh=shortmarkhigh
shortmarkhigh=markhigh
//intermediate high swing points
if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then
//DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius)
drawarrowdown(mediummarkup,markhigh)
endif
endif
 
if basso>basso[1] and trend=0 then
trend=1
//drawarrowup(markdown,marklow)
mediummarkdown=shortmarkdown
shortmarkdown=markdown
longmarklow=mediummarklow
mediummarklow=shortmarklow
shortmarklow=marklow
//intermediate low swing points
if longmarklow>mediummarklow and mediummarklow<shortmarklow then
//DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius)
drawarrowup(mediummarkdown,marklow)
endif
endif
 
 
//drawcandle(open,high,low,close)
return

DEFPARAM CalculateOnLastBars = 1000

//computation of the radius to draw ellipses

//radius=average[200](range)/4

//if golong=1 then

//golong=0

//endif

//formula to compute short term swing points

if (high>alto[1]) and not (high<high[1] and low>low[1]) then

alto=high

basso=low

markup=barindex

markhigh=high

endif

if (low<basso[1]) and not (high<high[1] and low>low[1]) then

alto=high

basso=low

markdown=barindex

marklow=low

endif

if alto<alto[1] and trend=1 then

trend=0

//drawarrowdown(markup,markhigh)

mediummarkup=shortmarkup

shortmarkup=markup

longmarkhigh=mediummarkhigh

mediummarkhigh=shortmarkhigh

shortmarkhigh=markhigh

//intermediate high swing points

if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then

//DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius)

drawarrowdown(mediummarkup,markhigh)

endif

if basso>basso[1] and trend=0 then

trend=1

//drawarrowup(markdown,marklow)

mediummarkdown=shortmarkdown

shortmarkdown=markdown

longmarklow=mediummarklow

mediummarklow=shortmarklow

shortmarklow=marklow

//intermediate low swing points

if longmarklow>mediummarklow and mediummarklow<shortmarklow then

//DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius)

drawarrowup(mediummarkdown,marklow)

endif

//drawcandle(open,high,low,close)

return

robertogozzi

Moderator

Topics: 69

Replies: 16462

Been thanked: 3638 times