understanding the zigzag indicator

• 10/04/2018 at 7:12 AM #81879
  chris

  hello

  the last chapter of the advanced programming course is creating a complete zigzag indicator and I would like to clarify my understanding of how the code (copied below) works.

  The parts I would like to unpack are determining the percentage variation which is then compared to the defined % variation (specified or dynamically).

  Peakpercent = (higher – close)/higher

  troughpercent = (close-lower)/lower

  Taking the peakpercent, it seems higher is being compared to the current close rather than the close of the last trough?  Any explanation or insight would be greatly appreciated.

  thanks

  Chris

  

  chris

  Participant

  Topics: 6

  Replies: 5

  Been thanked: 0 times
  10/04/2018 at 7:36 AM #81881
  Vonasi

  Please use the ‘Insert PRT Code’ button when posting code in the forums as it makes it far easier for others to read. I have tidied up your last post for you. 🙂

  1 user thanked author for this post.

  chris

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  10/04/2018 at 12:57 PM #81913
  Nicolas

  Chris, I deleted the code from your post. This one is only available for the people who have bought the course 😉

  To detect that a new peak has formed, the higher price must be compared to the current Close. If it has achieved a retracement of X percent, the peak is confirmed.

  1 user thanked author for this post.

  chris

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20828

  Been thanked: 4739 times
  10/07/2018 at 7:20 AM #82175
  chris

  thanks Nicolas

  I have attempted run myzigzag in ProOrder & backtest it – after modifying the indicator to remove the draw commands, it does run though the system is opening & closing on every bar.  Without loading the code on a public forum, what’s the best way to obtain some assistance to troubleshoot this? regards, Chris

  

  chris

  Participant

  Topics: 6

  Replies: 5

  Been thanked: 0 times
• Author
  Posts