Tweaking divergence code
-
Hello everybody… I wonder if you could help me?
I have some divergence code that looks back a certain number of bars which seems to work okay when I’m comparing a current low that is lower than a previous low, but doesn’t work so well when a current low is higher than a previous low.
My graph command tells me that ‘priorlow’ is 13,801.3 which is nearly a hundred bars back from the current low (the lows are labelled on screengrab), and yet the code only permits a lookback of 30 bars.
I’m wondering if this also has something to do with a market that is constantly rising, but that is just a guess.
Does anyone know how to solve this?
Thank you in advance.
DEFPARAM CumulateOrders = False back=30 longhigherlow=0 CurLow = lowest[back/2](low) IF low = CurLow THEN PriorLow = lowest[back](low[back]) CurMACD = MACD[12,26,9](close) FOR i = 0 TO (back - 1) IF low[i + back] = PriorLow THEN PriorMACD = MACD[12,26,9](close)[i + back] PriorBAR = BarIndex[i + back] Break ENDIF NEXT ENDIF macconflong= CurMACD < PriorMACD c1 = Curlow > PriorLow c2 = Curlow =lowest[3](low) c3 = close < ExponentialAverage[5](high) and close > ExponentialAverage[5](low) c6 = macconflong longhigherlow= c1 and c2 and c3 and c6 Limitbuy=close-5 if not onmarket and longhigherlow=1 then sl=abs(close-lowest[5](low))*Vlstop tp=sl * VLtake Set target profit tp Set stop loss sl BUY 1 PERPOINT AT Limitbuy STOP longhigherlow=0 endif graph priorlowAdd this indicator to your chart (see attached screenshot):
DEFPARAM DrawOnLastBarOnly = true ONCE PriorLow = 0 ONCE PriorBar = 0 ONCE CurLow = 0 ONCE CurBar = 0 ONCE back = 30 ONCE half = round(back/2) longhigherlow=0 CurLow = lowest[half](low) FOR j = 0 TO Half - 1 IF low[j] = CurLow THEN CurBar = BarIndex[j] CurMACD = MACD[12,26,9](close)[j] //PriorLow = lowest[half](low[half]) PriorLow = lowest[half](low[Half]) FOR i = Half TO Back-1 IF low[i] = PriorLow THEN PriorMACD = MACD[12,26,9](close)[i] PriorBAR = BarIndex[i] Break ENDIF NEXT Break ENDIF NEXT DrawArrowUP(PriorBar,PriorLow - highest[5](range)*2) coloured(0,0,255,255) DrawArrowUP(CurBar,CurLow - highest[5](range)*2) coloured(0,0,255,255) RETURNThis is the code for the strategy (I could just test it for syntax errors only):
DEFPARAM CumulateOrders = False ONCE VLstop = 1 ONCE VLtake = 2 ONCE PriorLow = 0 ONCE PriorBar = 0 ONCE CurLow = 0 ONCE CurBar = 0 ONCE back = 30 ONCE half = round(back/2) longhigherlow=0 CurLow = lowest[half](low) FOR j = 0 TO Half - 1 IF low[j] = CurLow THEN CurBar = BarIndex[j] CurMACD = MACD[12,26,9](close)[j] PriorLow = lowest[half](low[Half]) FOR i = Half TO Back-1 IF low[i] = PriorLow THEN PriorMACD = MACD[12,26,9](close)[i] PriorBAR = BarIndex[i] Break ENDIF NEXT Break ENDIF NEXT macconflong= CurMACD < PriorMACD c1 = Curlow > PriorLow c2 = Curlow =lowest[3](low) c3 = close < ExponentialAverage[5](high) and close > ExponentialAverage[5](low) c6 = macconflong longhigherlow= c1 and c2 and c3 and c6 Limitbuy=close-5 if not onmarket and longhigherlow=1 then sl=abs(close-lowest[5](low))*Vlstop tp=sl * VLtake Set target profit tp Set stop loss sl BUY 1 PERPOINT AT Limitbuy STOP endif graphonprice priorlow coloured(255,0,0,255) graphonprice curlow coloured(0,128,0,155)Mike Boorman and thanked this postYou can use this version, but the output is not so tidy:
DEFPARAM DrawOnLastBarOnly = true ONCE PriorLow = 0 ONCE PriorBar = 0 ONCE CurLow = 0 ONCE CurBar = 0 ONCE back = 30 ONCE half = round(back/2) ONCE MaxLows = 50 //plot no more than these many arrow pairs IF BarIndex = 0 THEN FOR k = 1 TO MaxLows $PriorL[k] = 0 $PriorB[k] = 0 $CurL[k] = 0 $CurB[k] = 0 NEXT ENDIF longhigherlow=0 CurLow = lowest[half](low) FOR j = 0 TO Half - 1 IF low[j] = CurLow THEN CurBar = BarIndex[j] CurMACD = MACD[12,26,9](close)[j] PriorLow = lowest[half](low[Half]) FOR i = Half TO Back-1 IF low[i] = PriorLow THEN PriorMACD = MACD[12,26,9](close)[i] PriorBAR = BarIndex[i] IF CurLow <> CurLow[1] AND PriorLow <> PriorLow[1] THEN //shift previous data 1 place backwards FOR k = MaxLows DOWNTO 2 $PriorL[k] = $PriorL[k - 1] $PriorB[k] = $PriorB[k - 1] $CurL[k] = $CurL[k - 1] $CurB[k] = $CurB[k - 1] NEXT $PriorL[1] = PriorLow //add a new #1 set of data $PriorB[1] = PriorBar $CurL[1] = CurLow $CurB[1] = CurBAR ENDIF Break ENDIF NEXT Break ENDIF NEXT FOR k = 1 TO MaxLows IF $CurB[k] <> 0 THEN //plot only if there's data in it pl = $PriorL[k] pb = $PriorB[k] cl = $CurL[k] cb = $CurB[k] DrawArrowUP(pb,pl - highest[5](range)*2) coloured(0,255,0,155) //GREEN = prior low DrawArrowUP(cb,cl - highest[5](range)*2) coloured(0,0,255,255) //BLUE = current low ENDIF NEXT RETURNMike Boorman thanked this postI hope this is the final thing on this, Roberto 🙂
I’ve decided to use the PSAR as a way of improving the accuracy of priorlow. I want priorlow to be less than the PSAR in order to allow for an entry but I can’t do it with the code “priorlow < SAR[0.02,0.02,0.2][back]” “priorlow < SAR[0.02,0.02,0.2]”. I assume this is because the priorlow is derived from a lowest bar in a range (which could be bar 26 or whatever) rather than simply the absolute value of the 30th bar back.
How would I do this?
Thank you again.
(I’ve attached a screengrab which graphs “priorlow < SAR[0.02,0.02,0.2][back]” with a black arrow denoting the priorlow bar)
DEFPARAM CumulateOrders = False ONCE VLstop = 1 ONCE VLtake = 2 ONCE PriorLow = 0 ONCE PriorBar = 0 ONCE CurLow = 0 ONCE CurBar = 0 ONCE back = 30 ONCE half = round(back/2) longhigherlow=0 CurLow = lowest[half](low) FOR j = 0 TO Half - 1 IF low[j] = CurLow THEN CurBar = BarIndex[j] CurMACD = MACD[12,26,9](close)[j] PriorLow = lowest[half](low[Half]) FOR i = Half TO Back-1 IF low[i] = PriorLow and low[i] THEN PriorMACD = MACD[12,26,9](close)[i] PriorBAR = BarIndex[i] Break ENDIF NEXT Break ENDIF NEXT macconflong= CurMACD < PriorMACD c1 = Curlow > PriorLow c2 = Curlow =lowest[3](low) c3 = close < ExponentialAverage[5](high) and close > ExponentialAverage[5](low) c6 = macconflong longhigherlow= c1 and c2 and c3 and c6 Limitbuy=close-5 if not onmarket and longhigherlow=1 and priorlow < SAR[0.02,0.02,0.2][back] then sl=abs(close-lowest[5](low))*Vlstop tp=sl * VLtake Set target profit tp Set stop loss sl BUY 1 PERPOINT AT Limitbuy STOP endif graph priorlow < SAR[0.02,0.02,0.2][back]
- You must be logged in to reply to this topic.
Author
Summary
This topic contains 13 replies,
has 3 voices, and was last updated by
4 years, 3 months ago.
Topic Details
| Forum: | ProOrder: Automated Strategies & Backtesting |
| Language: | English |
| Started: | 11/04/2021 |
| Status: | Active |
| Attachments: | 4 files |
