Rewrite SwingTeller code from binck ProTrader to Prorealtime code

joerie1 · Fri, 24 Mar 2017 11:44:41 +0000

Dear Prorealtime members, Is there someone who can change this code of a different banksystem (protrader binq) to a prorealtime code. {- Filename: dynamische RSI -} var RSIPeriode: integer; // parameterwaarde StdDevUp, StdDevDown: real; BolBandPeriode: integer; i: integer; RSIValues, TARValues, UpperBand, LowerBand: TSeries; UpperCrossings, LowerCrossings: TLineCrossings; begin // Indicator parameter definities RSIPeriode := CreateParameterInteger('RSI periode', 1, 999, 7, true); BolBandPeriode := CreateParameterInteger('Boll. MA periode', 1, 999, 50, true); StdDevUp := CreateParameterReal('StdDevUp', 1, 9, 2, true); StdDevDown := CreateParameterReal('StdDevDown', 1, 9, 2, true); // Indicator definitie with Indicator do begin RequiredBars := 5*RSIPeriode + BolBandPeriode; end; // Indicatorberekening RSIValues := RSI(Close, RSIPeriode); UpperBand := BollingerBand(RSIValues, BolBandPeriode, maSimple, StdDevUp); LowerBand := BollingerBand(RSIValues, BolBandPeriode, maSimple, -StdDevDown); TARValues := CreateSeries(BarCount); // signalen berekenen UpperCrossings := Crossings(RSIValues, UpperBand); LowerCrossings := Crossings(RSIValues, LowerBand); for i:=1 to BarCount-1 do begin { RSI crosses over OB lijn = OB entry (signal) RSI > OB lijn = OB (condition) RSI crosses under OB = OB Exit (signal) RSI between OB en OS = Neutral (condition) RSI crosses under OS lijn = OS entry (signal) RSI < OS lijn = OS (condition) RSI crosses over OS = OS Exit (signal) RSI between OB en OS = Neutral (condition) } TARValues[i] := TARValues[i-1]; if UpperCrossings[i] = lc1Over2 then begin EnterShort(i); TARValues[i] := 1; end else if UpperCrossings[i] = lc2Over1 then begin ExitShort(i); TARValues[i] := 0; end else if LowerCrossings[i] = lc2Over1 then begin EnterLong(i); TARValues[i] := -1; end else if LowerCrossings[i] = lc1Over2 then begin ExitLong(i); TARValues[i] := 0; end; end; with CreateLine(RSIValues) do begin Color := clLime; Name := 'RSI'; end; with CreateLine(UpperBand) do begin Color := clSilver; Name := 'OB'; end; with CreateLine(LowerBand) do begin Color := clSilver; Name := 'OS'; end; with CreateLine(TARValues) do begin Color := clWhite; Name := 'TAR'; LineContent := lcTAR; Visible := false; end; end. I hope someone can help me with this

This topic has 66 replies, 6 voices, and was last updated 6 years ago by AVT.

Viewing 15 posts - 46 through 60 (of 67 total)

← 1 2 3 4 5 →

04/06/2017 at 7:59 AM #31189

Nicolas

Does a fail upswing candlestick can be the first count of new down swing? (it should be, but just to be sure).

Please be aware that now almost all candlesticks have a count or a fail symbol, so the charts are hardly readable!

Nicolas
Keymaster

Topics: 81
Replies: 20828
Been thanked: 4742 times

04/06/2017 at 8:17 AM #31194

joerie1

Yes it can!

could you change fail maybe into ‘F’ this will not take that much space.

And its true you cant erase text thats already is draw but maybe you can hide them or give them the colour of the background when it fails.

And fantastic that you are willing to make a screener. it only needs to based on the swingcounter, we ourselves can then look at the RSI

joerie1
Participant

Topics: 2
Replies: 14
Been thanked: 0 times

04/06/2017 at 8:35 AM #31196

JohnVS

Nicolas,

Yes the “F’is alright for me its text so onyone can change it to ones liking 🙂

The hiding idea is cool if possible and if the “F” would be shown it would be no problem for me if the “F” would stay there

Yes the RSI doesnt have to be included for the screener.

Thanks for your input Joeri 🙂

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/06/2017 at 9:02 AM #31204

Nicolas

joerie1 wrote:

but maybe you can hide them or give them the colour of the background when it fails.

That’s an idea!

I made the swing teller stock screener, the ITF file is attached to this post.

Nicolas
Keymaster

Topics: 81
Replies: 20828
Been thanked: 4742 times

04/06/2017 at 9:39 AM #31211

Nicolas

Finally not a good idea, ProBuilder automatically change my colour to make it visible, it means that I can’t draw a black text on a black background, the platform change it to white (and vice-versa for a white chart background..). I was aware of this behaviour for returned variables, but I didn’t knew for drawn objects … So we are stuck .. again! 🙂

Nicolas
Keymaster

Topics: 81
Replies: 20828
Been thanked: 4742 times

04/06/2017 at 9:48 AM #31212

JohnVS

Hey Nicolas,

The idea was great just not technically possible. I have absolutly no problem for the swingcounter to remain there.

If a failed swing can end with an “F” or whatever i say it still is a great thing !! As said, its good to see a swingfail otherwise the thing would make people think its working 100% 😉

so if you van make that i would be more than happy!

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/06/2017 at 9:58 AM #31218

JohnVS

Hey Nicolas,

Could you please confirm :

I have changed the sceener line

screener [downcount=1 or Upcount=1] (direction as “Up or down Swing?”

That should show all the charts that has a start of a swing right ? eventough they are not visable yet it at least give some indication 🙂 would be perfect of cource if the “1” appered also 🙂

thanks again

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/06/2017 at 10:27 AM #31222

Nicolas

You don’t either need to change this line in the stock screener. If downcount or upcount is superior to 0, they are considered as “true” and the screener don’t make any count further than the first one, because we don’t need it obviously.

If the sorting column “direction” is equal to 1, this is a up swing, and -1 is the beginning of a down swing.

How I am supposed to make things appearing on your chart with a screener? You already have the indicator, please put it yourself on your chart, I have no ability to use your account!

Nicolas
Keymaster

Topics: 81
Replies: 20828
Been thanked: 4742 times

04/06/2017 at 10:33 AM #31223

Nicolas

Please find attached the indicator with the live count and the “F” text for the swing failure.

I made the count more visible by always placed them at the minimum distance from high for a down swing and the maximum distance for a up swing. It’s kinda more readable like this.

I’ll add the stock screener and the indicator later in the library.

Nicolas
Keymaster

Topics: 81
Replies: 20828
Been thanked: 4742 times

04/06/2017 at 10:58 AM #31236

JohnVS

didnt mean the number showing through the screener i know thats not possible

But with latest version you already answered my question 🙂

Sorry im a programming noob !

Are you still gonna remove the digits in the number ?

Or explain please what i should do to make it myself

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/06/2017 at 12:18 PM #31244

JohnVS

This is really some great work Nicolas

I really want to thank you so much !!

There is one last thing i want to ask you.

As you see the numbers are quite far away from the bars. Is it possible for you to make them directly under the bar ? and above of cource

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/07/2017 at 10:41 AM #31342

Nicolas

The complete indicator with numbers set correctly above and below candlesticks and with no extra digits on them, can now be found in the library section of the website: https://www.prorealcode.com/prorealtime-indicators/swing-teller-indicator/

Nicolas
Keymaster

Topics: 81
Replies: 20828
Been thanked: 4742 times

04/07/2017 at 9:34 PM #31404

John Doe

Hello Nicolas,

Thank you for coding this indicator (was already looking for it since quite some time). I am interested to use this indicator on the weekly timeframe. I noticed that sometimes a weekly candle/bar gets 2 numbers. In this case the next weekly candle/bar gets no number. I have the impression that this happens every time that there are less than 5 trading days in the week that is represented by the weekly bar/candlestick. In that case the swing counter number seems to be written on the previous week’s candle and the current week’s candle gets no number. I have attached a screenshot and highlighted the issue in yellow. Is there something you can do about it ?

John Doe
Participant

Topics: 1
Replies: 10
Been thanked: 1 time

04/07/2017 at 9:52 PM #31407

Nicolas

@john

Weird problem.. I’ll look at this problem next week. Did you changed anything about Sunday bar or schedules?

Nicolas
Keymaster

Topics: 81
Replies: 20828
Been thanked: 4742 times

04/08/2017 at 9:41 AM #31411

John Doe

Thanks Nicolas for taking the time to have a look at this.
No, I didn’t change anything about Sunday bar or schedules.
I checked some more stocks on the weekly timeframe and the “bug” (missing number) always appears on the same weekly candle across all stocks.
I hope you can find a fix for this.

Kind regards !

John Doe
Participant

Topics: 1
Replies: 10
Been thanked: 1 time
Author

Posts

Viewing 15 posts - 46 through 60 (of 67 total)

← 1 2 3 4 5 →

Find exclusive trading pro-tools on