No trade in a range

• 12/05/2018 at 12:35 PM #86341
  fxbravo

  Good morning gentlemen,

   

  I have an issue in my code.

  Here what I want the code do: when a stop loss is touched, a variable is set to 1 and a “range” is set too (+X and -X points at the Tradeprice(1) )

  Here, visually:

  The Range where trading is forbidden

  -----Range Up (10020) . . - Tradeprice (10000) . . -----Range Down (9980)

  1 2 3 4 5 6 7

  -----Range Up (10020) . . - Tradeprice (10000) . . -----Range Down (9980)

  In ordrer to do that, I code this:

  // ForbidddenTradingRange NoTrade = 0 if notrade = 1 then RangeNoTradeUp = Tradeprice(1)+20 endif if notrade = 1 then RangeNoTradeDown = Tradeprice(1)-20 endif // Long indicator1, ignored, ignored = CALL "Unicorn Color"(close) indicator2 = Average[30](close) c1 = (indicator1 CROSSES OVER indicator2) IF c1 and notrade=0 AND timeEnterBefore AND timeEnterAfter THEN BUY 1 CONTRACT AT MARKET ENDIF // Close Long indicator3, ignored, ignored = CALL "Unicorn Color"(close) indicator4 = Average[30](close) c2 = (indicator3 CROSSES UNDER indicator4) IF c2 THEN SELL AT MARKET notrade=1 ENDIF if close>RangeNoTradeUp or close<RangeNoTradeDown then NoTrade=0 endif // Short indicator5, ignored, ignored = CALL "Unicorn Color"(close) indicator6 = Average[30](close) c3 = (indicator5 CROSSES UNDER indicator6) IF c3 and notrade=0 AND timeEnterBefore AND timeEnterAfter THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF // Close Short indicator7, ignored, ignored = CALL "Unicorn Color"(close) indicator8 = Average[30](close) c4 = (indicator7 CROSSES OVER indicator8) IF c4 THEN EXITSHORT AT MARKET notrade=1 ENDIF if close>RangeNoTradeUp or close<RangeNoTradeDown then NoTrade=0 endif // SL and TP SET STOP pLOSS 20 SET TARGET pPROFIT 20

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65

  // ForbidddenTradingRange   NoTrade = 0   if notrade = 1 then RangeNoTradeUp = Tradeprice(1)+20 endif   if notrade = 1 then RangeNoTradeDown = Tradeprice(1)-20 endif     // Long indicator1, ignored, ignored = CALL "Unicorn Color"(close) indicator2 = Average[30](close) c1 = (indicator1 CROSSES OVER indicator2)     IF c1 and notrade=0 AND timeEnterBefore AND timeEnterAfter THEN BUY 1 CONTRACT AT MARKET ENDIF   // Close Long indicator3, ignored, ignored = CALL "Unicorn Color"(close) indicator4 = Average[30](close) c2 = (indicator3 CROSSES UNDER indicator4)   IF c2 THEN SELL AT MARKET notrade=1 ENDIF   if close>RangeNoTradeUp or close<RangeNoTradeDown then NoTrade=0 endif   // Short indicator5, ignored, ignored = CALL "Unicorn Color"(close) indicator6 = Average[30](close) c3 = (indicator5 CROSSES UNDER indicator6)   IF c3 and notrade=0 AND timeEnterBefore AND timeEnterAfter THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF   // Close Short indicator7, ignored, ignored = CALL "Unicorn Color"(close) indicator8 = Average[30](close) c4 = (indicator7 CROSSES OVER indicator8)   IF c4 THEN EXITSHORT AT MARKET notrade=1 ENDIF   if close>RangeNoTradeUp or close<RangeNoTradeDown then NoTrade=0 endif       // SL and TP SET STOP pLOSS 20 SET TARGET pPROFIT 20

   

  When I backtest it, some trade don’t respect the rule “Forbidden Traading Range”.

   

  I  think I miss something, but I don’t know what 😉

   

  Thank you for your help.

   

  I wish you a good day.

  

  fxbravo

  Participant

  Topics: 20

  Replies: 65

  Been thanked: 1 time
  12/05/2018 at 2:43 PM #86350
  robertogozzi

  Start line 3 with ONCE, otherwise it will ALWAYS be false!

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17782

  Been thanked: 4430 times
  12/05/2018 at 3:15 PM #86358
  Vonasi

  robertogozzi wrote:

  Start line 3 with ONCE, otherwise it will ALWAYS be false!

  …or just delete line 3 as the value of NoTrade will always start at zero!

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1812 times
  12/05/2018 at 8:09 PM #86375
  fxbravo

  Thanks you both!

   

  Have a good day 😉

  

  fxbravo

  Participant

  Topics: 20

  Replies: 65

  Been thanked: 1 time
• Author
  Posts