MACD histogram height

• 04/17/2020 at 5:58 AM #126462
  trevor

  Hello all.  Fairly new to this PRT etc. coding.

  The following code shows no errors, but does not work. I am trying to minimise the sea-saw effect (the back and forth over ‘0’ in the MACD simplified indicator).

  For a buy

  When the MACDline crosses over 0,  and the histogram is higher than 0.00025 within 5 candles of the crossover

  It will start the trade. As I said before, but the histogram height does not work.

  It opens the trade whether the height is above or below the histogram height

  Can someone please help/advise me. Many thanks

  // Conditions to enter long positions // MACDline crosses over 0 indicator1 = MACDline[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0) // MACDline crossed over 0 within last 5 bars ONCE NbBarLimit = 5 IF c1 THEN MyLimitBuy = close MyIndex = BarIndex ENDIF IF BarIndex >= MyIndex + NbBarLimit THEN MyLimitBuy = 0 ENDIF //Histgram minimum height indicator2 = MACD[37/3, 77/3, 0] (close) - MACD [37/3, 77/3, 9] (close) c2 = (indicator2 > 0.00025) // IF Histogram > IF c1 AND MyLimitBuy > 0 AND c2 AND NOT LongOnMarket THEN BUY 1 CONTRACT AT MARKET ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25

  // Conditions to enter long positions // MACDline crosses over 0 indicator1 = MACDline[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0)   // MACDline crossed over 0 within last 5 bars ONCE NbBarLimit = 5   IF c1 THEN MyLimitBuy = close MyIndex = BarIndex ENDIF   IF BarIndex >= MyIndex + NbBarLimit THEN MyLimitBuy = 0 ENDIF   //Histgram minimum height indicator2 = MACD[37/3, 77/3, 0] (close) - MACD [37/3, 77/3, 9] (close) c2 = (indicator2 > 0.00025)   // IF Histogram > IF c1 AND MyLimitBuy > 0 AND c2 AND NOT LongOnMarket THEN BUY 1 CONTRACT AT MARKET ENDIF

   

  

  trevor

  Participant

  Topics: 13

  Replies: 22

  Been thanked: 1 time
  04/17/2020 at 7:45 AM #126467
  Vonasi

  There are some simple rules that everyone using the forums is expected to follow. Your post has broken one or more of these rules.

  The forum rules are as follows. I have highlighted in bold the rule/rules that you have not followed:

  Post your topic in the correct forum.

  ProRealTime Platform Support          only platform related issues.
  ProOrder                                                only strategy topics.
  ProBuilder                                              only indicator topics.
  ProScreener                                           only screener topics
  General Discussion                               any other topics.
  Welcome New Members                      for new forum members to introduce themselves.

  Only post in the language of the forum that you are posting in. For example English only in the English speaking forums and French only in the French speaking forums.
  Always use the ‘Insert PRT Code’ button when putting code in your posts to make it easier for others to read.
  Do not double post. Ask your question only once and only in one forum. All double posts will be deleted anyway so posting the same question multiple times will just be wasting your own time and will not get you an answer any quicker. Double posting just creates confusion in the forums.
  Be careful when quoting others in your posts. Only use the quote option when you need to highlight a particular bit of text that you are referring to or to highlight that you are replying to a particular member if there are several involved in a conversation. Do not include large amounts of code in your quotes. Just highlight the text you want to quote and then click on ‘Quote’.
  Give your topic a meaningful title. Describe your question or your subject in your title. Do not use meaningless titles such as ‘Coding Help Needed’.
  Do not include personal information such as email addresses or telephone numbers in your posts. If you would like to contact another forum member directly outside of the forums then contact the forums administrator via ‘Contact Us’ and they will pass your details on to the member that you wish to contact.
  Always be polite and courteous to others.
  Have fun.

  I have edited your post where required. Please ensure that your future posts meet these few simple forum rules. 🙂

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1812 times
  04/17/2020 at 7:53 AM #126469
  Vonasi

  Add the following to the bottom of your code and you will get some clues as to what is going wrong.

  graph MACD [37/3, 77/3, 9](close) graph indicator1 graph indicator2

  1 2 3

  graph MACD [37/3, 77/3, 9](close) graph indicator1 graph indicator2

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1812 times
  04/19/2020 at 12:10 AM #126826
  trevor

  Thank you Vonasi.

  The graph has highlighed the error.

  Process      1. Macd crosses over 0.         2.Macd histogram is above 0.00025

  Item 2 is not working. The formula is not correct or used, and the program opens regardless whether it is above or below histogram height.

  The attachment shows 2 trades, one of which is open in demo mode. They both were below 0.00025 when opened and one was just over 0.

  Any ideas of how to fix the formula greatly appreciated.

  regards Trevor

  // Conditions to enter long positions // MACDline crosses over 0 indicator1 = MACDline[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0) //Histgram minimum height //NOT WORKING/////////////////////////////////////////////////////////////// indicator2 = MACD[37/3, 77/3, 0] (close) - MACD [37/3, 77/3, 9] (close) c2 = (indicator2 > 0.00025) // IF Histogram > 0.00025 IF c1 AND c2 AND NOT LongOnMarket THEN BUY 1 CONTRACT AT MARKET ENDIF // Conditions to exit long positions indicator3 = MACDline[37/3, 77/3, 9](close) c3 = (indicator3 CROSSES UNDER 0) IF c3 THEN SELLSHORT AT MARKET ENDIF // Conditions to enter short positions indicator4 = MACDline[37/3, 77/3, 9](close) c4 = (indicator4 CROSSES UNDER 0) //Histgram minimum height indicator5 = MACD[37/3, 77/3, 0] (close) - MACD [37/3, 77/3, 9] (close) c5 = (indicator5 < -0.00025) // IF Histogram < -0.00025 IF c4 AND c5 AND NOT ShortOnMarket THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39

  // Conditions to enter long positions // MACDline crosses over 0 indicator1 = MACDline[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0)        //Histgram minimum height //NOT WORKING/////////////////////////////////////////////////////////////// indicator2 = MACD[37/3, 77/3, 0] (close) - MACD [37/3, 77/3, 9] (close) c2 = (indicator2 > 0.00025)   // IF Histogram > 0.00025 IF c1 AND c2 AND NOT LongOnMarket THEN BUY 1 CONTRACT AT MARKET ENDIF   // Conditions to exit long positions indicator3 = MACDline[37/3, 77/3, 9](close) c3 = (indicator3 CROSSES UNDER 0)   IF c3 THEN SELLSHORT AT MARKET ENDIF   // Conditions to enter short positions indicator4 = MACDline[37/3, 77/3, 9](close) c4 = (indicator4 CROSSES UNDER 0)     //Histgram minimum height indicator5 = MACD[37/3, 77/3, 0] (close) - MACD [37/3, 77/3, 9] (close) c5 = (indicator5 < -0.00025)     // IF Histogram < -0.00025 IF c4 AND c5 AND NOT ShortOnMarket THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF

  

  trevor

  Participant

  Topics: 13

  Replies: 22

  Been thanked: 1 time
  04/19/2020 at 9:19 AM #126839
  GraHal

  Have you tried using Cursor Details to see EXACTLY what that histo height is on the bar the entry conditions are met (the bar before actual entry bar)?

  Unless I am missing something, the histo height appears to be above  0.00025 when the macd line crosses 0?

  Right click, Display, Cursor Details and tell us exactly what the height of the histo is?

  

  GraHal

  Participant

  Topics: 221

  Replies: 9087

  Been thanked: 2348 times
  04/20/2020 at 9:02 AM #127000
  Nicolas

  You should use integer for your MACD periods, the problem might come from rounding differences in the EMA calculation used in the MACD formula.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20867

  Been thanked: 4783 times
  04/21/2020 at 3:41 AM #127160
  trevor

  Thank you GraHal for your suggestion. Have used the cursor details window and the Histogram Height is not above 0.00025 or below for the sell -0.00025.

  And thank you Nicolas also. I have tried the integers of MACD[12, 26, 9] (close), instead of the formula MACD[37/3, 77/3, 9] (close). It did not change anything.

  I rewrote the code. Mainly looking back the 5 candles.  indicator2, the MACD, is formulated to be the histogram height.

  Changed the minimum height of the histogram to 10, which it almost never is in forex, to illustrate that indicator2 does not work.

  The trades open whether the histogram height is 0.000001 or whatever.

  How does the backtest have a result if the histogram height is never correct?

  The attachment shows a trade opened by backtest with the MACD Line minus signal at 0.00016 shown in the cursor details window.

  Any help or suggestions appreciated.

   

  // Main code : 1MACD 1.2 simplified +stopsFX--------------- // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated // BUY -------------------------------------------------------------------------------------- // Conditions to enter long positions // MACDline crosses over 0 within 5 bars indicator1 = MACDline[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0) c1 = (indicator1 CROSSES OVER 0[1]) c1 = (indicator1 CROSSES OVER 0[2]) c1 = (indicator1 CROSSES OVER 0[3]) c1 = (indicator1 CROSSES OVER 0[4]) c1 = (indicator1 CROSSES OVER 0[5]) indicator2 = MACD[37/3, 77/3, 9] (close) c2 = (indicator2 > 10.0) IF c1 AND c2 THEN BUY 1 CONTRACT AT MARKET ENDIF // Conditions to exit long positions indicator3 = MACDline[37/3, 77/3, 9](close) c3 = (indicator3 CROSSES UNDER 0) IF c3 THEN SELLSHORT AT MARKET ENDIF // SELL ------------------------------------------------------------------------------ // Conditions to enter short positions indicator11 = MACDline[37/3, 77/3, 9](close) c11 = (indicator11 CROSSES UNDER 0) c11 = (indicator11 CROSSES UNDER 0[1]) c11 = (indicator11 CROSSES UNDER 0[2]) c11 = (indicator11 CROSSES UNDER 0[3]) c11 = (indicator11 CROSSES UNDER 0[4]) c11 = (indicator11 CROSSES UNDER 0[5]) indicator12 = MACD[37/3, 77/3, 9] (close) c12 = (indicator12 < -10.0) IF c11 AND c12 THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF // Conditions to exit short positions indicator14 = MACDline[37/3, 77/3, 9](close) c14 = (indicator14 CROSSES OVER 0) IF c14 THEN BUY AT MARKET ENDIF // Stops and targets SET STOP pTRAILING 50 SET TARGET pPROFIT 100

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65

  // Main code : 1MACD 1.2 simplified +stopsFX---------------   // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated       // BUY  -------------------------------------------------------------------------------------- // Conditions to enter long positions // MACDline crosses over 0 within 5 bars indicator1 = MACDline[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0) c1 = (indicator1 CROSSES OVER 0[1]) c1 = (indicator1 CROSSES OVER 0[2]) c1 = (indicator1 CROSSES OVER 0[3]) c1 = (indicator1 CROSSES OVER 0[4]) c1 = (indicator1 CROSSES OVER 0[5])   indicator2 = MACD[37/3, 77/3, 9] (close) c2 = (indicator2 > 10.0)       IF c1 AND c2 THEN BUY 1 CONTRACT AT MARKET ENDIF   // Conditions to exit long positions indicator3 = MACDline[37/3, 77/3, 9](close) c3 = (indicator3 CROSSES UNDER 0)   IF c3 THEN SELLSHORT AT MARKET ENDIF   // SELL ------------------------------------------------------------------------------ // Conditions to enter short positions indicator11 = MACDline[37/3, 77/3, 9](close) c11 = (indicator11 CROSSES UNDER 0) c11 = (indicator11 CROSSES UNDER 0[1]) c11 = (indicator11 CROSSES UNDER 0[2]) c11 = (indicator11 CROSSES UNDER 0[3]) c11 = (indicator11 CROSSES UNDER 0[4]) c11 = (indicator11 CROSSES UNDER 0[5])     indicator12 = MACD[37/3, 77/3, 9] (close) c12 = (indicator12 < -10.0)     IF c11 AND c12 THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF   // Conditions to exit short positions indicator14 = MACDline[37/3, 77/3, 9](close) c14 = (indicator14 CROSSES OVER 0)   IF c14 THEN BUY AT MARKET ENDIF   // Stops and targets SET STOP pTRAILING 50 SET TARGET pPROFIT 100

   

  

  trevor

  Participant

  Topics: 13

  Replies: 22

  Been thanked: 1 time
  04/21/2020 at 8:21 AM #127178
  Vonasi

  The red line on the MACD chart is the MACD signal line and not the MACD line.

  Also having the same variable (c1 and c11) defined differently five times in a row will not work – it will simply use the last version of definition.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1812 times
  04/21/2020 at 11:05 PM #127348
  trevor

  Thank you Vonasi, for your help. I have corrected the code. The MACD is the histogram height and that is what I now use.

  But when I run the code, it still trades when the MACD line minus signal (9) is under the +or – 0.00025.

  What is wrong with my code? Help me please.

  //------------------------------------------------------------------------- // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated // Conditions to enter long positions // 1. MACDline crosses over indicator1 = MACD[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0.00025) // 2. MACD > MACD previous indicator2 = MACD[37/3, 77/3, 9](close) c2 = (indicator2 > indicator2[1]) // 3. MACDline crossed over 0 within last 5 bars ONCE NbBarLimit = 5 IF c1 THEN MyLimitBuy = close MyIndex = BarIndex ENDIF IF BarIndex >= MyIndex + NbBarLimit THEN MyLimitBuy = 0 ENDIF // BUY ---------------------------------------- AND NOT LongOnMarket IF c1 AND c2 AND MyLimitBuy > 0 THEN BUY 1 CONTRACT AT MARKET ENDIF // Conditions to exit long positions indicator3 = MACD[37/3, 77/3, 9](close) c3 = (indicator3 CROSSES UNDER 0) IF c3 THEN SELLSHORT AT MARKET ENDIF // Conditions to enter short positions // 1. MACDline crosses under indicator4 = MACDline[37/3, 77/3, 9](close) c4 = (indicator4 CROSSES UNDER -0.0025) // 2. MACD < MACD previous indicator5 = MACD[37/3, 77/3, 9](close) c5 = (indicator5 < indicator5[1]) // 3.MACDline crossed over 0 within last 5 bars ONCE NbBarLimit = 5 IF c1 THEN MyLimitBuy = close MyIndex = BarIndex ENDIF IF BarIndex >= MyIndex + NbBarLimit THEN MyLimitBuy = 0 ENDIF // BUY --------------------------------------------AND NOT SHORTOnMarket IF c4 AND c5 AND MyLimitBuy > 0 THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF // Conditions to exit short positions indicator6 = MACDline[37/3, 77/3, 9](close) c4 = (indicator6 CROSSES OVER 0) IF c4 THEN BUY AT MARKET ENDIF // Stops and targets SET STOP pTRAILING 50 SET TARGET pPROFIT 100

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79

  //-------------------------------------------------------------------------   // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated         // Conditions to enter long positions // 1. MACDline crosses over indicator1 = MACD[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0.00025)   // 2. MACD > MACD previous indicator2 = MACD[37/3, 77/3, 9](close) c2 = (indicator2 > indicator2[1])    // 3. MACDline crossed over 0 within last 5 bars ONCE NbBarLimit = 5   IF c1 THEN MyLimitBuy = close MyIndex = BarIndex ENDIF   IF BarIndex >= MyIndex + NbBarLimit THEN MyLimitBuy = 0 ENDIF   // BUY ----------------------------------------     AND NOT LongOnMarket IF c1 AND c2 AND MyLimitBuy > 0 THEN BUY 1 CONTRACT AT MARKET ENDIF   // Conditions to exit long positions indicator3 = MACD[37/3, 77/3, 9](close) c3 = (indicator3 CROSSES UNDER 0)   IF c3 THEN SELLSHORT AT MARKET ENDIF   // Conditions to enter short positions // 1. MACDline crosses under indicator4 = MACDline[37/3, 77/3, 9](close) c4 = (indicator4 CROSSES UNDER -0.0025)   // 2. MACD < MACD previous indicator5 = MACD[37/3, 77/3, 9](close) c5 = (indicator5 < indicator5[1])   // 3.MACDline crossed over 0 within last 5 bars ONCE NbBarLimit = 5   IF c1 THEN MyLimitBuy = close MyIndex = BarIndex ENDIF   IF BarIndex >= MyIndex + NbBarLimit THEN MyLimitBuy = 0 ENDIF   //  BUY --------------------------------------------AND NOT SHORTOnMarket IF c4 AND c5 AND MyLimitBuy > 0 THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF   // Conditions to exit short positions indicator6 = MACDline[37/3, 77/3, 9](close) c4 = (indicator6 CROSSES OVER 0)   IF c4 THEN BUY AT MARKET ENDIF   // Stops and targets SET STOP pTRAILING 50 SET TARGET pPROFIT 100

   

   

  

  trevor

  Participant

  Topics: 13

  Replies: 22

  Been thanked: 1 time
  04/22/2020 at 2:50 AM #127371
  trevor

  This PRT code does not work.  Code created by simplified creation. See attachment error3

  I then switched to creation by programming and copied that to my code(attachment error4).

  The full code-

  This is the PRT code created through their program. It still opens trades but 5 of the 12 trades are outside +or- 0.0003. See third attachment

  THE FULL CODE

  //------------------------------------------------------------------------- // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated // BUY ---------------------------------------- // Conditions to enter long positions // 1. MACDline crosses over indicator1 = MACD[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0.0003) IF c1 THEN BUY 1 CONTRACT AT MARKET ENDIF // Conditions to exit long positions indicator3 = MACDline[37/3, 77/3, 9](close) c3 = (indicator3 CROSSES UNDER 0) IF c3 THEN SELLSHORT AT MARKET ENDIF // SELL -------------------------------------------- // Conditions to enter short positions // 1. MACDline crosses under indicator4 = MACD[37/3, 77/3, 9](close) c4 = (indicator4 CROSSES UNDER -0.0003) IF c4 THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF // Conditions to exit short positions indicator6 = MACDline[37/3, 77/3, 9](close) c6 = (indicator6 CROSSES OVER 0) IF c6 THEN BUY AT MARKET ENDIF // Stops and targets SET STOP $TRAILING 50 SET TARGET $PROFIT 100

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48

  //-------------------------------------------------------------------------   // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated       // BUY ---------------------------------------- // Conditions to enter long positions // 1. MACDline crosses over indicator1 = MACD[37/3, 77/3, 9](close) c1 = (indicator1 CROSSES OVER 0.0003)   IF c1 THEN BUY 1 CONTRACT AT MARKET ENDIF   // Conditions to exit long positions indicator3 = MACDline[37/3, 77/3, 9](close) c3 = (indicator3 CROSSES UNDER 0)   IF c3 THEN SELLSHORT AT MARKET ENDIF     //  SELL -------------------------------------------- // Conditions to enter short positions // 1. MACDline crosses under indicator4 = MACD[37/3, 77/3, 9](close) c4 = (indicator4 CROSSES UNDER -0.0003)     IF c4 THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF   // Conditions to exit short positions indicator6 = MACDline[37/3, 77/3, 9](close) c6 = (indicator6 CROSSES OVER 0)   IF c6 THEN BUY AT MARKET ENDIF   // Stops and targets SET STOP $TRAILING 50 SET TARGET $PROFIT 100

   

  This is the part that is not working. Copied from ‘creation by programming’

  // Conditions to enter long positions indicator1 = MACD[37/3, 77/3, 9](close) c1 = (indicator1 > 0.0003) IF c1 THEN BUY 1 CONTRACT AT MARKET ENDIF

  1 2 3 4 5 6 7

  // Conditions to enter long positions indicator1 = MACD[37/3, 77/3, 9](close) c1 = (indicator1 > 0.0003)   IF c1 THEN BUY 1 CONTRACT AT MARKET ENDIF

  Can I get a hand with this error please.

  

  trevor

  Participant

  Topics: 13

  Replies: 22

  Been thanked: 1 time
  04/22/2020 at 7:10 AM #127385
  Vonasi

  Can you do what Nicolas told you to do and ditch the 37/3 and 77/3 from your MACD and MACDLINE instructions. The instructions should have only whole integers only.

  Also I notice that your displayed indicator is the MACD Simplified and not MACD. They are different MACD calculations. Your ProOrder code is using the latter while you are comparing the results to the former.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1812 times
  04/22/2020 at 9:07 AM #127399
  Nicolas

  By GRAPHin your variables in backtests, you will find many interesting information. Firstly, compare the MACD from the backtest and the MACD indicator on the chart.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20867

  Been thanked: 4783 times
• Author
  Posts