Help with code to find previous high/low

• 07/11/2017 at 7:18 AM #40304
  nickp104

  Hi,

  Forgive me, I’m sure there must be an easy solution but I can’t seem to find it anywhere.

  I am keen to open positions or, if already open, close positions if the price closes under/over a previous high/low.

  I have bene using:

  DEFPARAM CumulateOrders = FALSE     TLow = lowest[30](low) THigh = highest[30](high)     c1 = CLOSE > THigh C2 = CLOSE < TLow   IF C1 THEN BUY 1 SHARES AT MARKET ELSIF c2 THEN SELLSHORT 1 SHARES AT MARKET ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

  DEFPARAM CumulateOrders = FALSE     TLow = lowest[30](low) THigh = highest[30](high)     c1 = CLOSE > THigh C2 = CLOSE < TLow   IF C1 THEN BUY 1 SHARES AT MARKET ELSIF c2 THEN SELLSHORT 1 SHARES AT MARKET ENDIF

   

   But that doesn’t generate any trades.

  I would be hugely grrateful if someone could tell me where I’m going wrong.

  Thanks in advance.

  Nick

  

  nickp104

  Participant

  Topics: 3

  Replies: 3

  Been thanked: 0 times
  07/11/2017 at 8:32 AM #40319
  tob107

  Try changing “SHARES” to “CONTRACTS” depending on what you are trading.

  The main problem is probably that you save the new values first, including the closing candle. That means that you don’t get any trades since the close is never lower than TLow or higher than the THigh, since they are included. I asssume this is the problem at least, but I can’t figure out how to fix it right now. Should be fairly easy though.

  Cheers

  

  tob107

  Participant

  Topics: 7

  Replies: 22

  Been thanked: 15 times
  07/11/2017 at 10:50 AM #40332
  Nicolas

  > For clarity of messages on ProRealCode’s forums, please use the “insert code PRT” button to separate the text of the code part! Thank you! <<

  If Close is superior to the highest high, Close IS THE HIGHEST HIGH! So it can’t be superior to itself obviously

  So you must compare if Close is superior to the PREVIOUS highest high instead:

  c1 = CLOSE > THigh[1] C2 = CLOSE < TLow[1]

  1 2	c1 = CLOSE > THigh[1] C2 = CLOSE < TLow[1]

   

  1 user thanked author for this post.

  nickp104

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20867

  Been thanked: 4783 times
  07/13/2017 at 8:36 AM #40510
  nickp104

  Nicholas, as ever, thank you.  kicking myself now!  And your point about pasting code is noted.

  

  nickp104

  Participant

  Topics: 3

  Replies: 3

  Been thanked: 0 times
• Author
  Posts