Averaging down/up code is not working

• 02/26/2020 at 9:58 PM #120613
  rama

  code to sell 1p points

  //------------------------------------------------------------------------- // Main code : buy(1) //------------------------------------------------------------------------- DEFPARAM FlatBefore = 143500 DEFPARAM FlatAfter = 210000 // Conditions to enter short positions IF NOT onmarket THEN sellshort 4 CONTRACTS AT MARKET ENDIF nu=12 nn=20222 nn1=200 // Conditions to exit short positions if countofposition<=7 and countofposition>=4 then IF longonmarket and close>tradeprice-nu THEN sellshort 3 CONTRACTS AT tradeprice-nu stop endif endif if countofposition<=9 and countofposition>=7 then IF longonmarket and close>tradeprice-nu THEN sellshort 2 CONTRACTS AT tradeprice-nu stop endif endif if countofposition<=10 and countofposition>=9 then IF longonmarket and close>tradeprice-nu THEN sellshort 1 CONTRACTS AT tradeprice-nu stop endif endif floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize if onmarket and (floatingprofit <=-nn or floatingprofit >= nn1) then exitshort at market endif

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41

  //------------------------------------------------------------------------- // Main code : buy(1) //------------------------------------------------------------------------- DEFPARAM FlatBefore = 143500   DEFPARAM FlatAfter = 210000     // Conditions to enter short positions IF NOT onmarket THEN sellshort 4 CONTRACTS AT MARKET ENDIF nu=12 nn=20222 nn1=200 // Conditions to exit short positions if countofposition<=7 and countofposition>=4 then IF longonmarket and  close>tradeprice-nu THEN sellshort 3 CONTRACTS AT tradeprice-nu stop endif endif if  countofposition<=9 and countofposition>=7 then IF longonmarket and  close>tradeprice-nu THEN sellshort 2 CONTRACTS AT tradeprice-nu stop endif endif if  countofposition<=10 and countofposition>=9 then IF longonmarket and close>tradeprice-nu THEN sellshort 1 CONTRACTS AT tradeprice-nu stop   endif         endif floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize if onmarket and  (floatingprofit <=-nn or floatingprofit >= nn1) then exitshort at market   endif

  I want to sell 10 contacts first 4 at market then 3 , 2, 1 at last trade price – nu, this code is not working for shortpostions, where the long position code is working fine where i replaced just close<tradprice+nu then, what is wrong with  this code?

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  02/26/2020 at 9:59 PM #120614
  rama

  longcode which works fine

  //------------------------------------------------------------------------- // Main code : buy //------------------------------------------------------------------------- DEFPARAM FlatBefore = 143500 DEFPARAM FlatAfter = 210000 // Conditions to enter short positions IF NOT onmarket THEN buy 4 CONTRACTS AT MARKET ENDIF nu=12 nn=20222 nn1=200 // Conditions to exit short positions if countofposition<=7 and countofposition>=4 then IF longonmarket and close<tradeprice+nu THEN buy 3 CONTRACTS AT tradeprice+nu stop endif endif if countofposition<=9 and countofposition>=7 then IF longonmarket and close<tradeprice+nu THEN buy 2 CONTRACTS AT tradeprice+nu stop endif endif if countofposition<=10 and countofposition>=9 then IF longonmarket and close<tradeprice+nu THEN buy 1 CONTRACTS AT tradeprice+nu stop endif endif floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize if onmarket and (floatingprofit <=-nn or floatingprofit >= nn1) then sell at market endif

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41

  //------------------------------------------------------------------------- // Main code : buy //------------------------------------------------------------------------- DEFPARAM FlatBefore = 143500   DEFPARAM FlatAfter = 210000     // Conditions to enter short positions IF NOT onmarket THEN buy 4 CONTRACTS AT MARKET ENDIF nu=12 nn=20222 nn1=200 // Conditions to exit short positions if countofposition<=7 and countofposition>=4 then IF longonmarket and  close<tradeprice+nu THEN buy 3 CONTRACTS AT tradeprice+nu stop endif endif if  countofposition<=9 and countofposition>=7 then IF longonmarket and  close<tradeprice+nu THEN buy 2 CONTRACTS AT tradeprice+nu stop endif endif if  countofposition<=10 and countofposition>=9 then IF longonmarket and close<tradeprice+nu THEN buy 1 CONTRACTS AT tradeprice+nu stop   endif         endif floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize if onmarket and  (floatingprofit <=-nn or floatingprofit >= nn1) then sell at market   endif

   

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  02/26/2020 at 10:25 PM #120616
  Vonasi

  Change LONGONMARKET to SHORTONMARKET?

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1812 times
  02/26/2020 at 10:31 PM #120617
  Vonasi

  rama – Please give your topics more meaningful titles otherwise we end up with a forum full of meaningless ‘code is not working’ topics. I have edited your topic title.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1812 times
  02/26/2020 at 10:56 PM #120618
  GraHal

  You need it as below (If shortonmarket, countofposition <= –7 etc    …

  not tested though

  if countofposition<= -7 and countofposition>=-4 then IF shortonamrket and close>tradeprice-nu THEN sellshort 3 CONTRACTS AT tradeprice-nu stop endif

  1 2 3 4

  if countofposition<= -7 and countofposition>=-4 then IF shortonamrket and  close>tradeprice-nu THEN sellshort 3 CONTRACTS AT tradeprice-nu stop endif

   

  

  GraHal

  Participant

  Topics: 222

  Replies: 9296

  Been thanked: 2462 times
  02/26/2020 at 11:02 PM #120619
  GraHal

  Yeah it works! 🙂

  CountofPosition of Shorts need a – / minus so – 4, -7 etc

  DEFPARAM FlatBefore = 143500 DEFPARAM FlatAfter = 210000 // Conditions to enter short positions IF NOT onmarket THEN sellshort 4 CONTRACTS AT MARKET ENDIF nu=12 nn=20222 nn1=200 // Conditions to exit short positions if countofposition>= -7 and countofposition<= -4 then IF shortonmarket and close>tradeprice-nu THEN sellshort 3 CONTRACTS AT tradeprice-nu stop endif endif if countofposition>= -9 and countofposition<= -7 then IF shortonmarket and close>tradeprice-nu THEN sellshort 2 CONTRACTS AT tradeprice-nu stop endif endif if countofposition>= -10 and countofposition<= -9 then IF shortonmarket and close>tradeprice-nu THEN sellshort 1 CONTRACTS AT tradeprice-nu stop endif endif floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize if onmarket and (floatingprofit <=-nn or floatingprofit >= nn1) then exitshort at market endif

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38

  DEFPARAM FlatBefore = 143500 DEFPARAM FlatAfter = 210000 // Conditions to enter short positions IF NOT onmarket THEN sellshort 4 CONTRACTS AT MARKET ENDIF nu=12 nn=20222 nn1=200 // Conditions to exit short positions if countofposition>= -7 and countofposition<= -4 then IF shortonmarket and  close>tradeprice-nu THEN sellshort 3 CONTRACTS AT tradeprice-nu stop endif endif if  countofposition>= -9 and countofposition<= -7 then IF shortonmarket and  close>tradeprice-nu THEN sellshort 2 CONTRACTS AT tradeprice-nu stop endif endif if  countofposition>= -10 and countofposition<= -9 then IF shortonmarket and close>tradeprice-nu THEN sellshort 1 CONTRACTS AT tradeprice-nu stop endif endif floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize if onmarket and  (floatingprofit <=-nn or floatingprofit >= nn1) then exitshort at market endif

   

  

  GraHal

  Participant

  Topics: 222

  Replies: 9296

  Been thanked: 2462 times
  02/26/2020 at 11:37 PM #120621
  Vonasi

  Well spotted GraHal – I didn’t spot that COUNTOFPOSITION was not shown as negative for short positions. You’re getting pretty good at this code analysis!

  1 user thanked author for this post.

  GraHal

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1812 times
• Author
  Posts