Calculating fibbonaci

• 02/26/2020 at 10:33 AM #120536
  jebus89

  Hi all im wondering how i can do the following:

  Calculate fibb, for example lets say “Close crosses under Fibb 50 level”

   

  What i want to do is something like:

  HH = Highest high variable1 bars ago

  LL = lowest low variable2 bars ago

  Fibb1: (HH-LL) * 0.5

  Fibb2: LL + fibb1

  return fibb2

   

  If we are trending upwards all is well, but if we are trending down, then HH comes before LL, and this causes problems.

  I need to tell the code something like:

  If LL happened 22 bars ago, then HH must be calculated from the past 21 bars ago (so that it comes AFTER LL has happened)

   

  How can i do this?

  

  jebus89

  Participant

  Topics: 120

  Replies: 603

  Been thanked: 250 times
  02/26/2020 at 12:54 PM #120550
  jebus89

  i tried this:

  once q = 1 LL = lowest[50](low[1]) HH = highest[q](high[1]) if low crosses under LL then q = q+1 endif if q >50 then q = 0 endif o1 = HH - LL fibb1 = o1*0.5 fibb2 = fibb1 + LL if close crosses under fibb2 then kk = 1 elsif close > fibb2 or close < fibb2 then kk = 0 endif return kk

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24

  once q = 1   LL = lowest[50](low[1]) HH = highest[q](high[1])   if low crosses under LL then q = q+1 endif   if q >50 then q = 0 endif   o1 = HH - LL fibb1 = o1*0.5 fibb2 = fibb1 + LL   if close crosses under fibb2 then kk = 1 elsif close > fibb2 or close < fibb2 then kk = 0 endif   return kk

  But i got the error message:

  “Error in the indicator: MyIndicator(30)

  A positive integer field is expected with HIGHEST”

   

  So im guessing i cant use a variable in the HIGHESt, it has to be a number?

  Any other way to do what i want to do?

  

  jebus89

  Participant

  Topics: 120

  Replies: 603

  Been thanked: 250 times
  02/26/2020 at 1:34 PM #120565
  GraHal

  You probably need the long awaited Arrays function to do it correctly?

  Have you tried recording / using the barindex when you get the LL / HH?

  For example …

  If (HHcondition) then MyHH = barindex Endif

  1 2 3

  If (HHcondition) then MyHH = barindex Endif

   

   

  

  GraHal

  Participant

  Topics: 222

  Replies: 9296

  Been thanked: 2462 times
  02/26/2020 at 1:36 PM #120567
  jebus89

  Ive never seen this barindex, this might be the solution to my problems (?) would need to consult the holy PRT manual to see what barindex is and how to use it.

   

  If it dosnt work im guessing i need arrays?

   

  I have the same problem when trying to calculate “how many % the market has gone up”

   

  Say you want to calculate how far up the market has gone since the Lowest low past 100 bars.

   

  How can i calculate that? Same problem as with the fibb?

  

  jebus89

  Participant

  Topics: 120

  Replies: 603

  Been thanked: 250 times
  02/26/2020 at 1:38 PM #120568
  robertogozzi

  Try removing ONCE from line 1, just write q = 1.

  This an indicator I wrote, where I am dealing with your problem with a FOR…NEXT loop:

  DEFPARAM CalculateOnLastBars = 300 DEFPARAM DrawOnLastBarOnly = True p = 100 HH = highest[p](high) LL = lowest[p](low) Diff = HH - LL Fib0236 = Diff * 0.236 Fib0382 = Diff * 0.382 Fib0500 = Diff * 0.500 Fib0618 = Diff * 0.618 Fib0764 = Diff * 0.764 Up = 0 Dn = 0 FOR i = 0 TO (p - 1) IF high[i] = HH THEN Up = 1 BREAK ENDIF IF low[i] = LL THEN Dn = 1 BREAK ENDIF NEXT DRAWHLINE(HH) coloured(238,122,233,255)//(0,128,0,255) DRAWHLINE(LL) coloured(238,122,233,255)//(0,128,0,255) IF Up THEN Fib0236 = HH - Fib0236 Fib0382 = HH - Fib0382 Fib0500 = HH - Fib0500 Fib0618 = HH - Fib0618 Fib0764 = HH - Fib0764 ELSIF Dn THEN Fib0236 = LL + Fib0236 Fib0382 = LL + Fib0382 Fib0500 = LL + Fib0500 Fib0618 = LL + Fib0618 Fib0764 = LL + Fib0764 ENDIF DRAWTEXT(" ------#Fib0236#---(23.6%)",barindex,Fib0236,SansSerif,Bold,10)coloured(238,122,233,255) DRAWTEXT(" ------#Fib0382#---(38.2%)",barindex,Fib0382,SansSerif,Bold,10)coloured(238,122,233,255) DRAWTEXT(" ------#Fib0500#---(50.0%)",barindex,Fib0500,SansSerif,Bold,10)coloured(238,122,233,255) DRAWTEXT(" ------#Fib0618#---(61.8%)",barindex,Fib0618,SansSerif,Bold,10)coloured(238,122,233,255) DRAWTEXT(" ------#Fib0764#---(76.4%)",barindex,Fib0764,SansSerif,Bold,10)coloured(238,122,233,255) RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44

  DEFPARAM CalculateOnLastBars = 300 DEFPARAM DrawOnLastBarOnly   = True p       = 100 HH      = highest[p](high) LL      = lowest[p](low) Diff    = HH - LL Fib0236 = Diff * 0.236 Fib0382 = Diff * 0.382 Fib0500 = Diff * 0.500 Fib0618 = Diff * 0.618 Fib0764 = Diff * 0.764 Up     = 0 Dn     = 0 FOR i = 0 TO (p - 1)    IF high[i] = HH THEN       Up = 1       BREAK    ENDIF    IF low[i] = LL THEN       Dn = 1       BREAK    ENDIF NEXT DRAWHLINE(HH) coloured(238,122,233,255)//(0,128,0,255) DRAWHLINE(LL) coloured(238,122,233,255)//(0,128,0,255) IF Up THEN    Fib0236 = HH - Fib0236    Fib0382 = HH - Fib0382    Fib0500 = HH - Fib0500    Fib0618 = HH - Fib0618    Fib0764 = HH - Fib0764 ELSIF Dn THEN    Fib0236 = LL + Fib0236    Fib0382 = LL + Fib0382    Fib0500 = LL + Fib0500    Fib0618 = LL + Fib0618    Fib0764 = LL + Fib0764 ENDIF DRAWTEXT("                                      ------#Fib0236#---(23.6%)",barindex,Fib0236,SansSerif,Bold,10)coloured(238,122,233,255) DRAWTEXT("                                      ------#Fib0382#---(38.2%)",barindex,Fib0382,SansSerif,Bold,10)coloured(238,122,233,255) DRAWTEXT("                                      ------#Fib0500#---(50.0%)",barindex,Fib0500,SansSerif,Bold,10)coloured(238,122,233,255) DRAWTEXT("                                      ------#Fib0618#---(61.8%)",barindex,Fib0618,SansSerif,Bold,10)coloured(238,122,233,255) DRAWTEXT("                                      ------#Fib0764#---(76.4%)",barindex,Fib0764,SansSerif,Bold,10)coloured(238,122,233,255) RETURN

   

  1 user thanked author for this post.

  jebus89

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 18049

  Been thanked: 4616 times
  02/26/2020 at 2:05 PM #120573
  GraHal

  jebus89 wrote:

  Ive never seen this barindex

  https://www.prorealcode.com/documentation/barindex/

  Tradeindex also …

  https://www.prorealcode.com/documentation/tradeindex/

   

  

  GraHal

  Participant

  Topics: 222

  Replies: 9296

  Been thanked: 2462 times
  02/26/2020 at 4:42 PM #120587
  Nicolas

  q= 0 at line 11, that’s why it fails to calculate the Highest with a null period at second run of the code (at 2nd bar or so)..

  

  Nicolas

  Keymaster

  Topics: 83

  Replies: 20899

  Been thanked: 4867 times
  02/26/2020 at 8:35 PM #120609
  jebus89

  Big thanks guys, Roberto gave me the pieces i needed 🙂

   

  also thank you for links nicolas

  

  jebus89

  Participant

  Topics: 120

  Replies: 603

  Been thanked: 250 times
• Author
  Posts