Stop moved to entry when in profit

• 07/11/2018 at 12:38 PM #75795
  Dave_the_trader

  Needing help to code so that the stop moves to entry (0) when the trade is in profit by a number of points?

  // indicators and parameters defparam cumulateorders = false defparam flatbefore = 083000 defparam flatafter =170000 possize = 10 IF TIME = 090000 THEN //include the 0910 candle Top = highest[6](high) // go back 8 candles Bottom = lowest[6](low) // go back 8 candles LongsForDay = 0 MaxPos = 1 ENDIF IF TradeIndex = BarIndex THEN LongsForDay = LongsForDay +1 ENDIF IF TIME >=090000 AND LongsForDay < MaxPos THEN BUY possize CONTRACTS AT Top +11 STOP SELLSHORT possize CONTRACTS AT Bottom -11 stop ENDIF set target profit 50 set stop loss 170 IF CLOSE-TradePrice>25 THEN set stop loss 0 ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31

  // indicators and parameters defparam cumulateorders = false     defparam flatbefore = 083000 defparam flatafter =170000   possize = 10   IF TIME = 090000 THEN //include the 0910 candle Top = highest[6](high) // go back 8 candles Bottom = lowest[6](low) // go back 8 candles LongsForDay = 0 MaxPos = 1 ENDIF   IF TradeIndex = BarIndex THEN LongsForDay = LongsForDay +1 ENDIF   IF TIME >=090000 AND LongsForDay < MaxPos THEN BUY possize CONTRACTS AT Top +11 STOP SELLSHORT possize CONTRACTS AT Bottom -11 stop ENDIF   set target profit 50 set stop loss 170   IF CLOSE-TradePrice>25 THEN set stop loss 0 ENDIF

   

  

  Dave_the_trader

  Participant

  Topics: 1

  Replies: 10

  Been thanked: 0 times
  07/11/2018 at 1:35 PM #75797
  robertogozzi

  I suggest to replace

  IF CLOSE-TradePrice>25 THEN

  1	IF CLOSE-TradePrice>25 THEN

  with

  IF CLOSE-TradePrice>25*pipsize THEN

  1	IF CLOSE-TradePrice>25*pipsize THEN

  to make sure it works with alla instruments.

  Your code seems fine, the only correction to make is line 30, since I don’t think setting a SL to 0 works, you’d better replace thet line with

  SELLSHORT possize CONTRACTS AT Tradeprice stop

  1	SELLSHORT possize CONTRACTS AT Tradeprice stop

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16455

  Been thanked: 3636 times
  07/11/2018 at 2:15 PM #75800
  Vonasi

  You have long and short in the code so your stoploss change will not work anyway for both. Also Roberts suggestion of changing just the one line won’t work as if the price drops under the 25 pip gap the order will no longer be sent to market. You need something like this I think:

  if not onmarket then breakevenflag = 0 endif IF onmarket and ABS(CLOSE-TradePrice) > 25 THEN breakevenflag = 1 endif if breakevenflag = 1 then sell at positionprice stop exitshort at positionprice stop ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12

  if not onmarket then breakevenflag = 0 endif   IF onmarket and ABS(CLOSE-TradePrice) > 25 THEN breakevenflag = 1 endif   if breakevenflag = 1 then sell at positionprice stop exitshort at positionprice stop ENDIF

   

  1 user thanked author for this post.

  robertogozzi

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  07/11/2018 at 2:37 PM #75807
  Dave_the_trader

  Thanks, Ive made the changes however I get a syntax error, please help?

   

  // indicators and parameters defparam cumulateorders = false defparam flatbefore = 083000 defparam flatafter =170000 possize = 10 IF TIME = 090000 THEN //include the 0910 candle Top = highest[6](high) // go back 8 candles Bottom = lowest[6](low) // go back 8 candles LongsForDay = 0 MaxPos = 1 ENDIF IF TradeIndex = BarIndex THEN LongsForDay = LongsForDay +1 ENDIF IF TIME >=090000 AND LongsForDay < MaxPos THEN BUY possize CONTRACTS AT Top +11 STOP SELLSHORT possize CONTRACTS AT Bottom -11 stop ENDIF set target profit 50 set stop loss 170 IF not onmarket then breakevenflag = 0 ENDIF IF onmarket and ABS(CLOSE-TradePrice) > 25 THEN breakevenflag = 1 ENDIF IF breakevenflag = 1 THEN sellshort possize contracts at positionPrice stop sell possize contracts at positionprice stop endif

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39

  // indicators and parameters defparam cumulateorders = false   defparam flatbefore = 083000 defparam flatafter =170000   possize = 10   IF TIME = 090000 THEN //include the 0910 candle Top = highest[6](high) // go back 8 candles Bottom = lowest[6](low) // go back 8 candles LongsForDay = 0 MaxPos = 1 ENDIF   IF TradeIndex = BarIndex THEN LongsForDay = LongsForDay +1 ENDIF   IF TIME >=090000 AND LongsForDay < MaxPos THEN BUY possize CONTRACTS AT Top +11 STOP SELLSHORT possize CONTRACTS AT Bottom -11 stop ENDIF   set target profit 50 set stop loss 170   IF not onmarket then breakevenflag = 0 ENDIF   IF onmarket and ABS(CLOSE-TradePrice) > 25 THEN breakevenflag = 1 ENDIF   IF breakevenflag = 1 THEN sellshort possize contracts at positionPrice stop sell possize contracts at positionprice stop endif

   

  

  Dave_the_trader

  Participant

  Topics: 1

  Replies: 10

  Been thanked: 0 times
  07/11/2018 at 2:39 PM #75808
  Dave_the_trader

  Sorry I see it didnt copy it all

  // indicators and parameters defparam cumulateorders = false defparam flatbefore = 083000 defparam flatafter =170000 possize = 10 IF TIME = 090000 THEN //include the 0910 candle Top = highest[6](high) // go back 8 candles Bottom = lowest[6](low) // go back 8 candles LongsForDay = 0 MaxPos = 1 ENDIF IF TradeIndex = BarIndex THEN LongsForDay = LongsForDay +1 ENDIF IF TIME >=090000 AND LongsForDay < MaxPos THEN BUY possize CONTRACTS AT Top +11 STOP SELLSHORT possize CONTRACTS AT Bottom -11 stop ENDIF set target profit 50 set stop loss 170 IF not onmarket then breakevenflag = 0 ENDIF IF onmarket and ABS(CLOSE-TradePrice) > 25 THEN breakevenflag = 1 ENDIF IF breakevenflag = 1 THEN sellshort possize contracts at positionprice stop sell possize contracts at positionprice stop endif //IF CLOSE-TradePrice>25 THEN //set stop loss 0 ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43

  // indicators and parameters defparam cumulateorders = false   defparam flatbefore = 083000 defparam flatafter =170000   possize = 10   IF TIME = 090000 THEN //include the 0910 candle Top = highest[6](high) // go back 8 candles Bottom = lowest[6](low) // go back 8 candles LongsForDay = 0 MaxPos = 1 ENDIF   IF TradeIndex = BarIndex THEN LongsForDay = LongsForDay +1 ENDIF   IF TIME >=090000 AND LongsForDay < MaxPos THEN BUY possize CONTRACTS AT Top +11 STOP SELLSHORT possize CONTRACTS AT Bottom -11 stop ENDIF   set target profit 50 set stop loss 170   IF not onmarket then breakevenflag = 0 ENDIF   IF onmarket and ABS(CLOSE-TradePrice) > 25 THEN breakevenflag = 1 ENDIF   IF breakevenflag = 1 THEN sellshort possize contracts at positionprice stop sell possize contracts at positionprice stop endif   //IF CLOSE-TradePrice>25 THEN //set stop loss 0 ENDIF

   

  

  Dave_the_trader

  Participant

  Topics: 1

  Replies: 10

  Been thanked: 0 times
  07/11/2018 at 2:43 PM #75809
  Dave_the_trader

  OK so clearly you can see I’m not a coder!

  

  Dave_the_trader

  Participant

  Topics: 1

  Replies: 10

  Been thanked: 0 times
  07/11/2018 at 3:22 PM #75810
  Vonasi

  Please use the ‘Insert PRT Code’ button when posting code. I have tidied up your posts as best as I can but there was a lot of lines that were not PRT code so I had to guess a little.

  I think your syntax error is because you have an ENDIF at the end of the code that you do not need.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  07/11/2018 at 3:34 PM #75811
  Dave_the_trader

  Thank you so much, lets see how it behaves live tomorrow!

  

  Dave_the_trader

  Participant

  Topics: 1

  Replies: 10

  Been thanked: 0 times
  07/12/2018 at 8:10 AM #75841
  Dave_the_trader

  Ok, so it doesn’t work live

  

  Dave_the_trader

  Participant

  Topics: 1

  Replies: 10

  Been thanked: 0 times
  07/12/2018 at 8:20 AM #75842
  robertogozzi

  Line 32 does set BREAKEVENFLAG whenever you reach 25 pips, no matter whether you are in profit or loss, since it doesn’t tell between LONG and SHORT trades, I suggest replacing lines 32-34 with

  IF longonmarket and (CLOSE-TradePrice) > 25 THEN breakevenflag = 1 ELSIF shortonmarket and (TradePrice-close) > 25 THEN breakevenflag = 1 ENDIF

  1 2 3 4 5

  IF longonmarket and (CLOSE-TradePrice) > 25 THEN    breakevenflag = 1 ELSIF shortonmarket and (TradePrice-close) > 25 THEN    breakevenflag = 1 ENDIF

  you could actually combine the two IFs in just one line, but that would make the code much less clear.

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16455

  Been thanked: 3636 times
  07/12/2018 at 8:30 AM #75843
  Vonasi

  Thanks for spotting that Robert – you can tell that I never trade short – so my brain does not work very well in that direction!

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1810 times
  07/12/2018 at 9:00 AM #75844
  Dave_the_trader

  // indicators and parameters defparam cumulateorders = false defparam flatbefore = 083000 defparam flatafter =170000 possize = 2 IF TIME = 090000 THEN //include the 0910 candle Top = highest[6](high) // go back 8 candles Bottom = lowest[6](low) // go back 8 candles LongsForDay = 0 MaxPos = 1 ENDIF IF TradeIndex = BarIndex THEN LongsForDay = LongsForDay +1 ENDIF IF TIME >=090000 AND LongsForDay < MaxPos THEN BUY possize CONTRACTS AT Top +11 STOP SELLSHORT possize CONTRACTS AT Bottom -11 stop ENDIF set target profit 50 set stop loss 170 IF not onmarket then breakevenflag = 0 ENDIF IF longonmarket and (CLOSE-TradePrice) > 25 THEN breakevenflag = 1 ELSIF shortonmarket and (CLOSE-TradePrice-CLOSE) > 25 THEN breakevenflag = 1 ENDIF //IF breakevenflag = 1 THEN //sellshort possize contracts at positionprice stop //sell possize contracts at positionprice stop //ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41

  // indicators and parameters defparam cumulateorders = false   defparam flatbefore = 083000 defparam flatafter =170000   possize = 2   IF TIME = 090000 THEN //include the 0910 candle Top = highest[6](high) // go back 8 candles Bottom = lowest[6](low) // go back 8 candles LongsForDay = 0 MaxPos = 1 ENDIF   IF TradeIndex = BarIndex THEN LongsForDay = LongsForDay +1 ENDIF   IF TIME >=090000 AND LongsForDay < MaxPos THEN BUY possize CONTRACTS AT Top +11 STOP SELLSHORT possize CONTRACTS AT Bottom -11 stop ENDIF   set target profit 50 set stop loss 170   IF not onmarket then breakevenflag = 0 ENDIF   IF longonmarket and (CLOSE-TradePrice) > 25 THEN breakevenflag = 1 ELSIF shortonmarket and (CLOSE-TradePrice-CLOSE) > 25 THEN breakevenflag = 1 ENDIF   //IF breakevenflag = 1 THEN //sellshort possize contracts at positionprice stop //sell possize contracts at positionprice stop //ENDIF

   

  

  Dave_the_trader

  Participant

  Topics: 1

  Replies: 10

  Been thanked: 0 times
  07/12/2018 at 9:02 AM #75845
  Dave_the_trader

  Is the above correct?

  When I try activate it for automatic trading I get:

  – Code is invalid. Please correct it.

  

  Dave_the_trader

  Participant

  Topics: 1

  Replies: 10

  Been thanked: 0 times
  07/12/2018 at 10:17 AM #75849
  robertogozzi

  To write code, please use the <> “insert PRT code” button to make code easier to read and understand. Thank you.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16455

  Been thanked: 3636 times
  07/12/2018 at 10:20 AM #75853
  robertogozzi

  Dave_the_trader wrote:

  Is the above correct?

  When I try activate it for automatic trading I get:

  – Code is invalid. Please correct it.

  The only warning I get is that the variable BREAKEVENFLAG is not used. Why keeping it if you don’t use it?

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16455

  Been thanked: 3636 times
• Author
  Posts