profit reduces by 33%

• 04/24/2018 at 7:51 AM #69043
  rama

  I have a buy order

  initial stop is 20

   

  market went in my favor say to 30,40,50 etc

  when market moves back  I want keep  66 .6 profit

  if longonmarket then

  if  ( x-close)<=.66*(close-tradeprice) then

  sell at market

  endif

  endif

   

  what is the X? how to code variable X

   

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  04/24/2018 at 9:24 AM #69049
  robertogozzi

  Try this one

  IF LongOnMarket AND close > TradePrice THEN x = (close - tradeprice) / pipsize //convert price to pips IF x >= 30 THEN //go ahead only if 30+ pips y = x * 0.666 //y = 66.6% of current profit SELL AT close - (y * pipsize) STOP //convert pips to price ENDIF ENDIF

  1 2 3 4 5 6 7

  IF LongOnMarket AND close > TradePrice THEN    x = (close - tradeprice) / pipsize         //convert price to pips    IF x >= 30 THEN                            //go ahead only if 30+ pips       y = x * 0.666                           //y = 66.6% of current profit       SELL AT close - (y * pipsize) STOP      //convert pips to price    ENDIF ENDIF

  Roberto

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16450

  Been thanked: 3634 times
  04/24/2018 at 9:34 AM #69052
  GraHal

  I’ve added above to the Snippet Link Database

  https://docs.google.com/spreadsheets/d/1rgboqj7sVwsP9ZRhOduOefye48QMWC07jWVXCl-KJPU/edit?usp=sharing

  Thank You @robertogozzi

  1 user thanked author for this post.

  AlgoAlex

  

  GraHal

  Participant

  Topics: 203

  Replies: 8373

  Been thanked: 2024 times
  04/24/2018 at 9:55 AM #69055
  robertogozzi

  GraHal wrote:

  I’ve added above to the Snippet Link Database

  https://docs.google.com/spreadsheets/d/1rgboqj7sVwsP9ZRhOduOefye48QMWC07jWVXCl-KJPU/edit?usp=sharing

  Thank You @robertogozzi

  Sorry GraHal, I forgot to (as I do most of times). Thanks for paying attention.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16450

  Been thanked: 3634 times
  04/24/2018 at 10:55 AM #69065
  rama

  Thanks for your fast reply Roberto. I have am back testing this now, will take another 4 to 5 hours get decent result.

  I my guess it may not work, as soon as the  profit falls below the 30 , the stop will go to the original stop loss

  I am keeping fingers crossed, I will post the results by EoD today

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  04/24/2018 at 11:04 AM #69067
  robertogozzi

  This trailing SL is hard coded in your strategy, not managed by ProOrder or your broker, it’s a pending order to be set at each new candle.

  You may as well have set your stop ploss at, say 100 pips, but still exit in profit as this code is progressing candle after candle.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16450

  Been thanked: 3634 times
  04/24/2018 at 11:37 AM #69071
  rama

  please find the screen shots

  if max profit once gone past 30 say 36

  I want keep stop loss .66(tradeprice+36) at least in the event market is coming back.

  on the other hand if the profit goes to 60 i want keep .66(tradeprice+60)

   

  I tested the code is not working, as the price keeps falling after >=30 SL coming down by .33%

   

   

   

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  04/24/2018 at 11:49 AM #69074
  robertogozzi

  Well… It works almost like that, but if it reaches 50 pips profit Y will be set to 33.3, but if the next candle decreases to 40 pips profit, it won’t keep 33.3 but will decrease to 26.6.

  I will make a change.

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16450

  Been thanked: 3634 times
  04/24/2018 at 11:55 AM #69075
  robertogozzi

  This should work

  IF Not OnMarket THEN y = 0 ENDIF IF LongOnMarket AND close > TradePrice THEN x = (close - tradeprice) / pipsize //convert price to pips IF x >= 30 THEN //go ahead only if 30+ pips y = max(x * 0.666, y) //y = 66.6% of max profit SELL AT close - (y * pipsize) STOP //convert pips to price ENDIF ENDIF

  1 2 3 4 5 6 7 8 9 10

  IF Not OnMarket THEN    y = 0 ENDIF IF LongOnMarket AND close > TradePrice THEN    x = (close - tradeprice) / pipsize         //convert price to pips    IF x >= 30 THEN                            //go ahead only if 30+ pips       y = max(x * 0.666, y)                   //y = 66.6% of max profit       SELL AT close - (y * pipsize) STOP      //convert pips to price    ENDIF ENDIF

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 16450

  Been thanked: 3634 times
  04/24/2018 at 11:55 AM #69076
  rama

  I am running the strategy on 3 sec or 5 seconds range.

  it is keeping changing, the whole is ideas is keep some profits.

   

  how above set stop loss trailing SL

  SL=(1-y)

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  04/24/2018 at 12:31 PM #69080
  rama

  thanks, I am doing back testing, will update the feedback soon

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  04/25/2018 at 1:24 AM #69110
  rama

  I have back tested even modified code is not working

  it strange.

   

   

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  04/25/2018 at 6:43 AM #69118
  Leo

  IF LongOnMarket AND close > TradePrice THEN x = (close - tradeprice) / pipsize //convert price to pips MaxX=MaxX=max(x,MaxX) //store the max profit during trade IF x >= 30 THEN //go ahead only if 30+ pips y = MaxX * 0.666 //y = 66.6% of current profit SELL AT TradePrice + Y*pipsize STOP //convert pips to price ENDIF ENDIF

  1 2 3 4 5 6 7 8

  IF LongOnMarket AND close > TradePrice THEN    x = (close - tradeprice) / pipsize         //convert price to pips    MaxX=MaxX=max(x,MaxX) //store the max profit during trade IF x >= 30 THEN                            //go ahead only if 30+ pips       y = MaxX * 0.666                       //y = 66.6% of current profit       SELL AT TradePrice + Y*pipsize STOP      //convert pips to price    ENDIF ENDIF

   

  Try this.

   

  

  Leo

  Participant

  Topics: 17

  Replies: 357

  Been thanked: 144 times
  04/25/2018 at 7:01 AM #69120
  Madrosat

  Hello Léo

  I don’t understand  : MaxX=MaxX=max(x,MaxX)

  could you explain me  well detailed ??

  

  Madrosat

  Participant

  Topics: 23

  Replies: 220

  Been thanked: 9 times
  04/25/2018 at 11:57 AM #69128
  rama

  back testing is on , collecting sample data before conclude whether the code works or not.

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
• Author
  Posts